Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53253/?format=api
{ "id": 53253, "url": "http://patches.dpdk.org/api/patches/53253/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190503140901.59064-4-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190503140901.59064-4-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190503140901.59064-4-bruce.richardson@intel.com", "date": "2019-05-03T14:09:00", "name": "[RFC,3/4] examples/vm_power_manager: always compile all C files", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": true, "hash": "9b94ba1050efa22c9ffb0b8e17bf3143190a2202", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190503140901.59064-4-bruce.richardson@intel.com/mbox/", "series": [ { "id": 4555, "url": "http://patches.dpdk.org/api/series/4555/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4555", "date": "2019-05-03T14:08:57", "name": "allow vm_power_manager to build using pkg-config", "version": 1, "mbox": "http://patches.dpdk.org/series/4555/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53253/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/53253/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 820125F20;\n\tFri, 3 May 2019 16:09:17 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n\tby dpdk.org (Postfix) with ESMTP id 9748D5F14\n\tfor <dev@dpdk.org>; Fri, 3 May 2019 16:09:15 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t03 May 2019 07:09:15 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.222.236])\n\tby orsmga003.jf.intel.com with ESMTP; 03 May 2019 07:09:14 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,426,1549958400\"; d=\"scan'208\";a=\"147884579\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "david.hunt@intel.com", "Cc": "dev@dpdk.org,\n\tBruce Richardson <bruce.richardson@intel.com>", "Date": "Fri, 3 May 2019 15:09:00 +0100", "Message-Id": "<20190503140901.59064-4-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190503140901.59064-1-bruce.richardson@intel.com>", "References": "<20190503140901.59064-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [RFC PATCH 3/4] examples/vm_power_manager: always\n\tcompile all C files", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Rather than having an \"if\" statement in the makefile to select one of two\nfiles to build, we can put #ifdefs into the C files themselves so that all\nfiles are always built.\n\nThis is a better approach as the makefile-based approach relies on having\nthe DPDK build system with all it's config settings available. When\nbuilding using info from a pkg-config file, this build configuration\ninformation is not going to be available to the makefile - though it will\nbe available to the preprocessor through rte_config.h header.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n examples/vm_power_manager/Makefile | 3 ---\n examples/vm_power_manager/meson.build | 16 ++++++++--------\n examples/vm_power_manager/oob_monitor_nop.c | 4 ++++\n examples/vm_power_manager/oob_monitor_x86.c | 4 ++++\n 4 files changed, 16 insertions(+), 11 deletions(-)", "diff": "diff --git a/examples/vm_power_manager/Makefile b/examples/vm_power_manager/Makefile\nindex d93f900f7..6e573916a 100644\n--- a/examples/vm_power_manager/Makefile\n+++ b/examples/vm_power_manager/Makefile\n@@ -20,11 +20,8 @@ APP = vm_power_mgr\n # all source are stored in SRCS-y\n SRCS-y := main.c vm_power_cli.c power_manager.c channel_manager.c\n SRCS-y += channel_monitor.c parse.c\n-ifeq ($(CONFIG_RTE_ARCH_X86_64),y)\n SRCS-y += oob_monitor_x86.c\n-else\n SRCS-y += oob_monitor_nop.c\n-endif\n \n CFLAGS += -O3\n CFLAGS += $(WERROR_FLAGS)\ndiff --git a/examples/vm_power_manager/meson.build b/examples/vm_power_manager/meson.build\nindex f98445bc6..384c778ef 100644\n--- a/examples/vm_power_manager/meson.build\n+++ b/examples/vm_power_manager/meson.build\n@@ -22,16 +22,16 @@ deps += ['power']\n \n \n sources = files(\n-\t'channel_manager.c', 'channel_monitor.c', 'main.c', 'parse.c', 'power_manager.c', 'vm_power_cli.c'\n+\t'channel_manager.c',\n+\t'channel_monitor.c',\n+\t'main.c',\n+\t'oob_monitor_nop.c',\n+\t'oob_monitor_x86.c',\n+\t'parse.c',\n+\t'power_manager.c',\n+\t'vm_power_cli.c'\n )\n \n-# If we're on X86, pull in the x86 code for the branch monitor algo.\n-if dpdk_conf.has('RTE_ARCH_X86_64')\n-\tsources += files('oob_monitor_x86.c')\n-else\n-\tsources += files('oob_monitor_nop.c')\n-endif\n-\n opt_dep = cc.find_library('virt', required : false)\n build = opt_dep.found()\n ext_deps += opt_dep\ndiff --git a/examples/vm_power_manager/oob_monitor_nop.c b/examples/vm_power_manager/oob_monitor_nop.c\nindex 7e7b8bc14..90daa7e9b 100644\n--- a/examples/vm_power_manager/oob_monitor_nop.c\n+++ b/examples/vm_power_manager/oob_monitor_nop.c\n@@ -2,6 +2,8 @@\n * Copyright(c) 2010-2014 Intel Corporation\n */\n \n+#ifndef RTE_ARCH_X86_64 /* X86_64 has separate implementation in another file */\n+\n #include \"oob_monitor.h\"\n \n void branch_monitor_exit(void)\n@@ -36,3 +38,5 @@ void\n run_branch_monitor(void)\n {\n }\n+\n+#endif\ndiff --git a/examples/vm_power_manager/oob_monitor_x86.c b/examples/vm_power_manager/oob_monitor_x86.c\nindex ebd96b205..f41bba6ab 100644\n--- a/examples/vm_power_manager/oob_monitor_x86.c\n+++ b/examples/vm_power_manager/oob_monitor_x86.c\n@@ -2,6 +2,8 @@\n * Copyright(c) 2018 Intel Corporation\n */\n \n+#ifdef RTE_ARCH_X86_64 /* this file is only for X86_64 */\n+\n #include <unistd.h>\n #include <fcntl.h>\n #include <rte_log.h>\n@@ -269,3 +271,5 @@ run_branch_monitor(void)\n \t\t}\n \t}\n }\n+\n+#endif /* RTE_ARCH_X86_64 */\n", "prefixes": [ "RFC", "3/4" ] }