Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 53238,
    "url": "http://patches.dpdk.org/api/patches/53238/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190503102857.15812-3-herakliusz.lipiec@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190503102857.15812-3-herakliusz.lipiec@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190503102857.15812-3-herakliusz.lipiec@intel.com",
    "date": "2019-05-03T10:28:57",
    "name": "[v5,2/2] net/tap: fix ipc related memory leak",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "46c82ed4449e2c6bd52fdea76cb62d069ce0a282",
    "submitter": {
        "id": 742,
        "url": "http://patches.dpdk.org/api/people/742/?format=api",
        "name": "Herakliusz Lipiec",
        "email": "herakliusz.lipiec@intel.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190503102857.15812-3-herakliusz.lipiec@intel.com/mbox/",
    "series": [
        {
            "id": 4551,
            "url": "http://patches.dpdk.org/api/series/4551/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4551",
            "date": "2019-05-03T10:28:55",
            "name": "ipc: fix possible memory leaks",
            "version": 5,
            "mbox": "http://patches.dpdk.org/series/4551/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/53238/comments/",
    "check": "fail",
    "checks": "http://patches.dpdk.org/api/patches/53238/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C93CB4CA7;\n\tFri,  3 May 2019 12:28:09 +0200 (CEST)",
            "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby dpdk.org (Postfix) with ESMTP id 265604C8D;\n\tFri,  3 May 2019 12:28:08 +0200 (CEST)",
            "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t03 May 2019 03:28:07 -0700",
            "from silpixa00399499.ir.intel.com (HELO\n\tsilpixa00399499.ger.corp.intel.com) ([10.237.222.133])\n\tby orsmga005.jf.intel.com with ESMTP; 03 May 2019 03:28:06 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.60,425,1549958400\"; d=\"scan'208\";a=\"321103775\"",
        "From": "Herakliusz Lipiec <herakliusz.lipiec@intel.com>",
        "To": "Keith Wiles <keith.wiles@intel.com>",
        "Cc": "dev@dpdk.org, Herakliusz Lipiec <herakliusz.lipiec@intel.com>,\n\trasland@mellanox.com, stable@dpdk.org",
        "Date": "Fri,  3 May 2019 11:28:57 +0100",
        "Message-Id": "<20190503102857.15812-3-herakliusz.lipiec@intel.com>",
        "X-Mailer": "git-send-email 2.17.2",
        "In-Reply-To": "<20190503102857.15812-1-herakliusz.lipiec@intel.com>",
        "References": "<20190425124817.28409-1-herakliusz.lipiec@intel.com>\n\t<20190503102857.15812-1-herakliusz.lipiec@intel.com>",
        "Subject": "[dpdk-dev] [PATCH v5 2/2] net/tap: fix ipc related memory leak",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "When sending synchronous IPC requests, the caller must free the response\nbuffer if the request was successful and reply is no longer needed.\nFix the code to correctly use the IPC API.\n\nBugzilla ID: 228\nFixes: c9aa56edec8e (\"net/tap: access primary process queues from secondary\")\nCc: rasland@mellanox.com\nCc: stable@dpdk.org\n\nSigned-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>\nAcked-by: Keith Wiles <keith.wiles@intel.com>\n---\n drivers/net/tap/rte_eth_tap.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c\nindex 7f74b5dc9..f8a4169c5 100644\n--- a/drivers/net/tap/rte_eth_tap.c\n+++ b/drivers/net/tap/rte_eth_tap.c\n@@ -2118,7 +2118,7 @@ tap_mp_attach_queues(const char *port_name, struct rte_eth_dev *dev)\n \t\tprocess_private->rxq_fds[queue] = reply->fds[fd_iterator++];\n \tfor (queue = 0; queue < reply_param->txq_count; queue++)\n \t\tprocess_private->txq_fds[queue] = reply->fds[fd_iterator++];\n-\n+\tfree(reply);\n \treturn 0;\n }\n \n",
    "prefixes": [
        "v5",
        "2/2"
    ]
}