Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53231/?format=api
{ "id": 53231, "url": "http://patches.dpdk.org/api/patches/53231/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190502165154.21746-4-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190502165154.21746-4-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190502165154.21746-4-bruce.richardson@intel.com", "date": "2019-05-02T16:51:53", "name": "[v4,3/4] build: fix ninja install on FreeBSD", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "11c5d44ea7096cbf5c95c54b7a956adc6392fa28", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190502165154.21746-4-bruce.richardson@intel.com/mbox/", "series": [ { "id": 4547, "url": "http://patches.dpdk.org/api/series/4547/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4547", "date": "2019-05-02T16:51:50", "name": "file meson compilation and install issues", "version": 4, "mbox": "http://patches.dpdk.org/series/4547/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53231/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/53231/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C9A061B1F1;\n\tThu, 2 May 2019 18:52:13 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id AFCB61B1DD\n\tfor <dev@dpdk.org>; Thu, 2 May 2019 18:52:09 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t02 May 2019 09:52:09 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.222.236])\n\tby FMSMGA003.fm.intel.com with ESMTP; 02 May 2019 09:52:08 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,422,1549958400\"; d=\"scan'208\";a=\"154194145\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "thomas@monjalon.net", "Cc": "dev@dpdk.org, bluca@debian.org,\n\tBruce Richardson <bruce.richardson@intel.com>", "Date": "Thu, 2 May 2019 17:51:53 +0100", "Message-Id": "<20190502165154.21746-4-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.21.0", "In-Reply-To": "<20190502165154.21746-1-bruce.richardson@intel.com>", "References": "<20190426165043.17268-1-bruce.richardson@intel.com>\n\t<20190502165154.21746-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v4 3/4] build: fix ninja install on FreeBSD", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The post-install script to symlink the PMDs from their own PMD directory to\nthe regular lib directory (so they would be found by ld at runtime) was\nusing the \"-r\" flag to ln to create relative symlinks. This flag is\nunsupported by ln on FreeBSD causing the ninja install step to fail.\n\nReworking the script to take the relative driver path as parameter removes\nthe need for ln to calculate the relative path ensuring compatibility with\nFreeBSD.\n\nAs part of the fix, we move the registration of the install script to the\nconfig/meson.build file, from the top level one. This improves readability\nas the script takes as parameters the variables set in that file.\n\nFixes: ed4d43d73e2b (\"build: symlink drivers to library directory\")\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Luca Boccassi <bluca@debian.org>\n---\n buildtools/symlink-drivers-solibs.sh | 7 ++++---\n config/meson.build | 7 +++++++\n meson.build | 7 -------\n 3 files changed, 11 insertions(+), 10 deletions(-)", "diff": "diff --git a/buildtools/symlink-drivers-solibs.sh b/buildtools/symlink-drivers-solibs.sh\nindex 9826c6ae3..42985e855 100644\n--- a/buildtools/symlink-drivers-solibs.sh\n+++ b/buildtools/symlink-drivers-solibs.sh\n@@ -7,6 +7,7 @@\n # others, e.g. PCI device PMDs depending on the PCI bus driver.\n \n # parameters to script are paths relative to install prefix:\n-# 1. directory containing driver files e.g. lib64/dpdk/drivers\n-# 2. directory for installed regular libs e.g. lib64\n-ln -rsf ${DESTDIR}/${MESON_INSTALL_PREFIX}/$1/* ${DESTDIR}/${MESON_INSTALL_PREFIX}/$2\n+# 1. directory for installed regular libs e.g. lib64\n+# 2. subdirectory of libdir where the pmds are\n+\n+cd ${MESON_INSTALL_DESTDIR_PREFIX}/$1 && ln -sfv $2/librte_*.so* .\ndiff --git a/config/meson.build b/config/meson.build\nindex f8aded6ed..3678348de 100644\n--- a/config/meson.build\n+++ b/config/meson.build\n@@ -42,6 +42,13 @@ endif\n driver_install_path = join_paths(get_option('libdir'), pmd_subdir_opt)\n eal_pmd_path = join_paths(get_option('prefix'), driver_install_path)\n \n+# driver .so files often depend upon the bus drivers for their connect bus,\n+# e.g. ixgbe depends on librte_bus_pci. This means that the bus drivers need\n+# to be in the library path, so symlink the drivers from the main lib directory.\n+meson.add_install_script('../buildtools/symlink-drivers-solibs.sh',\n+\t\tget_option('libdir'),\n+\t\tpmd_subdir_opt)\n+\n # set the machine type and cflags for it\n if meson.is_cross_build()\n \tmachine = host_machine.cpu()\ndiff --git a/meson.build b/meson.build\nindex a96486597..d1e8e5239 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -63,13 +63,6 @@ configure_file(output: build_cfg,\n # them.\n dpdk_drivers = ['-Wl,--whole-archive'] + dpdk_drivers + ['-Wl,--no-whole-archive']\n \n-# driver .so files often depend upon the bus drivers for their connect bus,\n-# e.g. ixgbe depends on librte_bus_pci. This means that the bus drivers need\n-# to be in the library path, so symlink the drivers from the main lib directory.\n-meson.add_install_script('buildtools/symlink-drivers-solibs.sh',\n-\t\tdriver_install_path,\n-\t\tget_option('libdir'))\n-\n pkg = import('pkgconfig')\n pkg.generate(name: meson.project_name(),\n \tfilebase: 'lib' + meson.project_name().to_lower(),\n", "prefixes": [ "v4", "3/4" ] }