Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 53224,
    "url": "http://patches.dpdk.org/api/patches/53224/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/c85536ec3c5ab40ef85f11ca0d175d15277f2a83.1556809050.git.dekelp@mellanox.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<c85536ec3c5ab40ef85f11ca0d175d15277f2a83.1556809050.git.dekelp@mellanox.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/c85536ec3c5ab40ef85f11ca0d175d15277f2a83.1556809050.git.dekelp@mellanox.com",
    "date": "2019-05-02T15:01:55",
    "name": "[v2,2/4] net/mlx5: fix missing validation of null pointer",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "463698aacaecaa0f809dbb5345e9add4b16d0916",
    "submitter": {
        "id": 1082,
        "url": "http://patches.dpdk.org/api/people/1082/?format=api",
        "name": "Dekel Peled",
        "email": "dekelp@mellanox.com"
    },
    "delegate": {
        "id": 6624,
        "url": "http://patches.dpdk.org/api/users/6624/?format=api",
        "username": "shahafs",
        "first_name": "Shahaf",
        "last_name": "Shuler",
        "email": "shahafs@mellanox.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/c85536ec3c5ab40ef85f11ca0d175d15277f2a83.1556809050.git.dekelp@mellanox.com/mbox/",
    "series": [
        {
            "id": 4545,
            "url": "http://patches.dpdk.org/api/series/4545/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4545",
            "date": "2019-05-02T15:01:53",
            "name": "net/mlx5: code cleanup in rx and tx files",
            "version": 2,
            "mbox": "http://patches.dpdk.org/series/4545/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/53224/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/53224/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C74381B11A;\n\tThu,  2 May 2019 17:04:53 +0200 (CEST)",
            "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id E05281B113\n\tfor <dev@dpdk.org>; Thu,  2 May 2019 17:04:50 +0200 (CEST)",
            "from Internal Mail-Server by MTLPINE2 (envelope-from\n\tdekelp@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 2 May 2019 18:04:48 +0300",
            "from mtl-vdi-280.wap.labs.mlnx. (mtl-vdi-280.wap.labs.mlnx\n\t[10.128.130.87])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x42F4ilU009153;\n\tThu, 2 May 2019 18:04:48 +0300"
        ],
        "From": "Dekel Peled <dekelp@mellanox.com>",
        "To": "yskoh@mellanox.com, shahafs@mellanox.com",
        "Cc": "dev@dpdk.org, stable@dpdk.org",
        "Date": "Thu,  2 May 2019 18:01:55 +0300",
        "Message-Id": "<c85536ec3c5ab40ef85f11ca0d175d15277f2a83.1556809050.git.dekelp@mellanox.com>",
        "X-Mailer": "git-send-email 1.7.1",
        "In-Reply-To": "<cover.1556809050.git.dekelp@mellanox.com>",
        "References": "<cover.1556534247.git.dekelp@mellanox.com>\n\t<cover.1556809050.git.dekelp@mellanox.com>",
        "Subject": "[dpdk-dev] [PATCH v2 2/4] net/mlx5: fix missing validation of null\n\tpointer",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Function mlx5_rxq_ibv_release() is called in several places.\nBefore each call except one, the input parameter is validated to make\nsure it is not null.\n\nThis patch adds the missing validation where it is missing.\n\nFixes: af4f09f28294 (\"net/mlx5: prefix all functions with mlx5\")\nCc: stable@dpdk.org\n\nSigned-off-by: Dekel Peled <dekelp@mellanox.com>\n---\n drivers/net/mlx5/mlx5_rxq.c | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)",
    "diff": "diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c\nindex db8c340..c9c2a14 100644\n--- a/drivers/net/mlx5/mlx5_rxq.c\n+++ b/drivers/net/mlx5/mlx5_rxq.c\n@@ -617,7 +617,8 @@\n \t\t */\n \t\trxq_data = (*priv->rxqs)[i];\n \t\trxq_ctrl = container_of(rxq_data, struct mlx5_rxq_ctrl, rxq);\n-\t\tmlx5_rxq_ibv_release(rxq_ctrl->ibv);\n+\t\tif (rxq_ctrl->ibv)\n+\t\t\tmlx5_rxq_ibv_release(rxq_ctrl->ibv);\n \t}\n free:\n \trte_intr_free_epoll_fd(intr_handle);\n",
    "prefixes": [
        "v2",
        "2/4"
    ]
}