Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 53195,
    "url": "http://patches.dpdk.org/api/patches/53195/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190501195014.2938-4-bruce.richardson@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190501195014.2938-4-bruce.richardson@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190501195014.2938-4-bruce.richardson@intel.com",
    "date": "2019-05-01T19:50:13",
    "name": "[3/4] raw/skeleton_rawdev: fix warnings with GCC 9 on Fedora 30",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "60259ab445da4cb3cb0d47dbd2f94be37a302366",
    "submitter": {
        "id": 20,
        "url": "http://patches.dpdk.org/api/people/20/?format=api",
        "name": "Bruce Richardson",
        "email": "bruce.richardson@intel.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190501195014.2938-4-bruce.richardson@intel.com/mbox/",
    "series": [
        {
            "id": 4529,
            "url": "http://patches.dpdk.org/api/series/4529/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4529",
            "date": "2019-05-01T19:50:10",
            "name": "fix warnings with gcc 9 on Fedora 30",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/4529/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/53195/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/53195/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2F1E02BA2;\n\tWed,  1 May 2019 21:50:31 +0200 (CEST)",
            "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id D1F772BA2\n\tfor <dev@dpdk.org>; Wed,  1 May 2019 21:50:28 +0200 (CEST)",
            "from orsmga006.jf.intel.com ([10.7.209.51])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t01 May 2019 12:50:28 -0700",
            "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.222.236])\n\tby orsmga006.jf.intel.com with ESMTP; 01 May 2019 12:50:27 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.60,418,1549958400\"; d=\"scan'208\";a=\"140463408\"",
        "From": "Bruce Richardson <bruce.richardson@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n\tshreyansh.jain@nxp.com",
        "Date": "Wed,  1 May 2019 20:50:13 +0100",
        "Message-Id": "<20190501195014.2938-4-bruce.richardson@intel.com>",
        "X-Mailer": "git-send-email 2.21.0",
        "In-Reply-To": "<20190501195014.2938-1-bruce.richardson@intel.com>",
        "References": "<20190501195014.2938-1-bruce.richardson@intel.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH 3/4] raw/skeleton_rawdev: fix warnings with GCC 9\n\ton Fedora 30",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "GCC9 gives warnings if the parameter passed to printf for \"%s\" could be\nNULL, so we need to add checks in some cases to ensure that is not the\ncase.\n\nFixes: 61c592a8d035 (\"raw/skeleton: introduce skeleton rawdev driver\")\nCc: shreyansh.jain@nxp.com\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/raw/skeleton_rawdev/skeleton_rawdev.c | 5 +++++\n 1 file changed, 5 insertions(+)",
    "diff": "diff --git a/drivers/raw/skeleton_rawdev/skeleton_rawdev.c b/drivers/raw/skeleton_rawdev/skeleton_rawdev.c\nindex d7630fc69..63f2b9a09 100644\n--- a/drivers/raw/skeleton_rawdev/skeleton_rawdev.c\n+++ b/drivers/raw/skeleton_rawdev/skeleton_rawdev.c\n@@ -705,6 +705,9 @@ skeleton_rawdev_probe(struct rte_vdev_device *vdev)\n \n \n \tname = rte_vdev_device_name(vdev);\n+\tif (name == NULL)\n+\t\treturn -EINVAL;\n+\n \t/* More than one instance is not supported */\n \tif (skeldev_init_once) {\n \t\tSKELETON_PMD_ERR(\"Multiple instance not supported for %s\",\n@@ -740,6 +743,8 @@ skeleton_rawdev_remove(struct rte_vdev_device *vdev)\n \tint ret;\n \n \tname = rte_vdev_device_name(vdev);\n+\tif (name == NULL)\n+\t\treturn -1;\n \n \tSKELETON_PMD_INFO(\"Closing %s on NUMA node %d\", name, rte_socket_id());\n \n",
    "prefixes": [
        "3/4"
    ]
}