Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 53190,
    "url": "http://patches.dpdk.org/api/patches/53190/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190501155329.50107-4-bruce.richardson@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190501155329.50107-4-bruce.richardson@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190501155329.50107-4-bruce.richardson@intel.com",
    "date": "2019-05-01T15:53:29",
    "name": "[3/3] crypto/zuc: fix dependency check",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "038fe8698b7f53c1ca9ce418dd3dadf4294bc6e0",
    "submitter": {
        "id": 20,
        "url": "http://patches.dpdk.org/api/people/20/?format=api",
        "name": "Bruce Richardson",
        "email": "bruce.richardson@intel.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190501155329.50107-4-bruce.richardson@intel.com/mbox/",
    "series": [
        {
            "id": 4527,
            "url": "http://patches.dpdk.org/api/series/4527/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4527",
            "date": "2019-05-01T15:53:26",
            "name": "small fixes for crypto drivers",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/4527/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/53190/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/53190/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7E2DD3257;\n\tWed,  1 May 2019 17:53:46 +0200 (CEST)",
            "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby dpdk.org (Postfix) with ESMTP id 2044E2C55\n\tfor <dev@dpdk.org>; Wed,  1 May 2019 17:53:42 +0200 (CEST)",
            "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t01 May 2019 08:53:42 -0700",
            "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.222.236])\n\tby orsmga008.jf.intel.com with ESMTP; 01 May 2019 08:53:41 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.60,418,1549958400\"; d=\"scan'208\";a=\"139026099\"",
        "From": "Bruce Richardson <bruce.richardson@intel.com>",
        "To": "pablo.de.lara.guarch@intel.com",
        "Cc": "dev@dpdk.org,\n\tBruce Richardson <bruce.richardson@intel.com>",
        "Date": "Wed,  1 May 2019 16:53:29 +0100",
        "Message-Id": "<20190501155329.50107-4-bruce.richardson@intel.com>",
        "X-Mailer": "git-send-email 2.21.0",
        "In-Reply-To": "<20190501155329.50107-1-bruce.richardson@intel.com>",
        "References": "<20190501155329.50107-1-bruce.richardson@intel.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH 3/3] crypto/zuc: fix dependency check",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The check for the zuc library dependency did not check for the include\nfile needed for compilation. It's also recommended when looking for a\nlibrary to use the name without the lib prefix.\n\nFixes: df1740a8db5f (\"crypto/zuc: enable meson build\")\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/crypto/zuc/meson.build | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/drivers/crypto/zuc/meson.build b/drivers/crypto/zuc/meson.build\nindex 63f2a5298..fc2900244 100644\n--- a/drivers/crypto/zuc/meson.build\n+++ b/drivers/crypto/zuc/meson.build\n@@ -1,13 +1,13 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2018 Intel Corporation\n \n-lib = cc.find_library('libsso_zuc', required: false)\n-if not lib.found()\n+lib = cc.find_library('sso_zuc', required: false)\n+if not lib.found() or not cc.has_header('sso_zuc.h')\n \tbuild = false\n-else\n-\text_deps += lib\n+\tsubdir_done()\n endif\n \n allow_experimental_apis = true\n+ext_deps += lib\n sources = files('rte_zuc_pmd.c', 'rte_zuc_pmd_ops.c')\n deps += ['bus_vdev']\n",
    "prefixes": [
        "3/3"
    ]
}