Patch Comment List
List patch comments
GET /api/patches/53182/comments/?format=api
[ { "id": 95842, "web_url": "http://patches.dpdk.org/comment/95842/", "msgid": "<CAJFAV8x9MQn8r3-Xdbs9s+U5Gfrg5OyKyUCxqyy4G5s5M_WBpQ@mail.gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/CAJFAV8x9MQn8r3-Xdbs9s+U5Gfrg5OyKyUCxqyy4G5s5M_WBpQ@mail.gmail.com", "date": "2019-05-03T14:31:19", "subject": "Re: [dpdk-dev] [PATCH v9 2/4] test/rcu_qsbr: add API and functional\n\ttests", "submitter": { "id": 1173, "url": "http://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "content": "On Wed, May 1, 2019 at 5:55 AM Honnappa Nagarahalli <\nhonnappa.nagarahalli@arm.com> wrote:\n\n> From: Dharmik Thakkar <dharmik.thakkar@arm.com>\n>\n> Add API positive/negative test cases, functional tests and\n> performance tests.\n>\n> Signed-off-by: Malvika Gupta <malvika.gupta@arm.com>\n> Signed-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>\n> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\n> Reviewed-by: Gavin Hu <gavin.hu@arm.com>\n> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\n>\n\nDid not investigate, but this test always fails on my laptop.\nTried multiple times, I caught one instance when the test was still burning\ncpu after 5 minutes and I killed it.\n\nUsually, it fails like this:\n\n[dmarchan@dmarchan dpdk]$ ./master/app/test -c 0x1f -n 4 --no-huge\nEAL: Detected 8 lcore(s)\nEAL: Detected 1 NUMA nodes\nEAL: Multi-process socket /run/user/114840/dpdk/rte/mp_socket\nEAL: Probing VFIO support...\nEAL: Started without hugepages support, physical addresses not available\nEAL: PCI device 0000:00:1f.6 on NUMA socket -1\nEAL: Invalid NUMA socket, default to 0\nEAL: probe driver: 8086:15d7 net_e1000_em\nAPP: HPET is not enabled, using TSC as default timer\nRTE>>rcu_qsbr_perf_autotest\nNumber of cores provided = 4\nPerf test with all reader threads registered\n--------------------------------------------\n\nPerf Test: 3 Readers/1 Writer('wait' in qsbr_check == true)\nTotal RCU updates = 945401635\nCycles per 1000 updates: 25157\nTotal RCU checks = 20000000\nCycles per 1000 checks: 396375\n\nPerf Test: 4 Readers\nTotal RCU updates = 400000000\nCycles per 1000 updates: 6241\n\nPerf test: 4 Writers ('wait' in qsbr_check == false)\nTotal RCU checks = 80000000\nCycles per 1000 checks: 21061\n\nPerf test: 1 writer, 4 readers, 1 QSBR variable, 1 QSBR Query, Blocking\nQSBR Check\nReader did not complete #28 = 4097\nTest Failed\nRTE>>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id B72305B38;\n\tFri, 3 May 2019 16:31:33 +0200 (CEST)", "from mail-ua1-f67.google.com (mail-ua1-f67.google.com\n\t[209.85.222.67]) by dpdk.org (Postfix) with ESMTP id 821345A6E\n\tfor <dev@dpdk.org>; Fri, 3 May 2019 16:31:32 +0200 (CEST)", "by mail-ua1-f67.google.com with SMTP id t15so2075195uao.5\n\tfor <dev@dpdk.org>; Fri, 03 May 2019 07:31:32 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:mime-version:references:in-reply-to:from:date\n\t:message-id:subject:to:cc;\n\tbh=5VQ7MFoDOECTqPoHKLcNG9GOSCPUAgx3FV1SJDfna4c=;\n\tb=UPBMr2Nn/fr3mU3Qeu1iRLC9LMI+B3Ev4tK13v74fF7LSML0GRRKXbXJApDPVTKIzn\n\t/Giy0DehcXM5Aew+d1AcxMKyrSb7Vv5YbCUtvbi4ydk2nGiKukGsDxLAzR5BiXOBJQ3m\n\tbyLGIb0PmYU0GVYUpEoltQhU6S4RY1QTgxJznP072DE/AX+gnvu3WsTZeLg1+xAW+35a\n\t6BEh/45Zm4+mHXY+fYvArplxaB5KmTJuwEau0RwWNnVBIqD9sDfMEpOP46HgtO96lZZ0\n\tCZUqrdYJlZL2nm6eVft1weDSXdMSb/AwdQUXJ88uYmS/sszY0CKJNqsKnlHGA+Xq4fhj\n\tJajQ==", "X-Gm-Message-State": "APjAAAVCDKAdF2EtnL9B6Dg8WMa6Nxnn3MpG+nZ9Mi5/YE3667870VOQ\n\tmCbCcicjmu+EBxR08NYzD1zSFVO14d3Is73itjDgOw==", "X-Google-Smtp-Source": "APXvYqx/993F8xC9++of7tqFJYP79WiYLXLRhdzKPUKGWg0uNMYNACFtow0VS3ECQwwvcv0qxPfPPLJiDhr9ZZ2xHlI=", "X-Received": "by 2002:ab0:748e:: with SMTP id n14mr5428329uap.53.1556893891859;\n\tFri, 03 May 2019 07:31:31 -0700 (PDT)", "MIME-Version": "1.0", "References": "<20181122033055.3431-1-honnappa.nagarahalli@arm.com>\n\t<20190501035419.33524-1-honnappa.nagarahalli@arm.com>\n\t<20190501035419.33524-3-honnappa.nagarahalli@arm.com>", "In-Reply-To": "<20190501035419.33524-3-honnappa.nagarahalli@arm.com>", "From": "David Marchand <david.marchand@redhat.com>", "Date": "Fri, 3 May 2019 16:31:19 +0200", "Message-ID": "<CAJFAV8x9MQn8r3-Xdbs9s+U5Gfrg5OyKyUCxqyy4G5s5M_WBpQ@mail.gmail.com>", "To": "Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>", "Cc": "\"Ananyev, Konstantin\" <konstantin.ananyev@intel.com>, \n\tStephen Hemminger <stephen@networkplumber.org>, paulmck@linux.ibm.com,\n\t\"Kovacevic, Marko\" <marko.kovacevic@intel.com>, dev <dev@dpdk.org>,\n\tGavin Hu <gavin.hu@arm.com>, Dharmik Thakkar <dharmik.thakkar@arm.com>,\n\tMalvika Gupta <malvika.gupta@arm.com>, Aaron Conole <aconole@redhat.com>", "Content-Type": "text/plain; charset=\"UTF-8\"", "X-Content-Filtered-By": "Mailman/MimeDel 2.1.15", "Subject": "Re: [dpdk-dev] [PATCH v9 2/4] test/rcu_qsbr: add API and functional\n\ttests", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null }, { "id": 95904, "web_url": "http://patches.dpdk.org/comment/95904/", "msgid": "<VE1PR08MB51490D4157411CA00D7D0F4398300@VE1PR08MB5149.eurprd08.prod.outlook.com>", "list_archive_url": "https://inbox.dpdk.org/dev/VE1PR08MB51490D4157411CA00D7D0F4398300@VE1PR08MB5149.eurprd08.prod.outlook.com", "date": "2019-05-06T23:16:07", "subject": "Re: [dpdk-dev] [PATCH v9 2/4] test/rcu_qsbr: add API and functional\n\ttests", "submitter": { "id": 1045, "url": "http://patches.dpdk.org/api/people/1045/?format=api", "name": "Honnappa Nagarahalli", "email": "honnappa.nagarahalli@arm.com" }, "content": "Summary of discussions with David.\nI am not able to reproduce the 'Test Fail' issue. However, log indicates an issue in the test code. David has validated the patch and I will send it out soon.\n\nThe test case taking long time to complete happens when the code is compiled with '-O0 -g', but the test case itself completes. The test cases are currently tuned to take less time when compiled with '-O3'.\n\nThanks,\nHonnappa\n\nFrom: David Marchand <david.marchand@redhat.com> \nSent: Friday, May 3, 2019 9:31 AM\nTo: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>\nCc: Ananyev, Konstantin <konstantin.ananyev@intel.com>; Stephen Hemminger <stephen@networkplumber.org>; paulmck@linux.ibm.com; Kovacevic, Marko <marko.kovacevic@intel.com>; dev <dev@dpdk.org>; Gavin Hu (Arm Technology China) <Gavin.Hu@arm.com>; Dharmik Thakkar <Dharmik.Thakkar@arm.com>; Malvika Gupta <Malvika.Gupta@arm.com>; Aaron Conole <aconole@redhat.com>\nSubject: Re: [dpdk-dev] [PATCH v9 2/4] test/rcu_qsbr: add API and functional tests\n\nOn Wed, May 1, 2019 at 5:55 AM Honnappa Nagarahalli <mailto:honnappa.nagarahalli@arm.com> wrote:\nFrom: Dharmik Thakkar <mailto:dharmik.thakkar@arm.com>\n\nAdd API positive/negative test cases, functional tests and\nperformance tests.\n\nSigned-off-by: Malvika Gupta <mailto:malvika.gupta@arm.com>\nSigned-off-by: Dharmik Thakkar <mailto:dharmik.thakkar@arm.com>\nSigned-off-by: Honnappa Nagarahalli <mailto:honnappa.nagarahalli@arm.com>\nReviewed-by: Gavin Hu <mailto:gavin.hu@arm.com>\nAcked-by: Konstantin Ananyev <mailto:konstantin.ananyev@intel.com>\n\nDid not investigate, but this test always fails on my laptop.\nTried multiple times, I caught one instance when the test was still burning cpu after 5 minutes and I killed it.\n\nUsually, it fails like this:\n\n[dmarchan@dmarchan dpdk]$ ./master/app/test -c 0x1f -n 4 --no-huge\nEAL: Detected 8 lcore(s)\nEAL: Detected 1 NUMA nodes\nEAL: Multi-process socket /run/user/114840/dpdk/rte/mp_socket\nEAL: Probing VFIO support...\nEAL: Started without hugepages support, physical addresses not available\nEAL: PCI device 0000:00:1f.6 on NUMA socket -1\nEAL: Invalid NUMA socket, default to 0\nEAL: probe driver: 8086:15d7 net_e1000_em\nAPP: HPET is not enabled, using TSC as default timer\nRTE>>rcu_qsbr_perf_autotest \nNumber of cores provided = 4\nPerf test with all reader threads registered\n--------------------------------------------\n\nPerf Test: 3 Readers/1 Writer('wait' in qsbr_check == true)\nTotal RCU updates = 945401635\nCycles per 1000 updates: 25157\nTotal RCU checks = 20000000\nCycles per 1000 checks: 396375\n\nPerf Test: 4 Readers\nTotal RCU updates = 400000000\nCycles per 1000 updates: 6241\n\nPerf test: 4 Writers ('wait' in qsbr_check == false)\nTotal RCU checks = 80000000\nCycles per 1000 checks: 21061\n\nPerf test: 1 writer, 4 readers, 1 QSBR variable, 1 QSBR Query, Blocking QSBR Check\nReader did not complete #28 = 4097\nTest Failed\nRTE>>", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5657A397D;\n\tTue, 7 May 2019 01:16:11 +0200 (CEST)", "from EUR03-AM5-obe.outbound.protection.outlook.com\n\t(mail-eopbgr30050.outbound.protection.outlook.com [40.107.3.50])\n\tby dpdk.org (Postfix) with ESMTP id 94F0437AF\n\tfor <dev@dpdk.org>; Tue, 7 May 2019 01:16:09 +0200 (CEST)", "from VE1PR08MB5149.eurprd08.prod.outlook.com (20.179.30.152) by\n\tVE1PR08MB5133.eurprd08.prod.outlook.com (20.179.30.92) with Microsoft\n\tSMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1856.12; Mon, 6 May 2019 23:16:07 +0000", "from VE1PR08MB5149.eurprd08.prod.outlook.com\n\t([fe80::f5e3:39bc:e7d9:dfea]) by\n\tVE1PR08MB5149.eurprd08.prod.outlook.com\n\t([fe80::f5e3:39bc:e7d9:dfea%5]) with mapi id 15.20.1856.012;\n\tMon, 6 May 2019 23:16:07 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;\n\ts=selector1-arm-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=GfTMz7s/5dgLjIfDi0FJPOTHI5xJfhhh5MmQpzr1Fk8=;\n\tb=VXJfffqOOMA9cuHa6+Z95GGE28WtHVUG2rB1ZQWv7SdM/owIq0OSk2Xo/v0ijxs7oTOOKYcnZOkx5mbu/TAZ/FeMi2KnNn3B0zYhEu3DUDuGqkbyNUKzn6in18+pmX/H0NBdcJ0u7dWNxwhTOWsqX3KKU0TxZThxOE5NdBHdYr8=", "From": "Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>", "To": "David Marchand <david.marchand@redhat.com>", "CC": "\"Ananyev, Konstantin\" <konstantin.ananyev@intel.com>, Stephen Hemminger\n\t<stephen@networkplumber.org>, \"paulmck@linux.ibm.com\"\n\t<paulmck@linux.ibm.com>, \"Kovacevic,\n\tMarko\" <marko.kovacevic@intel.com>, dev\n\t<dev@dpdk.org>, \"Gavin Hu (Arm Technology China)\" <Gavin.Hu@arm.com>,\n\tDharmik Thakkar <Dharmik.Thakkar@arm.com>,\n\tMalvika Gupta <Malvika.Gupta@arm.com>, \n\tAaron Conole <aconole@redhat.com>, nd <nd@arm.com>", "Thread-Topic": "[dpdk-dev] [PATCH v9 2/4] test/rcu_qsbr: add API and functional\n\ttests", "Thread-Index": "AQHVAbzqWCUVFMSb8kaL5q8RP7RUKqZevh0g", "Date": "Mon, 6 May 2019 23:16:07 +0000", "Message-ID": "<VE1PR08MB51490D4157411CA00D7D0F4398300@VE1PR08MB5149.eurprd08.prod.outlook.com>", "References": "<20181122033055.3431-1-honnappa.nagarahalli@arm.com>\n\t<20190501035419.33524-1-honnappa.nagarahalli@arm.com>\n\t<20190501035419.33524-3-honnappa.nagarahalli@arm.com>\n\t<CAJFAV8x9MQn8r3-Xdbs9s+U5Gfrg5OyKyUCxqyy4G5s5M_WBpQ@mail.gmail.com>", "In-Reply-To": "<CAJFAV8x9MQn8r3-Xdbs9s+U5Gfrg5OyKyUCxqyy4G5s5M_WBpQ@mail.gmail.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=Honnappa.Nagarahalli@arm.com; ", "x-originating-ip": "[217.140.96.140]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "c1976a7e-e534-4e39-dfc6-08d6d278d1cb", "x-ms-office365-filtering-ht": "Tenant", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(4618075)(2017052603328)(7193020);\n\tSRVR:VE1PR08MB5133; ", "x-ms-traffictypediagnostic": "VE1PR08MB5133:", "nodisclaimer": "True", "x-microsoft-antispam-prvs": "<VE1PR08MB5133E60D093C9938976B7B9098300@VE1PR08MB5133.eurprd08.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:196;", "x-forefront-prvs": "0029F17A3F", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(136003)(366004)(346002)(39860400002)(376002)(396003)(189003)(199004)(54906003)(7736002)(305945005)(25786009)(99286004)(316002)(476003)(186003)(26005)(5660300002)(86362001)(53936002)(486006)(68736007)(6506007)(53546011)(74316002)(102836004)(446003)(71190400001)(71200400001)(14444005)(256004)(11346002)(72206003)(66446008)(478600001)(14454004)(2906002)(8936002)(81156014)(9686003)(76176011)(66476007)(66946007)(7696005)(81166006)(76116006)(3846002)(64756008)(66556008)(73956011)(6116002)(8676002)(33656002)(4326008)(66066001)(6246003)(229853002)(55016002)(52536014)(6916009)(6436002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR08MB5133;\n\tH:VE1PR08MB5149.eurprd08.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; MX:1; A:1; ", "received-spf": "None (protection.outlook.com: arm.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "cYbUQN03WIoVWmavWOnmY6rnIOlQRzxQQ4ntWhIKcVUtBpKB/FLU2ysNpOGrvto1eTpuxGZTZwZlk2twdeO8i/lJbO4+kAZcmqkQ5eZDqGMIo5mr42b6Ekf/xg8h9SumQTdNnrx/byaBr2RhySqh3+7wMTKsbG7xljwSXI/25vUxr8E0X1x+PN2gGMhAHyv7Vhl02VtlUq4eYhK3eeCSXsIr91AFtgGJpCg+kd1mewGzJwxX9TjPdPgll2U2rxmmQFKh82z83htks22XKkCASxHKlicUijhUDTh/ECtQ+U7MJmpucWRH9aNjHwwEmCu8hFYCJi1MgQ1UQ7SYoCD04/O2VJiLzEwVyLwXO/OWi97ccS+goMqcTw7ccDKFGGC/ZXApB1qj+4gWjXP86SznshBG42nXTwJgajUAeGeoZSI=", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "MIME-Version": "1.0", "X-OriginatorOrg": "arm.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "c1976a7e-e534-4e39-dfc6-08d6d278d1cb", "X-MS-Exchange-CrossTenant-originalarrivaltime": "06 May 2019 23:16:07.5160\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "f34e5979-57d9-4aaa-ad4d-b122a662184d", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VE1PR08MB5133", "Subject": "Re: [dpdk-dev] [PATCH v9 2/4] test/rcu_qsbr: add API and functional\n\ttests", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "addressed": null } ]