Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53156/?format=api
{ "id": 53156, "url": "http://patches.dpdk.org/api/patches/53156/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190429203325.10696-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190429203325.10696-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190429203325.10696-2-stephen@networkplumber.org", "date": "2019-04-29T20:33:24", "name": "[1/2] net/netvsc: reset mbuf port on VF receive", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a80a004e235fe9c5e60503bca0dcd5510d25f3b5", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190429203325.10696-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 4509, "url": "http://patches.dpdk.org/api/series/4509/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4509", "date": "2019-04-29T20:33:23", "name": "netvsc pmd fixes for 19.05", "version": 1, "mbox": "http://patches.dpdk.org/series/4509/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53156/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/53156/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 81E071B0FF;\n\tMon, 29 Apr 2019 22:33:35 +0200 (CEST)", "from mail-pg1-f194.google.com (mail-pg1-f194.google.com\n\t[209.85.215.194]) by dpdk.org (Postfix) with ESMTP id E69321B0FC\n\tfor <dev@dpdk.org>; Mon, 29 Apr 2019 22:33:30 +0200 (CEST)", "by mail-pg1-f194.google.com with SMTP id k19so5727218pgh.0\n\tfor <dev@dpdk.org>; Mon, 29 Apr 2019 13:33:30 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\ti4sm3557424pfa.44.2019.04.29.13.33.28\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 29 Apr 2019 13:33:28 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=i7DW84J98xtYsHSCazKAw1dQxO0fxpn1GAfMrRLtML4=;\n\tb=MMAZr4oOnQgudSdBJGfJ9s7z3n/fF9eX7qDAdVYs/PCyJYknaYVxR3hrE2l6cYMss0\n\tRn0V1GjaFsABnyRosDYB4pVCNHaRFOJ7vzmTU769T+V9c8wXcuNsWDxOF2JCG0924MTa\n\trUWm058Gc6WTg3ApHJyrgg4bm80P2A8KO8oWLNxfEu/rmSGTs2eJmnrkX8CM8lLtOefJ\n\txVykXm3cc+LLJNieGWnPBbgeNHstDvXbNTeKE3iYzgXZOd/qe2iSgvPIo80YtRz3NziE\n\tucAWW6xAJTl2IfNu5/YoR5ucHW5X+EdqQHLERiE3nnhLeom5//hw209nXdMQqGxT2DAF\n\tbSqA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=i7DW84J98xtYsHSCazKAw1dQxO0fxpn1GAfMrRLtML4=;\n\tb=D9/ToB4le0H5aBlPtJ7Z2ZkQlzzI9TWfdZYxpG3cu4c1gQuZpfXuQNUEQGBAMDDm2M\n\t4X09W62KVDVv0Drv7FYx3T4wH8hbd4vdYV61pFF7oRRe13sx9yXugY5fNGMynfK7laDO\n\tdNUBKDo64ujKvm6651hM+11T+RZkDaJraXRBkfW8qMhgKfeITIP2p0NhbDkbEV1kG3c4\n\tDYLPFCFjKjpKTBONciomi6BUTLmEDNru+42934xhJwMFDwbB4KS5fH92QvZvJGVhBEOP\n\toPZdEEX0KwvXMcV1pqIoSx2JuGTLB4vcmBnK37fkKqK+fHPcYW9N2WmB4FLSkS0+G+jT\n\tvF1g==", "X-Gm-Message-State": "APjAAAWvZn8629dkUMjrZTVe8MdTnt+RLNVK3w+gpkNQ9zcgnf//Rn6T\n\tVHQ70gVaO/AzsaREOPobx+9pk34xf38=", "X-Google-Smtp-Source": "APXvYqzsg5CcUyxH93GSan0cDrX/mujsOXe2qpS4IHP/NDmJjgYxpAzH3k0YLTcFIrZrYfaBKrjJyw==", "X-Received": "by 2002:a62:594b:: with SMTP id\n\tn72mr10706084pfb.186.1556570009856; \n\tMon, 29 Apr 2019 13:33:29 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n\tStephen Hemminger <sthemmin@microsoft.com>", "Date": "Mon, 29 Apr 2019 13:33:24 -0700", "Message-Id": "<20190429203325.10696-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190429203325.10696-1-stephen@networkplumber.org>", "References": "<20190429203325.10696-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/2] net/netvsc: reset mbuf port on VF receive", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Redo the receive logic to set m->port on packets received on VF.\n\nWhen using VF, still need to check for packets and completions\narriving on the VMBus path even if application is not doing bursting\n(ie n_rx == 0).\n\nAlso, fix comment.\n\nSigned-off-by: Stephen Hemminger <sthemmin@microsoft.com>\n---\n drivers/net/netvsc/hn_rxtx.c | 47 +++++++++++++++++++++---------------\n 1 file changed, 28 insertions(+), 19 deletions(-)", "diff": "diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c\nindex c67e9ae25376..7856f7e6ec48 100644\n--- a/drivers/net/netvsc/hn_rxtx.c\n+++ b/drivers/net/netvsc/hn_rxtx.c\n@@ -1393,6 +1393,24 @@ hn_xmit_pkts(void *ptxq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n \treturn nb_tx;\n }\n \n+static uint16_t\n+hn_recv_vf(uint16_t vf_port, const struct hn_rx_queue *rxq,\n+\t struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n+{\n+\tuint16_t i, n;\n+\n+\tif (unlikely(nb_pkts == 0))\n+\t\treturn 0;\n+\n+\tn = rte_eth_rx_burst(vf_port, rxq->queue_id, rx_pkts, nb_pkts);\n+\n+\t/* relabel the received mbufs */\n+\tfor (i = 0; i < n; i++)\n+\t\trx_pkts[i]->port = rxq->port_id;\n+\n+\treturn n;\n+}\n+\n uint16_t\n hn_recv_pkts(void *prxq, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n {\n@@ -1404,30 +1422,21 @@ hn_recv_pkts(void *prxq, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n \tif (unlikely(hv->closed))\n \t\treturn 0;\n \n-\t/* Transmit over VF if present and up */\n+\t/* Receive from VF if present and up */\n \tvf_dev = hn_get_vf_dev(hv);\n \n-\tif (vf_dev && vf_dev->data->dev_started) {\n-\t\t/* Normally, with SR-IOV the ring buffer will be empty */\n+\t/* Check for new completions */\n+\tif (likely(rte_ring_count(rxq->rx_ring) < nb_pkts))\n \t\thn_process_events(hv, rxq->queue_id, 0);\n \n-\t\t/* Get mbufs some bufs off of staging ring */\n-\t\tnb_rcv = rte_ring_sc_dequeue_burst(rxq->rx_ring,\n-\t\t\t\t\t\t (void **)rx_pkts,\n-\t\t\t\t\t\t nb_pkts / 2, NULL);\n-\t\t/* And rest off of VF */\n-\t\tnb_rcv += rte_eth_rx_burst(vf_dev->data->port_id,\n-\t\t\t\t\t rxq->queue_id,\n-\t\t\t\t\t rx_pkts + nb_rcv, nb_pkts - nb_rcv);\n-\t} else {\n-\t\t/* If receive ring is not full then get more */\n-\t\tif (rte_ring_count(rxq->rx_ring) < nb_pkts)\n-\t\t\thn_process_events(hv, rxq->queue_id, 0);\n+\t/* Always check the vmbus path for multicast and new flows */\n+\tnb_rcv = rte_ring_sc_dequeue_burst(rxq->rx_ring,\n+\t\t\t\t\t (void **)rx_pkts, nb_pkts, NULL);\n \n-\t\tnb_rcv = rte_ring_sc_dequeue_burst(rxq->rx_ring,\n-\t\t\t\t\t\t (void **)rx_pkts,\n-\t\t\t\t\t\t nb_pkts, NULL);\n-\t}\n+\t/* If VF is available, check that as well */\n+\tif (vf_dev && vf_dev->data->dev_started)\n+\t\tnb_rcv += hn_recv_vf(vf_dev->data->port_id, rxq,\n+\t\t\t\t rx_pkts + nb_rcv, nb_pkts - nb_rcv);\n \n \treturn nb_rcv;\n }\n", "prefixes": [ "1/2" ] }