Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53139/?format=api
{ "id": 53139, "url": "http://patches.dpdk.org/api/patches/53139/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/a6bd60972f02da33a3e2fa13b5f1be07b5a8e64c.1556525874.git.igor.russkikh@aquantia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<a6bd60972f02da33a3e2fa13b5f1be07b5a8e64c.1556525874.git.igor.russkikh@aquantia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/a6bd60972f02da33a3e2fa13b5f1be07b5a8e64c.1556525874.git.igor.russkikh@aquantia.com", "date": "2019-04-29T08:20:25", "name": "[09/11] net/atlantic: use capability bits to detect eeprom access", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "452c08015318593eb46a2b10c7bbad800e26a49e", "submitter": { "id": 1124, "url": "http://patches.dpdk.org/api/people/1124/?format=api", "name": "Igor Russkikh", "email": "igor.russkikh@aquantia.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/a6bd60972f02da33a3e2fa13b5f1be07b5a8e64c.1556525874.git.igor.russkikh@aquantia.com/mbox/", "series": [ { "id": 4499, "url": "http://patches.dpdk.org/api/series/4499/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4499", "date": "2019-04-29T08:20:07", "name": "Aquantia atlantic bugfixes", "version": 1, "mbox": "http://patches.dpdk.org/series/4499/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53139/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/53139/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 126B01B207;\n\tMon, 29 Apr 2019 10:20:46 +0200 (CEST)", "from NAM04-BN3-obe.outbound.protection.outlook.com\n\t(mail-eopbgr680080.outbound.protection.outlook.com [40.107.68.80])\n\tby dpdk.org (Postfix) with ESMTP id 6A7D51B20B\n\tfor <dev@dpdk.org>; Mon, 29 Apr 2019 10:20:26 +0200 (CEST)", "from DM6PR11MB3625.namprd11.prod.outlook.com (20.178.230.149) by\n\tDM6PR11MB2841.namprd11.prod.outlook.com (20.176.100.32) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1835.13; Mon, 29 Apr 2019 08:20:25 +0000", "from DM6PR11MB3625.namprd11.prod.outlook.com\n\t([fe80::f035:2c20:5a61:7653]) by\n\tDM6PR11MB3625.namprd11.prod.outlook.com\n\t([fe80::f035:2c20:5a61:7653%3]) with mapi id 15.20.1835.010;\n\tMon, 29 Apr 2019 08:20:25 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=0F6Rj++DpZPUEaUHsEgSWVYXXHEhY7B5H7eCBCmJbs8=;\n\tb=NlnmeGgIz4/UDK0XsfYM/HvSXonW1yH/QlJtMfpm/G//nhEAnowvHdgtnOTARUMYLXwj1EXcZQXVlyMH40vfr05DpxgTmNkWWfudAxya7hVw6fQePf5a9kyuWQMSGdbAIq1+Q3XB0zMxxkCvk92fVmfHPFnHnBPbCbwSIaRuapM=", "From": "Igor Russkikh <Igor.Russkikh@aquantia.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>", "CC": "Pavel Belous <Pavel.Belous@aquantia.com>, Igor Russkikh\n\t<Igor.Russkikh@aquantia.com>", "Thread-Topic": "[PATCH 09/11] net/atlantic: use capability bits to detect\n\teeprom access", "Thread-Index": "AQHU/mRlHJLcENXmz0icFXx4hsLPhA==", "Date": "Mon, 29 Apr 2019 08:20:25 +0000", "Message-ID": "<a6bd60972f02da33a3e2fa13b5f1be07b5a8e64c.1556525874.git.igor.russkikh@aquantia.com>", "References": "<cover.1556525874.git.igor.russkikh@aquantia.com>", "In-Reply-To": "<cover.1556525874.git.igor.russkikh@aquantia.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "HE1P190CA0016.EURP190.PROD.OUTLOOK.COM\n\t(2603:10a6:3:bc::26)\n\tTo DM6PR11MB3625.namprd11.prod.outlook.com\n\t(2603:10b6:5:13a::21)", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=Igor.Russkikh@aquantia.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-mailer": "git-send-email 2.17.1", "x-originating-ip": "[95.79.108.179]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "cfdc6c99-f861-4a35-f273-08d6cc7b87ad", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600141)(711020)(4605104)(2017052603328)(7193020);\n\tSRVR:DM6PR11MB2841; ", "x-ms-traffictypediagnostic": "DM6PR11MB2841:", "x-microsoft-antispam-prvs": "<DM6PR11MB2841C9712336431BF345425298390@DM6PR11MB2841.namprd11.prod.outlook.com>", "x-ms-oob-tlc-oobclassifiers": "OLM:299;", "x-forefront-prvs": "0022134A87", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(366004)(376002)(396003)(136003)(39840400004)(346002)(199004)(189003)(44832011)(99286004)(186003)(118296001)(478600001)(71200400001)(53936002)(6506007)(71190400001)(446003)(5660300002)(2351001)(14454004)(14444005)(486006)(66556008)(73956011)(66946007)(64756008)(66476007)(66446008)(386003)(52116002)(316002)(11346002)(2616005)(7736002)(476003)(72206003)(54906003)(305945005)(107886003)(81166006)(1730700003)(2501003)(36756003)(76176011)(81156014)(6486002)(3846002)(66066001)(102836004)(6916009)(97736004)(8936002)(86362001)(6116002)(6436002)(26005)(256004)(8676002)(50226002)(2906002)(25786009)(5640700003)(6512007)(68736007)(4326008);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR11MB2841;\n\tH:DM6PR11MB3625.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: aquantia.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "eP5Ytw9029OnY3dBtHSj2lHtA9NVrTzUvtRYBRTINtNWI8xtKW9xGVeubBonWdOeoyRsR5JYOF00jNENeHd1aRcG9EDbgYsUeP7Do6xnlQDpOX9+49dEL/eLN+rEzKNdniy4u9PPRGxJaBjKELnW1bm/jEMsE1UBsQl9oubvOAKXrj4nk/0ykUzb3dW3Jz4uiCUTZdDwRXfEd5cdQtmsR/UqOuGgxdJNivFdd2ZfvuT+0qFvrzZ9zF197KqtN1Epl9vLqnF3x+VMNfmSPGXeNUtR0vTv206hVzKjUmdz4aHwUObpjbloo3HvQZHHMX6T/Xp9ae1wmgRO3YNO8flccQecyQPF5Yu7fVQtWoqAxzJ3sHTMwr/HRSitmL82XMrY2NYWNwD+wawp85gziS6hPEObdarnBPcA+ywGx5PRROA=", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "MIME-Version": "1.0", "X-OriginatorOrg": "aquantia.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "cfdc6c99-f861-4a35-f273-08d6cc7b87ad", "X-MS-Exchange-CrossTenant-originalarrivaltime": "29 Apr 2019 08:20:25.2834\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "83e2e134-991c-4ede-8ced-34d47e38e6b1", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM6PR11MB2841", "Subject": "[dpdk-dev] [PATCH 09/11] net/atlantic: use capability bits to\n\tdetect eeprom access", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Pavel Belous <pavel.belous@aquantia.com>\n\nIts better to use capability bits FW provides to detect whether\nfirmware has APIs for EEPROM access.\n\nBefore that explicit FW version comparison was used and that may\ncause conflicts.\n\nSigned-off-by: Igor Russkikh <igor.russkikh@aquantia.com>\nSigned-off-by: Pavel Belous <pavel.belous@aquantia.com>\n---\n drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c b/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c\r\nindex e07ed5e3a8c9..0d24aa99bda0 100644\r\n--- a/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c\r\n+++ b/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c\r\n@@ -34,7 +34,6 @@\r\n #define HAL_ATLANTIC_WOL_FILTERS_COUNT 8\r\n #define HAL_ATLANTIC_UTILS_FW2X_MSG_WOL 0x0E\r\n \r\n-#define HW_ATL_FW_FEATURE_EEPROM 0x03010025\r\n #define HW_ATL_FW_FEATURE_LED 0x03010026\r\n \r\n struct fw2x_msg_wol_pattern {\r\n@@ -513,7 +512,7 @@ static int aq_fw2x_get_eeprom(struct aq_hw_s *self, int dev_addr,\r\n \tu32 mpi_opts;\r\n \tint err = 0;\r\n \r\n-\tif (self->fw_ver_actual < HW_ATL_FW_FEATURE_EEPROM)\r\n+\tif ((self->caps_lo & BIT(CAPS_LO_SMBUS_READ)) == 0)\r\n \t\treturn -EOPNOTSUPP;\r\n \r\n \trequest.msg_id = 0;\r\n@@ -591,7 +590,7 @@ static int aq_fw2x_set_eeprom(struct aq_hw_s *self, int dev_addr,\r\n \tu32 mpi_opts, result = 0;\r\n \tint err = 0;\r\n \r\n-\tif (self->fw_ver_actual < HW_ATL_FW_FEATURE_EEPROM)\r\n+\tif ((self->caps_lo & BIT(CAPS_LO_SMBUS_WRITE)) == 0)\r\n \t\treturn -EOPNOTSUPP;\r\n \r\n \trequest.msg_id = 0;\r\n", "prefixes": [ "09/11" ] }