Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53114/?format=api
{ "id": 53114, "url": "http://patches.dpdk.org/api/patches/53114/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190426165043.17268-6-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190426165043.17268-6-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190426165043.17268-6-bruce.richardson@intel.com", "date": "2019-04-26T16:50:42", "name": "[v2,5/6] build: add libbsd to pkg-config file if enabled", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "da0533b3ae4c608100883a39df28f4f33352e614", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190426165043.17268-6-bruce.richardson@intel.com/mbox/", "series": [ { "id": 4486, "url": "http://patches.dpdk.org/api/series/4486/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4486", "date": "2019-04-26T16:50:37", "name": "add testing of libdpdk pkg-config file", "version": 2, "mbox": "http://patches.dpdk.org/series/4486/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53114/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/53114/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5CC8A1B7C4;\n\tFri, 26 Apr 2019 18:51:16 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id DA9821B767\n\tfor <dev@dpdk.org>; Fri, 26 Apr 2019 18:51:09 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t26 Apr 2019 09:51:09 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.222.236])\n\tby fmsmga004.fm.intel.com with ESMTP; 26 Apr 2019 09:51:08 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,398,1549958400\"; d=\"scan'208\";a=\"165364536\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, bluca@debian.org,\n\tBruce Richardson <bruce.richardson@intel.com>", "Date": "Fri, 26 Apr 2019 17:50:42 +0100", "Message-Id": "<20190426165043.17268-6-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190426165043.17268-1-bruce.richardson@intel.com>", "References": "<20190423220644.54589-1-bruce.richardson@intel.com>\n\t<20190426165043.17268-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 5/6] build: add libbsd to pkg-config file if\n\tenabled", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If libbsd is enabled in DPDK, the strlcpy and strlcat functions in\nrte_string_fns.h redirect to the varients in libbsd, only using the\nfallbacks if it is not enabled. Therefore, if libbsd is enabled, it needs\nto be called out as a DPDK dependency in the pkgconfig file.\n\nTo ensure that we don't have undefined variables on non-Linux platforms, we\ncan remove the linux condition around the libbsd check - no harm comes in\nlooking for it on other OS, since it's an optional dependency.\n\nTo verify this builds correctly, the cmdline sample app is added to the\nlist of examples compiled by test-meson-builds. Without this change\ncompilation fails if libbsd is present on the system\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Luca Boccassi <bluca@debian.org>\n---\n config/meson.build | 10 ++++------\n devtools/test-meson-builds.sh | 2 +-\n meson.build | 2 ++\n 3 files changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/config/meson.build b/config/meson.build\nindex 3678348de..0d25646f5 100644\n--- a/config/meson.build\n+++ b/config/meson.build\n@@ -132,12 +132,10 @@ if numa_dep.found() and cc.has_header('numaif.h')\n \tdpdk_extra_ldflags += '-lnuma'\n endif\n \n-# check for strlcpy\n-if is_linux\n-\tlibbsd = dependency('libbsd', required: false)\n-\tif libbsd.found()\n-\t\tdpdk_conf.set('RTE_USE_LIBBSD', 1)\n-\tendif\n+# check for libbsd\n+libbsd = dependency('libbsd', required: false)\n+if libbsd.found()\n+\tdpdk_conf.set('RTE_USE_LIBBSD', 1)\n endif\n \n # add -include rte_config to cflags\ndiff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh\nindex 73f993b98..a9fdce81f 100755\n--- a/devtools/test-meson-builds.sh\n+++ b/devtools/test-meson-builds.sh\n@@ -110,7 +110,7 @@ PKG_CONFIG_PATH=$(dirname $pc_file) ; export PKG_CONFIG_PATH\n # rather than hacking our environment, just edit the .pc file prefix value\n sed -i -e \"s|prefix=|prefix=$DESTDIR|\" $pc_file\n \n-for example in helloworld l2fwd l3fwd skeleton timer; do\n+for example in cmdline helloworld l2fwd l3fwd skeleton timer; do\n \techo \"## Building $example\"\n \t$MAKE -C $DESTDIR/usr/local/share/dpdk/examples/$example\n done\ndiff --git a/meson.build b/meson.build\nindex d1e8e5239..46f9c5683 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -70,6 +70,8 @@ pkg.generate(name: meson.project_name(),\n \tlibraries: dpdk_libraries,\n \tlibraries_private: dpdk_drivers + dpdk_static_libraries +\n \t\t\t['-Wl,-Bdynamic'] + dpdk_extra_ldflags,\n+\trequires: libbsd, # apps using rte_string_fns.h may need this if enabled\n+\t # if libbsd is not enabled, then this is blank\n \tdescription: '''The Data Plane Development Kit (DPDK).\n Note that CFLAGS might contain an -march flag higher than typical baseline.\n This is required for a number of static inline functions in the public headers.''',\n", "prefixes": [ "v2", "5/6" ] }