Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53093/?format=api
{ "id": 53093, "url": "http://patches.dpdk.org/api/patches/53093/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190426050912.109813-2-xiaolong.ye@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190426050912.109813-2-xiaolong.ye@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190426050912.109813-2-xiaolong.ye@intel.com", "date": "2019-04-26T05:09:11", "name": "[v1,1/2] net/af_xdp: remove resources when port is closed", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0ba3e07ddf8b6dfe8664ed3b1dfbdfa994488055", "submitter": { "id": 1120, "url": "http://patches.dpdk.org/api/people/1120/?format=api", "name": "Xiaolong Ye", "email": "xiaolong.ye@intel.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190426050912.109813-2-xiaolong.ye@intel.com/mbox/", "series": [ { "id": 4473, "url": "http://patches.dpdk.org/api/series/4473/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4473", "date": "2019-04-26T05:09:10", "name": "support RTE_ETH_DEV_CLOSE_REMOVE flag for AF_XDP", "version": 1, "mbox": "http://patches.dpdk.org/series/4473/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53093/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/53093/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6CBE81B5EF;\n\tFri, 26 Apr 2019 07:15:45 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby dpdk.org (Postfix) with ESMTP id 73F231B5EE\n\tfor <dev@dpdk.org>; Fri, 26 Apr 2019 07:15:40 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Apr 2019 22:15:40 -0700", "from yexl-server.sh.intel.com ([10.67.110.206])\n\tby orsmga005.jf.intel.com with ESMTP; 25 Apr 2019 22:15:39 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,396,1549958400\"; d=\"scan'208\";a=\"319108848\"", "From": "Xiaolong Ye <xiaolong.ye@intel.com>", "To": "dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,\n\tThomas Monjalon <thomas@monjalon.net>", "Cc": "Xiaolong Ye <xiaolong.ye@intel.com>", "Date": "Fri, 26 Apr 2019 13:09:11 +0800", "Message-Id": "<20190426050912.109813-2-xiaolong.ye@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20190426050912.109813-1-xiaolong.ye@intel.com>", "References": "<20190426050912.109813-1-xiaolong.ye@intel.com>", "Subject": "[dpdk-dev] [PATCH v1 1/2] net/af_xdp: remove resources when port is\n\tclosed", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Since 18.11, it is suggested that driver should release all its private\nresources at the dev_close routine. So all resources previously released\nin remove routine are now released at the dev_close routine, and the\ndev_close routine will be called in driver remove routine in order to\nsupport removing a device without closing its ports.\n\nAbove behavior changes are supported by setting RTE_ETH_DEV_CLOSE_REMOVE\nflag during probe stage.\n\nSigned-off-by: Xiaolong Ye <xiaolong.ye@intel.com>\n---\n drivers/net/af_xdp/rte_eth_af_xdp.c | 41 +++++++++++++----------------\n 1 file changed, 19 insertions(+), 22 deletions(-)", "diff": "diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c\nindex acf9ad605..a12551cbf 100644\n--- a/drivers/net/af_xdp/rte_eth_af_xdp.c\n+++ b/drivers/net/af_xdp/rte_eth_af_xdp.c\n@@ -426,6 +426,19 @@ remove_xdp_program(struct pmd_internals *internals)\n \t\t\tXDP_FLAGS_UPDATE_IF_NOEXIST);\n }\n \n+static void\n+xdp_umem_destroy(struct xsk_umem_info *umem)\n+{\n+\trte_memzone_free(umem->mz);\n+\tumem->mz = NULL;\n+\n+\trte_ring_free(umem->buf_ring);\n+\tumem->buf_ring = NULL;\n+\n+\trte_free(umem);\n+\tumem = NULL;\n+}\n+\n static void\n eth_dev_close(struct rte_eth_dev *dev)\n {\n@@ -444,6 +457,9 @@ eth_dev_close(struct rte_eth_dev *dev)\n \t}\n \n \t(void)xsk_umem__delete(internals->umem->umem);\n+\n+\txdp_umem_destroy(internals->umem);\n+\n \tremove_xdp_program(internals);\n }\n \n@@ -459,19 +475,6 @@ eth_link_update(struct rte_eth_dev *dev __rte_unused,\n \treturn 0;\n }\n \n-static void\n-xdp_umem_destroy(struct xsk_umem_info *umem)\n-{\n-\trte_memzone_free(umem->mz);\n-\tumem->mz = NULL;\n-\n-\trte_ring_free(umem->buf_ring);\n-\tumem->buf_ring = NULL;\n-\n-\trte_free(umem);\n-\tumem = NULL;\n-}\n-\n static struct\n xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals)\n {\n@@ -856,6 +859,8 @@ init_internals(struct rte_vdev_device *dev,\n \teth_dev->dev_ops = &ops;\n \teth_dev->rx_pkt_burst = eth_af_xdp_rx;\n \teth_dev->tx_pkt_burst = eth_af_xdp_tx;\n+\t/* Let rte_eth_dev_close() release the port resources. */\n+\teth_dev->data->dev_flags |= RTE_ETH_DEV_CLOSE_REMOVE;\n \n \treturn eth_dev;\n \n@@ -923,7 +928,6 @@ static int\n rte_pmd_af_xdp_remove(struct rte_vdev_device *dev)\n {\n \tstruct rte_eth_dev *eth_dev = NULL;\n-\tstruct pmd_internals *internals;\n \n \tAF_XDP_LOG(INFO, \"Removing AF_XDP ethdev on numa socket %u\\n\",\n \t\trte_socket_id());\n@@ -936,14 +940,7 @@ rte_pmd_af_xdp_remove(struct rte_vdev_device *dev)\n \tif (eth_dev == NULL)\n \t\treturn -1;\n \n-\tinternals = eth_dev->data->dev_private;\n-\n-\trte_ring_free(internals->umem->buf_ring);\n-\trte_memzone_free(internals->umem->mz);\n-\trte_free(internals->umem);\n-\n-\trte_eth_dev_release_port(eth_dev);\n-\n+\teth_dev_close(eth_dev);\n \n \treturn 0;\n }\n", "prefixes": [ "v1", "1/2" ] }