Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53078/?format=api
{ "id": 53078, "url": "http://patches.dpdk.org/api/patches/53078/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/29d36c2e796b75cee5a66f36f7cd48249bb40824.1556195691.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<29d36c2e796b75cee5a66f36f7cd48249bb40824.1556195691.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/29d36c2e796b75cee5a66f36f7cd48249bb40824.1556195691.git.anatoly.burakov@intel.com", "date": "2019-04-25T12:45:19", "name": "[19.08,6/6] ipc: handle unsupported ipc in async request", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6d0b2f75c6fef8ed9ca2d2b932f327c1846e26d2", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Burakov, Anatoly", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/29d36c2e796b75cee5a66f36f7cd48249bb40824.1556195691.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 4465, "url": "http://patches.dpdk.org/api/series/4465/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4465", "date": "2019-04-25T12:45:14", "name": "[19.08,1/6] ipc: handle unsupported ipc in init", "version": 1, "mbox": "http://patches.dpdk.org/series/4465/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53078/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/53078/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 1AFDD1B5B7;\n\tThu, 25 Apr 2019 14:45:37 +0200 (CEST)", "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id 601111B59C\n\tfor <dev@dpdk.org>; Thu, 25 Apr 2019 14:45:28 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Apr 2019 05:45:28 -0700", "from silpixa00399498.ir.intel.com (HELO\n\tsilpixa00399498.ger.corp.intel.com) ([10.237.223.125])\n\tby orsmga002.jf.intel.com with ESMTP; 25 Apr 2019 05:45:27 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,393,1549958400\"; d=\"scan'208\";a=\"153666990\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "herakliusz.lipiec@intel.com", "Date": "Thu, 25 Apr 2019 13:45:19 +0100", "Message-Id": "<29d36c2e796b75cee5a66f36f7cd48249bb40824.1556195691.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": [ "<b0b218f0265ee9814de64f284d0d2d896ab01fa1.1556195690.git.anatoly.burakov@intel.com>", "<b0b218f0265ee9814de64f284d0d2d896ab01fa1.1556195690.git.anatoly.burakov@intel.com>" ], "References": [ "<b0b218f0265ee9814de64f284d0d2d896ab01fa1.1556195690.git.anatoly.burakov@intel.com>", "<b0b218f0265ee9814de64f284d0d2d896ab01fa1.1556195690.git.anatoly.burakov@intel.com>" ], "Subject": "[dpdk-dev] [PATCH 19.08 6/6] ipc: handle unsupported ipc in async\n\trequest", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Currently, IPC API will silently ignore unsupported IPC.\nFix the API call to explicitly handle unsupported IPC cases.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_eal/common/eal_common_proc.c | 3 ++-\n lib/librte_eal/common/include/rte_eal.h | 3 +++\n 2 files changed, 5 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c\nindex c6aa80bfc..3a876e021 100644\n--- a/lib/librte_eal/common/eal_common_proc.c\n+++ b/lib/librte_eal/common/eal_common_proc.c\n@@ -1041,7 +1041,8 @@ rte_mp_request_async(struct rte_mp_msg *req, const struct timespec *ts,\n \n \tif (internal_config.no_shconf) {\n \t\tRTE_LOG(DEBUG, EAL, \"No shared files mode enabled, IPC is disabled\\n\");\n-\t\treturn 0;\n+\t\trte_errno = ENOTSUP;\n+\t\treturn -1;\n \t}\n \n \tif (gettimeofday(&now, NULL) < 0) {\ndiff --git a/lib/librte_eal/common/include/rte_eal.h b/lib/librte_eal/common/include/rte_eal.h\nindex 4460ea14a..9acf85664 100644\n--- a/lib/librte_eal/common/include/rte_eal.h\n+++ b/lib/librte_eal/common/include/rte_eal.h\n@@ -344,6 +344,9 @@ rte_mp_request_sync(struct rte_mp_msg *req, struct rte_mp_reply *reply,\n * This function sends a request message to the peer process, and will not\n * block. Instead, reply will be received in a separate callback.\n *\n+ * @note IPC may be unsupported in certain circumstances, so caller should check\n+ * for ENOTSUP error.\n+ *\n * @param req\n * The req argument contains the customized request message.\n *\n", "prefixes": [ "19.08", "6/6" ] }