Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 53073,
    "url": "http://patches.dpdk.org/api/patches/53073/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/b0b218f0265ee9814de64f284d0d2d896ab01fa1.1556195690.git.anatoly.burakov@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<b0b218f0265ee9814de64f284d0d2d896ab01fa1.1556195690.git.anatoly.burakov@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/b0b218f0265ee9814de64f284d0d2d896ab01fa1.1556195690.git.anatoly.burakov@intel.com",
    "date": "2019-04-25T12:45:14",
    "name": "[19.08,1/6] ipc: handle unsupported ipc in init",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "48a60a2ce5cd9ca2458a5198f313a64898f4b7e4",
    "submitter": {
        "id": 4,
        "url": "http://patches.dpdk.org/api/people/4/?format=api",
        "name": "Anatoly Burakov",
        "email": "anatoly.burakov@intel.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/b0b218f0265ee9814de64f284d0d2d896ab01fa1.1556195690.git.anatoly.burakov@intel.com/mbox/",
    "series": [
        {
            "id": 4465,
            "url": "http://patches.dpdk.org/api/series/4465/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4465",
            "date": "2019-04-25T12:45:14",
            "name": "[19.08,1/6] ipc: handle unsupported ipc in init",
            "version": 1,
            "mbox": "http://patches.dpdk.org/series/4465/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/53073/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/53073/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 41D451B590;\n\tThu, 25 Apr 2019 14:45:24 +0200 (CEST)",
            "from mga06.intel.com (mga06.intel.com [134.134.136.31])\n\tby dpdk.org (Postfix) with ESMTP id 3BBE01B581\n\tfor <dev@dpdk.org>; Thu, 25 Apr 2019 14:45:22 +0200 (CEST)",
            "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Apr 2019 05:45:21 -0700",
            "from silpixa00399498.ir.intel.com (HELO\n\tsilpixa00399498.ger.corp.intel.com) ([10.237.223.125])\n\tby orsmga002.jf.intel.com with ESMTP; 25 Apr 2019 05:45:20 -0700"
        ],
        "X-Amp-Result": "SKIPPED(no attachment in message)",
        "X-Amp-File-Uploaded": "False",
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.60,393,1549958400\"; d=\"scan'208\";a=\"153666955\"",
        "From": "Anatoly Burakov <anatoly.burakov@intel.com>",
        "To": "dev@dpdk.org",
        "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n\therakliusz.lipiec@intel.com",
        "Date": "Thu, 25 Apr 2019 13:45:14 +0100",
        "Message-Id": "<b0b218f0265ee9814de64f284d0d2d896ab01fa1.1556195690.git.anatoly.burakov@intel.com>",
        "X-Mailer": "git-send-email 2.17.1",
        "Subject": "[dpdk-dev] [PATCH 19.08 1/6] ipc: handle unsupported ipc in init",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Currently, IPC API will silently ignore unsupported IPC.\nFix the API call and its callers to explicitly handle\nunsupported IPC cases.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_eal/common/eal_common_proc.c | 3 ++-\n lib/librte_eal/freebsd/eal/eal.c        | 2 +-\n lib/librte_eal/linux/eal/eal.c          | 2 +-\n 3 files changed, 4 insertions(+), 3 deletions(-)",
    "diff": "diff --git a/lib/librte_eal/common/eal_common_proc.c b/lib/librte_eal/common/eal_common_proc.c\nindex b46d644b3..a4581e3b4 100644\n--- a/lib/librte_eal/common/eal_common_proc.c\n+++ b/lib/librte_eal/common/eal_common_proc.c\n@@ -568,7 +568,8 @@ rte_mp_channel_init(void)\n \t */\n \tif (internal_config.no_shconf) {\n \t\tRTE_LOG(DEBUG, EAL, \"No shared files mode enabled, IPC will be disabled\\n\");\n-\t\treturn 0;\n+\t\trte_errno = ENOTSUP;\n+\t\treturn -1;\n \t}\n \n \t/* create filter path */\ndiff --git a/lib/librte_eal/freebsd/eal/eal.c b/lib/librte_eal/freebsd/eal/eal.c\nindex c6ac9028f..4eaa53195 100644\n--- a/lib/librte_eal/freebsd/eal/eal.c\n+++ b/lib/librte_eal/freebsd/eal/eal.c\n@@ -671,7 +671,7 @@ rte_eal_init(int argc, char **argv)\n \t/* Put mp channel init before bus scan so that we can init the vdev\n \t * bus through mp channel in the secondary process before the bus scan.\n \t */\n-\tif (rte_mp_channel_init() < 0) {\n+\tif (rte_mp_channel_init() < 0 && rte_errno != ENOTSUP) {\n \t\trte_eal_init_alert(\"failed to init mp channel\");\n \t\tif (rte_eal_process_type() == RTE_PROC_PRIMARY) {\n \t\t\trte_errno = EFAULT;\ndiff --git a/lib/librte_eal/linux/eal/eal.c b/lib/librte_eal/linux/eal/eal.c\nindex 161399619..3e1d6eb6a 100644\n--- a/lib/librte_eal/linux/eal/eal.c\n+++ b/lib/librte_eal/linux/eal/eal.c\n@@ -1014,7 +1014,7 @@ rte_eal_init(int argc, char **argv)\n \t/* Put mp channel init before bus scan so that we can init the vdev\n \t * bus through mp channel in the secondary process before the bus scan.\n \t */\n-\tif (rte_mp_channel_init() < 0) {\n+\tif (rte_mp_channel_init() < 0 && rte_errno != ENOTSUP) {\n \t\trte_eal_init_alert(\"failed to init mp channel\");\n \t\tif (rte_eal_process_type() == RTE_PROC_PRIMARY) {\n \t\t\trte_errno = EFAULT;\n",
    "prefixes": [
        "19.08",
        "1/6"
    ]
}