Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53071/?format=api
http://patches.dpdk.org/api/patches/53071/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190425114324.611-3-herakliusz.lipiec@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190425114324.611-3-herakliusz.lipiec@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190425114324.611-3-herakliusz.lipiec@intel.com", "date": "2019-04-25T11:43:24", "name": "[v3,2/2] ipc: fix tap pmd memleak", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "dc631eca709bd9c56e8cc59d2b2dcd6cd09f5428", "submitter": { "id": 742, "url": "http://patches.dpdk.org/api/people/742/?format=api", "name": "Herakliusz Lipiec", "email": "herakliusz.lipiec@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190425114324.611-3-herakliusz.lipiec@intel.com/mbox/", "series": [ { "id": 4463, "url": "http://patches.dpdk.org/api/series/4463/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4463", "date": "2019-04-25T11:43:22", "name": "ipc: fix possible memleaks", "version": 3, "mbox": "http://patches.dpdk.org/series/4463/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53071/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/53071/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C83081B590;\n\tThu, 25 Apr 2019 13:42:40 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 4BDBE1B587;\n\tThu, 25 Apr 2019 13:42:33 +0200 (CEST)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t25 Apr 2019 04:42:32 -0700", "from silpixa00399499.ir.intel.com (HELO\n\tsilpixa00399499.ger.corp.intel.com) ([10.237.222.133])\n\tby FMSMGA003.fm.intel.com with ESMTP; 25 Apr 2019 04:42:31 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,393,1549958400\"; d=\"scan'208\";a=\"152266759\"", "From": "Herakliusz Lipiec <herakliusz.lipiec@intel.com>", "To": "Keith Wiles <keith.wiles@intel.com>", "Cc": "dev@dpdk.org, anatoly.burakov@intel.com,\n\tHerakliusz Lipiec <herakliusz.lipiec@intel.com>, rasland@mellanox.com,\n\tstable@dpdk.org", "Date": "Thu, 25 Apr 2019 12:43:24 +0100", "Message-Id": "<20190425114324.611-3-herakliusz.lipiec@intel.com>", "X-Mailer": "git-send-email 2.17.2", "In-Reply-To": "<20190425114324.611-1-herakliusz.lipiec@intel.com>", "References": "<20190423174334.19612-1-herakliusz.lipiec@intel.com>\n\t<20190425114324.611-1-herakliusz.lipiec@intel.com>", "Subject": "[dpdk-dev] [PATCH v3 2/2] ipc: fix tap pmd memleak", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When sending synchronous IPC requests, the caller must free the response\nbuffer if the request was successful and reply is no longer needed.\nFix the code to correctly\nuse the IPC API.\n\nBugzilla ID: 228\nFixes: c9aa56edec8e (\"net/tap: access primary process queues from secondary\")\nCc: rasland@mellanox.com\nCc: stable@dpdk.org\n\nSigned-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>\n---\n drivers/net/tap/rte_eth_tap.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c\nindex 7f74b5dc9..3a74c2a43 100644\n--- a/drivers/net/tap/rte_eth_tap.c\n+++ b/drivers/net/tap/rte_eth_tap.c\n@@ -2118,7 +2118,7 @@ tap_mp_attach_queues(const char *port_name, struct rte_eth_dev *dev)\n \t\tprocess_private->rxq_fds[queue] = reply->fds[fd_iterator++];\n \tfor (queue = 0; queue < reply_param->txq_count; queue++)\n \t\tprocess_private->txq_fds[queue] = reply->fds[fd_iterator++];\n-\n+ free(reply);\n \treturn 0;\n }\n \n", "prefixes": [ "v3", "2/2" ] }{ "id": 53071, "url": "