Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53053/?format=api
http://patches.dpdk.org/api/patches/53053/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/9119aac2903c82257a136b2cea3185a00232a203.1556119511.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<9119aac2903c82257a136b2cea3185a00232a203.1556119511.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/9119aac2903c82257a136b2cea3185a00232a203.1556119511.git.anatoly.burakov@intel.com", "date": "2019-04-24T15:26:10", "name": "[18.11] eal: fix cleanup in no-shconf mode", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "3bb94167f710a4a0f855d1c92b62be469f1cd5da", "submitter": { "id": 4, "url": "http://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/9119aac2903c82257a136b2cea3185a00232a203.1556119511.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 4450, "url": "http://patches.dpdk.org/api/series/4450/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4450", "date": "2019-04-24T15:26:10", "name": "[18.11] eal: fix cleanup in no-shconf mode", "version": 1, "mbox": "http://patches.dpdk.org/series/4450/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53053/comments/", "check": "fail", "checks": "http://patches.dpdk.org/api/patches/53053/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 21F1C1B4FC;\n\tWed, 24 Apr 2019 17:26:14 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 83C0F1B3E8\n\tfor <dev@dpdk.org>; Wed, 24 Apr 2019 17:26:12 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t24 Apr 2019 08:26:11 -0700", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby fmsmga008.fm.intel.com with ESMTP; 24 Apr 2019 08:26:10 -0700", "from sivswdev05.ir.intel.com (sivswdev05.ir.intel.com\n\t[10.243.17.64])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tx3OFQAh6017970 for <dev@dpdk.org>; Wed, 24 Apr 2019 16:26:10 +0100", "from sivswdev05.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev05.ir.intel.com with ESMTP id x3OFQAD0005346\n\tfor <dev@dpdk.org>; Wed, 24 Apr 2019 16:26:10 +0100", "(from aburakov@localhost)\n\tby sivswdev05.ir.intel.com with LOCAL id x3OFQA2N005342\n\tfor dev@dpdk.org; Wed, 24 Apr 2019 16:26:10 +0100" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,390,1549958400\"; d=\"scan'208\";a=\"143250281\"", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Date": "Wed, 24 Apr 2019 16:26:10 +0100", "Message-Id": "<9119aac2903c82257a136b2cea3185a00232a203.1556119511.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 1.7.0.7", "Subject": "[dpdk-dev] [PATCH 18.11] eal: fix cleanup in no-shconf mode", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "In no-shconf mode, there is no need to clean runtime directory\nbecause it's not created in the first place.\n\nFixes: 0a529578f162 (\"eal: clean up unused files on initialization\")\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_eal/linuxapp/eal/eal.c | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_eal/linuxapp/eal/eal.c b/lib/librte_eal/linuxapp/eal/eal.c\nindex 30138b638..59497d04a 100644\n--- a/lib/librte_eal/linuxapp/eal/eal.c\n+++ b/lib/librte_eal/linuxapp/eal/eal.c\n@@ -1214,8 +1214,11 @@ rte_eal_init(int argc, char **argv)\n \t * whether we are primary or secondary process, but we cannot remove\n \t * primary process' files because secondary should be able to run even\n \t * if primary process is dead.\n+\t *\n+\t * In no_shconf mode, no runtime directory is created in the first\n+\t * place, so no cleanup needed.\n \t */\n-\tif (eal_clean_runtime_dir() < 0) {\n+\tif (!internal_config.no_shconf && eal_clean_runtime_dir() < 0) {\n \t\trte_eal_init_alert(\"Cannot clear runtime directory\\n\");\n \t\treturn -1;\n \t}\n", "prefixes": [ "18.11" ] }{ "id": 53053, "url": "