Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53029/?format=api
{ "id": 53029, "url": "http://patches.dpdk.org/api/patches/53029/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190423220644.54589-5-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190423220644.54589-5-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190423220644.54589-5-bruce.richardson@intel.com", "date": "2019-04-23T22:06:44", "name": "[4/4] build: add libbsd to pkg-config file if enabled", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f6795636187fc5f037f32d0305b3542c1c64513a", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190423220644.54589-5-bruce.richardson@intel.com/mbox/", "series": [ { "id": 4434, "url": "http://patches.dpdk.org/api/series/4434/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4434", "date": "2019-04-23T22:06:40", "name": "add testing of libdpdk pkg-config file", "version": 1, "mbox": "http://patches.dpdk.org/series/4434/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53029/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/53029/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 896F41B4F8;\n\tWed, 24 Apr 2019 00:07:04 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id CA9DB1B4DC\n\tfor <dev@dpdk.org>; Wed, 24 Apr 2019 00:07:00 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t23 Apr 2019 15:06:58 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.222.236])\n\tby orsmga007.jf.intel.com with ESMTP; 23 Apr 2019 15:06:59 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,387,1549958400\"; d=\"scan'208\";a=\"133795863\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>", "Date": "Tue, 23 Apr 2019 23:06:44 +0100", "Message-Id": "<20190423220644.54589-5-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190423220644.54589-1-bruce.richardson@intel.com>", "References": "<20190423220644.54589-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 4/4] build: add libbsd to pkg-config file if\n\tenabled", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If libbsd is enabled in DPDK, the strlcpy and strlcat functions in\nrte_string_fns.h redirect to the varients in libbsd, only using the\nfallbacks if it is not enabled. Therefore, if libbsd is enabled, it needs\nto be called out as a DPDK dependency in the pkgconfig file.\n\nTo ensure that we don't have undefined variables on non-Linux platforms, we\ncan remove the linux condition around the libbsd check - no harm comes in\nlooking for it on other OS, since it's an optional dependency.\n\nTo verify this builds correctly, the cmdline sample app is added to the\nlist of examples compiled by test-meson-builds. Without this change\ncompilation fails if libbsd is present on the system\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n config/meson.build | 10 ++++------\n devtools/test-meson-builds.sh | 2 +-\n meson.build | 2 ++\n 3 files changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/config/meson.build b/config/meson.build\nindex f8aded6ed..64e2315dd 100644\n--- a/config/meson.build\n+++ b/config/meson.build\n@@ -125,12 +125,10 @@ if numa_dep.found() and cc.has_header('numaif.h')\n \tdpdk_extra_ldflags += '-lnuma'\n endif\n \n-# check for strlcpy\n-if is_linux\n-\tlibbsd = dependency('libbsd', required: false)\n-\tif libbsd.found()\n-\t\tdpdk_conf.set('RTE_USE_LIBBSD', 1)\n-\tendif\n+# check for libbsd\n+libbsd = dependency('libbsd', required: false)\n+if libbsd.found()\n+\tdpdk_conf.set('RTE_USE_LIBBSD', 1)\n endif\n \n # add -include rte_config to cflags\ndiff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh\nindex dfba2a782..41080353b 100755\n--- a/devtools/test-meson-builds.sh\n+++ b/devtools/test-meson-builds.sh\n@@ -103,7 +103,7 @@ $ninja_cmd -C $build_path install\n # rather than hacking our environment, just edit the .pc file prefix value\n sed -i \"s|prefix=|prefix=$DESTDIR|\" $PKG_CONFIG_PATH/libdpdk.pc\n \n-for example in helloworld l2fwd l3fwd skeleton timer; do\n+for example in cmdline helloworld l2fwd l3fwd skeleton timer; do\n \techo \"## Building $example\"\n \tmake -C $DESTDIR/usr/local/share/dpdk/examples/$example\n done\ndiff --git a/meson.build b/meson.build\nindex a96486597..3c173a587 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -77,6 +77,8 @@ pkg.generate(name: meson.project_name(),\n \tlibraries: dpdk_libraries,\n \tlibraries_private: dpdk_drivers + dpdk_static_libraries +\n \t\t\t['-Wl,-Bdynamic'] + dpdk_extra_ldflags,\n+\trequires: libbsd, # apps using rte_string_fns.h may need this if enabled\n+\t # if libbsd is not enabled, then this is blank\n \tdescription: '''The Data Plane Development Kit (DPDK).\n Note that CFLAGS might contain an -march flag higher than typical baseline.\n This is required for a number of static inline functions in the public headers.''',\n", "prefixes": [ "4/4" ] }