Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53022/?format=api
{ "id": 53022, "url": "http://patches.dpdk.org/api/patches/53022/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190423174334.19612-8-herakliusz.lipiec@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190423174334.19612-8-herakliusz.lipiec@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190423174334.19612-8-herakliusz.lipiec@intel.com", "date": "2019-04-23T17:43:33", "name": "[v2,7/8] ipc: fix net/mlx4 memleak", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "a1347f55dbcae1954f7ad5e6f302f9fb8e7c9529", "submitter": { "id": 742, "url": "http://patches.dpdk.org/api/people/742/?format=api", "name": "Herakliusz Lipiec", "email": "herakliusz.lipiec@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190423174334.19612-8-herakliusz.lipiec@intel.com/mbox/", "series": [ { "id": 4432, "url": "http://patches.dpdk.org/api/series/4432/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4432", "date": "2019-04-23T17:43:26", "name": "ipc: fix possible memleaks", "version": 2, "mbox": "http://patches.dpdk.org/series/4432/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53022/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/53022/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C2C891B509;\n\tTue, 23 Apr 2019 19:43:45 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 371D71B4E8\n\tfor <dev@dpdk.org>; Tue, 23 Apr 2019 19:43:37 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t23 Apr 2019 10:43:36 -0700", "from silpixa00399499.ir.intel.com (HELO\n\tsilpixa00399499.ger.corp.intel.com) ([10.237.222.133])\n\tby orsmga001.jf.intel.com with ESMTP; 23 Apr 2019 10:43:35 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,386,1549958400\"; d=\"scan'208\";a=\"226004793\"", "From": "Herakliusz Lipiec <herakliusz.lipiec@intel.com>", "To": "Matan Azrad <matan@mellanox.com>,\n\tShahaf Shuler <shahafs@mellanox.com>", "Cc": "dev@dpdk.org, Herakliusz Lipiec <herakliusz.lipiec@intel.com>,\n\tyskoh@mellanox.com", "Date": "Tue, 23 Apr 2019 18:43:33 +0100", "Message-Id": "<20190423174334.19612-8-herakliusz.lipiec@intel.com>", "X-Mailer": "git-send-email 2.17.2", "In-Reply-To": "<20190423174334.19612-1-herakliusz.lipiec@intel.com>", "References": "<20190417143822.21276-1-herakliusz.lipiec@intel.com>\n\t<20190423174334.19612-1-herakliusz.lipiec@intel.com>", "Subject": "[dpdk-dev] [PATCH v2 7/8] ipc: fix net/mlx4 memleak", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When sending synchronous IPC requests, the caller must free the response \nbuffer even if the request returned failure. Fix the code to correctly \nuse the IPC API.\n\nBugzilla ID:228\nFixes: 0b259b8e9655 (\"net/mlx4: enable secondary process to register DMA memory\")\nCc: yskoh@mellanox.com\nSigned-off-by: Herakliusz Lipiec <herakliusz.lipiec@intel.com>\n---\n drivers/net/mlx4/mlx4_mp.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/mlx4/mlx4_mp.c b/drivers/net/mlx4/mlx4_mp.c\nindex 183622453..f4cff7486 100644\n--- a/drivers/net/mlx4/mlx4_mp.c\n+++ b/drivers/net/mlx4/mlx4_mp.c\n@@ -255,6 +255,7 @@ mlx4_mp_req_mr_create(struct rte_eth_dev *dev, uintptr_t addr)\n \tif (ret) {\n \t\tERROR(\"port %u request to primary process failed\",\n \t\t dev->data->port_id);\n+\t\tfree(mp_rep.msgs);\n \t\treturn -rte_errno;\n \t}\n \tassert(mp_rep.nb_received == 1);\n@@ -292,7 +293,8 @@ mlx4_mp_req_verbs_cmd_fd(struct rte_eth_dev *dev)\n \tif (ret) {\n \t\tERROR(\"port %u request to primary process failed\",\n \t\t dev->data->port_id);\n-\t\treturn -rte_errno;\n+\t\tret = -rte_errno;\n+\t\tgoto exit;\n \t}\n \tassert(mp_rep.nb_received == 1);\n \tmp_res = &mp_rep.msgs[0];\n", "prefixes": [ "v2", "7/8" ] }