Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53014/?format=api
{ "id": 53014, "url": "http://patches.dpdk.org/api/patches/53014/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190423165335.4025-5-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190423165335.4025-5-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190423165335.4025-5-stephen@networkplumber.org", "date": "2019-04-23T16:53:35", "name": "[v2,4/4] net/ring: check length of ring name", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "dd6bf378cc59a79ed7915018d4e13985cbcc243f", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190423165335.4025-5-stephen@networkplumber.org/mbox/", "series": [ { "id": 4431, "url": "http://patches.dpdk.org/api/series/4431/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4431", "date": "2019-04-23T16:53:31", "name": "net/ring: driver fixes", "version": 2, "mbox": "http://patches.dpdk.org/series/4431/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53014/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/53014/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2FE801B4F0;\n\tTue, 23 Apr 2019 18:54:00 +0200 (CEST)", "from mail-pf1-f194.google.com (mail-pf1-f194.google.com\n\t[209.85.210.194]) by dpdk.org (Postfix) with ESMTP id 8FDAD4CA7\n\tfor <dev@dpdk.org>; Tue, 23 Apr 2019 18:53:50 +0200 (CEST)", "by mail-pf1-f194.google.com with SMTP id w25so7781969pfi.9\n\tfor <dev@dpdk.org>; Tue, 23 Apr 2019 09:53:50 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\t71sm47194750pfs.36.2019.04.23.09.53.47\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 23 Apr 2019 09:53:48 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=uOyDKtvz7UbmBWCKoGXvUGPdqVmyNcBK16SpXqQX4cc=;\n\tb=aPQvCCt6ZBCxmBZ37xM7D/65eunzjFrBOyVP/p1n8zPZqG1HAuErQBpEHKQuZMtMWJ\n\tYTmLWamqpVmLx/8ch6s5iltLY7k8MD0Pyf8PWtQCHm/Oxg69j5f0Jy0418khsx8Us3sj\n\tqvnpq0G4WrG2zEOG8pZmjNdipKmyWCoxrzOUeCfSFFUIind+HS9iSFPjkcGyRFwY3Ca6\n\tdiotKqibx2+Q/eSSg/2g7lVtH71+HL1vQ/su2sX/9h1uAKq51hTEKn0CD2m5excLVJ8d\n\tA5EGBGoPNWTdn/6lzrpNTWTi5F8VmRU8Mu8jaI738GWfsjH2rlXSIsdl8k0hSCiqNJC1\n\tBBcQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=uOyDKtvz7UbmBWCKoGXvUGPdqVmyNcBK16SpXqQX4cc=;\n\tb=AjSML8x2UOZRgpiL3edTKA/kUWPuZzO5WuuMjI+TOicZu4ny58VnQagvQ32LzOiWYI\n\tPPVv7F3L8749TNB7aUHIUNrKp+mdbTfCwQPoKQ725kK+HsV9a6pdLi6vIVaozY8cPZOE\n\tehgZ9D6tMwip0QpKvjgKCjXDh7Tu+5YCexi4flA1dO6piLFDCLgM6pKtpZPbcCVarPjF\n\tGix/pHZlYj3FEzmKs7i667aKY4zwK9SvuXlttFVPgaHMwKmGx7xcfp8QXRsRzFOZQSy5\n\tB0aMvSpjH1aLykrB1TToUyP9BEa2Ny84pK/67UpxDhdkIv9HsiHJb+NOLC79ltZ6366a\n\trlJg==", "X-Gm-Message-State": "APjAAAWuhSeDayt8o5lvisedhCwHYobH65j9YnC6kszdfKx6OqrE4Coy\n\tszLK9+4noJNJ9EQmQ34ba8VgKA==", "X-Google-Smtp-Source": "APXvYqw+il1jO/8li5BBYPsOHa/dR3SgOyViPxFwdgCMRuy5zDnPmwIKS0vL3iozpA654F+kBve+ag==", "X-Received": "by 2002:a63:6fcd:: with SMTP id\n\tk196mr25424457pgc.238.1556038429736; \n\tTue, 23 Apr 2019 09:53:49 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "bruce.richardson@intel.com", "Cc": "dev@dpdk.org,\n\tStephen Hemminger <stephen@networkplumber.org>", "Date": "Tue, 23 Apr 2019 09:53:35 -0700", "Message-Id": "<20190423165335.4025-5-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190423165335.4025-1-stephen@networkplumber.org>", "References": "<20190423164812.3427-1-stephen@networkplumber.org>\n\t<20190423165335.4025-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 4/4] net/ring: check length of ring name", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The ring name is passed in as part of this drivers API, but it\ndoesn't check that the name is not truncated.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\nv2 - fix whitespace creep\n\n drivers/net/ring/rte_eth_ring.c | 17 +++++++++++++++--\n 1 file changed, 15 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c\nindex 0355f2b7c4d8..979993fd3e11 100644\n--- a/drivers/net/ring/rte_eth_ring.c\n+++ b/drivers/net/ring/rte_eth_ring.c\n@@ -383,7 +383,12 @@ rte_eth_from_rings(const char *name, struct rte_ring *const rx_queues[],\n \n \tsnprintf(args_str, sizeof(args_str), \"%s=%p\",\n \t\t ETH_RING_INTERNAL_ARG, &args);\n-\tsnprintf(ring_name, sizeof(ring_name), \"net_ring_%s\", name);\n+\n+\tret = snprintf(ring_name, sizeof(ring_name), \"net_ring_%s\", name);\n+\tif (ret >= (int)sizeof(ring_name)) {\n+\t\trte_errno = ENAMETOOLONG;\n+\t\treturn -1;\n+\t}\n \n \tret = rte_vdev_init(ring_name, args_str);\n \tif (ret) {\n@@ -417,7 +422,15 @@ eth_dev_ring_create(const char *name, const unsigned int numa_node,\n \t\t\tRTE_PMD_RING_MAX_TX_RINGS);\n \n \tfor (i = 0; i < num_rings; i++) {\n-\t\tsnprintf(rng_name, sizeof(rng_name), \"ETH_RXTX%u_%s\", i, name);\n+\t\tint cc;\n+\n+\t\tcc = snprintf(rng_name, sizeof(rng_name),\n+\t\t\t \"ETH_RXTX%u_%s\", i, name);\n+\t\tif (cc >= (int)sizeof(rng_name)) {\n+\t\t\trte_errno = ENAMETOOLONG;\n+\t\t\treturn -1;\n+\t\t}\n+\n \t\trxtx[i] = (action == DEV_CREATE) ?\n \t\t\t\trte_ring_create(rng_name, 1024, numa_node,\n \t\t\t\t\t\tRING_F_SP_ENQ|RING_F_SC_DEQ) :\n", "prefixes": [ "v2", "4/4" ] }