Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 53012,
    "url": "http://patches.dpdk.org/api/patches/53012/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190423165335.4025-3-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190423165335.4025-3-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190423165335.4025-3-stephen@networkplumber.org",
    "date": "2019-04-23T16:53:33",
    "name": "[v2,2/4] net/ring: use sizeof() with snprintf",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "fbdcc316bcfba99052c398146ed477e96fd2d7f9",
    "submitter": {
        "id": 27,
        "url": "http://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190423165335.4025-3-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 4431,
            "url": "http://patches.dpdk.org/api/series/4431/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4431",
            "date": "2019-04-23T16:53:31",
            "name": "net/ring: driver fixes",
            "version": 2,
            "mbox": "http://patches.dpdk.org/series/4431/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/53012/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/53012/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9B0A51B486;\n\tTue, 23 Apr 2019 18:53:52 +0200 (CEST)",
            "from mail-pf1-f193.google.com (mail-pf1-f193.google.com\n\t[209.85.210.193]) by dpdk.org (Postfix) with ESMTP id 3F7225F51\n\tfor <dev@dpdk.org>; Tue, 23 Apr 2019 18:53:47 +0200 (CEST)",
            "by mail-pf1-f193.google.com with SMTP id i17so7786529pfo.6\n\tfor <dev@dpdk.org>; Tue, 23 Apr 2019 09:53:47 -0700 (PDT)",
            "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\t71sm47194750pfs.36.2019.04.23.09.53.44\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 23 Apr 2019 09:53:45 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=62W36ynNMKSTZgtQuhWc9PSZc0VPxhnbMciWt9vJ8bE=;\n\tb=B6vjUJvTH4zO2cRxNFnHr3m0WbM5epaG2ph1mdIHCIYkTN6jJ1I1jF54aAp5/44ace\n\tDBR8XaQ6L52oxqxSsWRgIb3uhHZ856D8QkeZSPHXrJjVGnLZ5oMpWuT4uYeQHtxz286e\n\t3qJdF/cFC4xz8DZotMqISNbjWfIvE6Yu+rQJiGmFYPH9F/8xERWxhlFYndJR7FG1yOYV\n\tiPH9twYUAQ9BxRDq4nRHN9kv2b4SrQnlPCcBk7Wl69ovOSQVcbh9ba7XfT/hnLm/0IwB\n\tFJtXbq4L35ETgxYrE3Kvkor6fQg/yDQrtIWtqvB/ghGoqTbnoO4hd2wbRHFUybFoyPFI\n\tuHKQ==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=62W36ynNMKSTZgtQuhWc9PSZc0VPxhnbMciWt9vJ8bE=;\n\tb=MU7Gi77tmkbr3wTpRntedkF+lEErBbJz6Vua7Bx7M+TeF0FdcfYHcHXy5VJjEY6Bs3\n\tQ3dkfkrkCp1cTsBEhNFcta0ttkjJyFP2HkG5ircepI4T30lkmg67J0pyibfbSNaE9+m/\n\tvmqWybt9nSyYER12ne8V4eMF+K2MSKuAn763BTmTRpK48QMxjsyTzWYtkrOJu+8RNdO8\n\t7lu4jjKCwXJuyCFt5LJhQBjLF+eaS8UtbZ8qcU2nv1iCwtjUBDTjRNo48v5Vc7fUE9qn\n\toJYc+pQ9jAzatVvaelaRGoOVrvdQClDG8KgulwogbO8UfNu3N5hJip02DcsWywRGQKwR\n\tpR3w==",
        "X-Gm-Message-State": "APjAAAWmPXhCzPcolDA6BEeRyqJsvpHELNSOHVVDpd6zCUGAHIWxH/uR\n\t0DNb6Opm8aUGwoUjMrQrba6skpRObOI=",
        "X-Google-Smtp-Source": "APXvYqzIfMtLgmI7ouO4fIMwSzd9j1nE2U2ifrIqdQg3gURAAajZkAB46aJoN1zssEWbuRsDr53bow==",
        "X-Received": "by 2002:a65:62c9:: with SMTP id\n\tm9mr25649990pgv.309.1556038426235; \n\tTue, 23 Apr 2019 09:53:46 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "bruce.richardson@intel.com",
        "Cc": "dev@dpdk.org,\n\tStephen Hemminger <stephen@networkplumber.org>",
        "Date": "Tue, 23 Apr 2019 09:53:33 -0700",
        "Message-Id": "<20190423165335.4025-3-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.20.1",
        "In-Reply-To": "<20190423165335.4025-1-stephen@networkplumber.org>",
        "References": "<20190423164812.3427-1-stephen@networkplumber.org>\n\t<20190423165335.4025-1-stephen@networkplumber.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Subject": "[dpdk-dev] [PATCH v2 2/4] net/ring: use sizeof() with snprintf",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Don't hard code string length in two place; use sizeof() instead.\nRing name shoudl use RTE_RING_NAMESIZE.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/ring/rte_eth_ring.c | 9 +++++----\n 1 file changed, 5 insertions(+), 4 deletions(-)",
    "diff": "diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c\nindex 91e5f5f8f262..2e4ca3b16a1c 100644\n--- a/drivers/net/ring/rte_eth_ring.c\n+++ b/drivers/net/ring/rte_eth_ring.c\n@@ -362,8 +362,8 @@ rte_eth_from_rings(const char *name, struct rte_ring *const rx_queues[],\n \t\t.numa_node = numa_node,\n \t\t.addr = &args,\n \t};\n-\tchar args_str[32] = { 0 };\n-\tchar ring_name[32] = { 0 };\n+\tchar args_str[32];\n+\tchar ring_name[RTE_RING_NAMESIZE];\n \tuint16_t port_id = RTE_MAX_ETHPORTS;\n \tint ret;\n \n@@ -381,8 +381,9 @@ rte_eth_from_rings(const char *name, struct rte_ring *const rx_queues[],\n \t\treturn -1;\n \t}\n \n-\tsnprintf(args_str, 32, \"%s=%p\", ETH_RING_INTERNAL_ARG, &args);\n-\tsnprintf(ring_name, 32, \"net_ring_%s\", name);\n+\tsnprintf(args_str, sizeof(args_str), \"%s=%p\",\n+\t\t ETH_RING_INTERNAL_ARG, &args);\n+\tsnprintf(ring_name, sizeof(ring_name), \"net_ring_%s\", name);\n \n \tret = rte_vdev_init(ring_name, args_str);\n \tif (ret) {\n",
    "prefixes": [
        "v2",
        "2/4"
    ]
}