Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53009/?format=api
{ "id": 53009, "url": "http://patches.dpdk.org/api/patches/53009/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190423164812.3427-5-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190423164812.3427-5-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190423164812.3427-5-stephen@networkplumber.org", "date": "2019-04-23T16:48:12", "name": "[4/4] net/ring: check length of ring name", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4bc8f41326f0ba4e71ccf8fb14b20442239da2cc", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190423164812.3427-5-stephen@networkplumber.org/mbox/", "series": [ { "id": 4430, "url": "http://patches.dpdk.org/api/series/4430/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4430", "date": "2019-04-23T16:48:08", "name": "net/ring: driver fixes", "version": 1, "mbox": "http://patches.dpdk.org/series/4430/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53009/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/53009/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 109211B4C1;\n\tTue, 23 Apr 2019 18:48:33 +0200 (CEST)", "from mail-pg1-f193.google.com (mail-pg1-f193.google.com\n\t[209.85.215.193]) by dpdk.org (Postfix) with ESMTP id 8042E1B3D2\n\tfor <dev@dpdk.org>; Tue, 23 Apr 2019 18:48:26 +0200 (CEST)", "by mail-pg1-f193.google.com with SMTP id k19so7900039pgh.0\n\tfor <dev@dpdk.org>; Tue, 23 Apr 2019 09:48:26 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\th65sm58943277pfd.108.2019.04.23.09.48.24\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 23 Apr 2019 09:48:24 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=AZKQ2K/OWD0zBctfqE7pT9svK7y8AYM7fapDXeko9Fg=;\n\tb=F/Tx698uCyj5vxKDl9sqD5zhzSFFbsd8/932tU2OASghw80CxAYRldPdTyl8XGl3JM\n\tyg2jDwvWMHzVtDkkUEINE14WiX+S8tk8gIy/Q05dVtIuAmJ3YvCkdDB16NGE6BoN84ZI\n\t3+FRzKbRf7ysbx9tN/SvoLmDZbgsaizBjMS6phGUBwpVp9WzL2g0Kc2GN/xeEZ/87Xz/\n\twhix5LEQ3Qu7fYruWFtZRdO5pq+bj9VK2bQDWRK3NP3r1PWhuQlWQpv+tU5ZRiWDDhuz\n\tJMH1O/R3v1KGj/RWe2b0EhUKflZ6A40NWCAK25VU7rItwN66Id9c/VUutIBkBPlDQduz\n\t09qA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=AZKQ2K/OWD0zBctfqE7pT9svK7y8AYM7fapDXeko9Fg=;\n\tb=hPKjAcRh1t+WckVUvh3slyUmk+jiyr1euHw4tQyP6bjfkA56g0VqUjGknjaqfgImeC\n\tfZkdCfVqVsgYzuJ9IzTCzo4zkTgBov11VWzBVJaGSdwPDyjMBzGC2UBu4aZ0w/RUz+nU\n\t/qDMn9MSLXPZ2jeHKtAYCCLNxtNqmBb3TstBDpvFCfHfCAfu9nn4WoUCX+FE04NcUJ88\n\tfSAHuFLDo7r0LwWQkRQgv2NHRrdzlj4lNNX150Vn3DNdEaOw1HnsXERCK3qgx0ggB6Iy\n\tmCTvw0+gPFox+OJgCpM22r8ZBuh2M42NpHq0V0bWqy19Di1RE9MWHKIVsoeEKi0ylHZO\n\tzjIQ==", "X-Gm-Message-State": "APjAAAVEmmkudcwG/BzeD97UqYwoadSvoj2oSvrkDgMTqMh4ha63cx4h\n\tm/axEvZFAXTbsCGhzrO8foM9sw==", "X-Google-Smtp-Source": "APXvYqz8a1dTcQaCohDqg83/qDzN1Q8Js197jZLeOnDKHD3a9dBbi28l4zmaxX7lCkMmEHBVul+nvQ==", "X-Received": "by 2002:aa7:8694:: with SMTP id\n\td20mr27465041pfo.81.1556038105604; \n\tTue, 23 Apr 2019 09:48:25 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "bruce.richardson@intel.com", "Cc": "dev@dpdk.org,\n\tStephen Hemminger <stephen@networkplumber.org>", "Date": "Tue, 23 Apr 2019 09:48:12 -0700", "Message-Id": "<20190423164812.3427-5-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190423164812.3427-1-stephen@networkplumber.org>", "References": "<20190423164812.3427-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 4/4] net/ring: check length of ring name", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The ring name is passed in as part of this drivers API, but it\ndoesn't check that the name is not truncated.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/ring/rte_eth_ring.c | 17 +++++++++++++++--\n 1 file changed, 15 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c\nindex 0355f2b7c4d8..9125692f2c9b 100644\n--- a/drivers/net/ring/rte_eth_ring.c\n+++ b/drivers/net/ring/rte_eth_ring.c\n@@ -383,7 +383,12 @@ rte_eth_from_rings(const char *name, struct rte_ring *const rx_queues[],\n \n \tsnprintf(args_str, sizeof(args_str), \"%s=%p\",\n \t\t ETH_RING_INTERNAL_ARG, &args);\n-\tsnprintf(ring_name, sizeof(ring_name), \"net_ring_%s\", name);\n+\n+\tret = snprintf(ring_name, sizeof(ring_name), \"net_ring_%s\", name);\n+\tif (ret >= (int)sizeof(ring_name)) {\n+\t\trte_errno = ENAMETOOLONG;\n+\t\treturn -1;\n+\t}\n \n \tret = rte_vdev_init(ring_name, args_str);\n \tif (ret) {\n@@ -417,7 +422,15 @@ eth_dev_ring_create(const char *name, const unsigned int numa_node,\n \t\t\tRTE_PMD_RING_MAX_TX_RINGS);\n \n \tfor (i = 0; i < num_rings; i++) {\n-\t\tsnprintf(rng_name, sizeof(rng_name), \"ETH_RXTX%u_%s\", i, name);\n+\t\tint cc;\n+\t\t\n+\t\tcc = snprintf(rng_name, sizeof(rng_name),\n+\t\t\t \"ETH_RXTX%u_%s\", i, name);\n+\t\tif (cc >= (int)sizeof(rng_name)) {\n+\t\t\trte_errno = ENAMETOOLONG;\n+\t\t\treturn -1;\n+\t\t}\n+\t\t\n \t\trxtx[i] = (action == DEV_CREATE) ?\n \t\t\t\trte_ring_create(rng_name, 1024, numa_node,\n \t\t\t\t\t\tRING_F_SP_ENQ|RING_F_SC_DEQ) :\n", "prefixes": [ "4/4" ] }