Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53007/?format=api
{ "id": 53007, "url": "http://patches.dpdk.org/api/patches/53007/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190423164812.3427-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190423164812.3427-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190423164812.3427-3-stephen@networkplumber.org", "date": "2019-04-23T16:48:10", "name": "[2/4] net/ring: use sizeof() with snprintf", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "fbdcc316bcfba99052c398146ed477e96fd2d7f9", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190423164812.3427-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 4430, "url": "http://patches.dpdk.org/api/series/4430/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4430", "date": "2019-04-23T16:48:08", "name": "net/ring: driver fixes", "version": 1, "mbox": "http://patches.dpdk.org/series/4430/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53007/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/53007/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 520E01B42B;\n\tTue, 23 Apr 2019 18:48:27 +0200 (CEST)", "from mail-pg1-f193.google.com (mail-pg1-f193.google.com\n\t[209.85.215.193]) by dpdk.org (Postfix) with ESMTP id 72F711B3A8\n\tfor <dev@dpdk.org>; Tue, 23 Apr 2019 18:48:23 +0200 (CEST)", "by mail-pg1-f193.google.com with SMTP id f6so7879603pgs.8\n\tfor <dev@dpdk.org>; Tue, 23 Apr 2019 09:48:23 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\th65sm58943277pfd.108.2019.04.23.09.48.20\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 23 Apr 2019 09:48:21 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=62W36ynNMKSTZgtQuhWc9PSZc0VPxhnbMciWt9vJ8bE=;\n\tb=U9CkNZWHmo6NtbyHUpdR3ax/As4yOgvpGJWmxQJRMIjYYuzb9N1vfAj4DXYADcpZvL\n\tqO/WZFb4BOxiLc7fFCRT+fDS+PTtW/YAGdEYz8et71nys+MaaMD9qdfXffcZpQZ0WMNH\n\tLrXZB1E+HhGostpTza9UuDqmD/f1IxD6FHSIb7AkWTkBZMuyEGgLUosGskNM407Ugzx9\n\tNCjB3Jxr7E89iZDUOHeogyznkGpw3/jZnLQkabSCXCWg0dKvS7EdaDNHTPhzwyw07mmH\n\ttlFE2a1FffrYdErtuzMQHwR1gd4GxoKJHh+A8y6nL4BfxXC/HXzKKj3wV+7YCqhAcoes\n\tv3Zw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=62W36ynNMKSTZgtQuhWc9PSZc0VPxhnbMciWt9vJ8bE=;\n\tb=eeLTVmxNxvUrkUjYD1OpXzh+/NzLcSloLwsmdv324GtWLg6zhdzoFsjciNzl/HxsXe\n\t9IpKy/EI1riO+GgPWIqUinHbVylz7DNHjsUBkhRAMkTyA58ol+t3nev+OsxN8JEnhPpX\n\tyGmOD8SPOeeqN9GgGLNneVpO77PpJj8wPQ6lyyD3uaAbIJb/aq/J6qB8mTuqZifp9voX\n\tm8jT7kAtqxwMpqAbFiRmgWt05zBMCG2f/2x8Rn2VAVLoOuZI/uuUOSdFDdCU1dlE401X\n\t/FrEeJosS/aT10xFnp0BnzVfdnDX4T7kPZyVz0P3VehWOpBhl/5sCFzWAW24IYEJrB+2\n\t8lfw==", "X-Gm-Message-State": "APjAAAXYNm1AvNDbYd/1NNyPVesdIsFfwrhyHhlQezohxA+NTDlJzXIL\n\tBp3X8aw+N0+IvyGPUd2cmhmqjiRbn1E=", "X-Google-Smtp-Source": "APXvYqyBhLXNnbbJItPoT5Ib/kts6s3Wb5fRVFgmTr4p2OfqAS7qcuRcViFBsrOMAeGmbZ1PPUkj9w==", "X-Received": "by 2002:a62:aa06:: with SMTP id\n\te6mr28100079pff.254.1556038102629; \n\tTue, 23 Apr 2019 09:48:22 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "bruce.richardson@intel.com", "Cc": "dev@dpdk.org,\n\tStephen Hemminger <stephen@networkplumber.org>", "Date": "Tue, 23 Apr 2019 09:48:10 -0700", "Message-Id": "<20190423164812.3427-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190423164812.3427-1-stephen@networkplumber.org>", "References": "<20190423164812.3427-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 2/4] net/ring: use sizeof() with snprintf", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Don't hard code string length in two place; use sizeof() instead.\nRing name shoudl use RTE_RING_NAMESIZE.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/ring/rte_eth_ring.c | 9 +++++----\n 1 file changed, 5 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c\nindex 91e5f5f8f262..2e4ca3b16a1c 100644\n--- a/drivers/net/ring/rte_eth_ring.c\n+++ b/drivers/net/ring/rte_eth_ring.c\n@@ -362,8 +362,8 @@ rte_eth_from_rings(const char *name, struct rte_ring *const rx_queues[],\n \t\t.numa_node = numa_node,\n \t\t.addr = &args,\n \t};\n-\tchar args_str[32] = { 0 };\n-\tchar ring_name[32] = { 0 };\n+\tchar args_str[32];\n+\tchar ring_name[RTE_RING_NAMESIZE];\n \tuint16_t port_id = RTE_MAX_ETHPORTS;\n \tint ret;\n \n@@ -381,8 +381,9 @@ rte_eth_from_rings(const char *name, struct rte_ring *const rx_queues[],\n \t\treturn -1;\n \t}\n \n-\tsnprintf(args_str, 32, \"%s=%p\", ETH_RING_INTERNAL_ARG, &args);\n-\tsnprintf(ring_name, 32, \"net_ring_%s\", name);\n+\tsnprintf(args_str, sizeof(args_str), \"%s=%p\",\n+\t\t ETH_RING_INTERNAL_ARG, &args);\n+\tsnprintf(ring_name, sizeof(ring_name), \"net_ring_%s\", name);\n \n \tret = rte_vdev_init(ring_name, args_str);\n \tif (ret) {\n", "prefixes": [ "2/4" ] }