Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53006/?format=api
{ "id": 53006, "url": "http://patches.dpdk.org/api/patches/53006/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190423164812.3427-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190423164812.3427-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20190423164812.3427-2-stephen@networkplumber.org", "date": "2019-04-23T16:48:09", "name": "[1/4] net/ring: fix coding style", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9ca002c34f6290f9ff0cc18dfa76831ac89ae0da", "submitter": { "id": 27, "url": "http://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190423164812.3427-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 4430, "url": "http://patches.dpdk.org/api/series/4430/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4430", "date": "2019-04-23T16:48:08", "name": "net/ring: driver fixes", "version": 1, "mbox": "http://patches.dpdk.org/series/4430/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53006/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/53006/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 68EC81B3B7;\n\tTue, 23 Apr 2019 18:48:24 +0200 (CEST)", "from mail-pl1-f195.google.com (mail-pl1-f195.google.com\n\t[209.85.214.195]) by dpdk.org (Postfix) with ESMTP id DA2E81B3A8\n\tfor <dev@dpdk.org>; Tue, 23 Apr 2019 18:48:21 +0200 (CEST)", "by mail-pl1-f195.google.com with SMTP id o7so5561100pll.13\n\tfor <dev@dpdk.org>; Tue, 23 Apr 2019 09:48:21 -0700 (PDT)", "from hermes.lan (204-195-22-127.wavecable.com. [204.195.22.127])\n\tby smtp.gmail.com with ESMTPSA id\n\th65sm58943277pfd.108.2019.04.23.09.48.19\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tTue, 23 Apr 2019 09:48:19 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=Idsor3QgEThF7cW+Rj13b0aHmkE5qeQvQi5qfSiIfYo=;\n\tb=UjF0Q+oD7b9GZBIEN6djCbK/+Bbg78YR/u3L6s8Z/ugLb6yzRWRrzu77pA3iKROIZ8\n\tRQ+g+mIG5SVABRjWY855GKmakEjSmItME5QgVYUJTk57lKbPtkdyZawU+kQacr/uX7/l\n\tArxngsVyUcgZVA2bfNA4OZhUQdZKeMNJWVEqc9Yo5NqbNbWB26V76+klk4I+nCAQIRyg\n\t1MxruOvhqawFv9lMAL/fIfgV0HlHCL/mSClwXDyqCdQhQY47w+NEQBuObPwr9LtC5oUG\n\tdf0YbBsH7AYoLXk4o+S2aRfxL0eYK27BbhQEIGl/V3BLy+t1maW+JXJORFVzpeW4nV1Q\n\tax+A==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=Idsor3QgEThF7cW+Rj13b0aHmkE5qeQvQi5qfSiIfYo=;\n\tb=bWS3zbDe/kAbL2KPYc/6XkOMK2SjzShFNDJGp7cVrxMFutzjrAih6UDCNODCCnOIBS\n\tbT64PbZ+RmsQivjqgwbvWEN/YWN8m49ck09CxVCALTUj0WMsji/6QrzP8wzVflRI3lQr\n\t4n3VhXK9nVdTup8TXl2xqSGhTvtue2e9ujQFo1XwESied1Hpkbw46xcnlsgFP3nEoB3I\n\tfgCGP6yUZHtmJ8xDFoCEMcyLTxukobuL0LgT+1SHNCMxtC3q/t6+X1HZwlDBLXaqA5UQ\n\ttU2V1qY4QwYlFUkMI4wtFqhtHvQicsuX34YHTNyZoYx6bpRaROrwKmHOzv2VoQT8MkXN\n\tajUw==", "X-Gm-Message-State": "APjAAAXTYBVkPsC32u8vrmYudggfhiiuPPi710ryXKtMBNRf53QKoZEf\n\tLOFhY6kgLMNCc+w7ELVzZ6Ltcg==", "X-Google-Smtp-Source": "APXvYqyaZyql0TX8dD7U2v46hJ6kkXGMulIrZV+hv3z+fs5uBBegNtkOEMJCgCiSwandSnkj1SfQaA==", "X-Received": "by 2002:a17:902:e683:: with SMTP id\n\tcn3mr27258584plb.115.1556038100882; \n\tTue, 23 Apr 2019 09:48:20 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "bruce.richardson@intel.com", "Cc": "dev@dpdk.org, Stephen Hemminger <stephen@networkplumber.org>,\n\tStephen Hemminger <sthemmin@microsoft.com>", "Date": "Tue, 23 Apr 2019 09:48:09 -0700", "Message-Id": "<20190423164812.3427-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190423164812.3427-1-stephen@networkplumber.org>", "References": "<20190423164812.3427-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/4] net/ring: fix coding style", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Whitespace fixes to bring inline with current DPDK style.\n\nSigned-off-by: Stephen Hemminger <sthemmin@microsoft.com>\n---\n drivers/net/ring/rte_eth_ring.c | 58 ++++++++++++++++++---------------\n 1 file changed, 32 insertions(+), 26 deletions(-)", "diff": "diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c\nindex 115a882b507c..91e5f5f8f262 100644\n--- a/drivers/net/ring/rte_eth_ring.c\n+++ b/drivers/net/ring/rte_eth_ring.c\n@@ -45,8 +45,8 @@ struct ring_queue {\n };\n \n struct pmd_internals {\n-\tunsigned max_rx_queues;\n-\tunsigned max_tx_queues;\n+\tunsigned int max_rx_queues;\n+\tunsigned int max_tx_queues;\n \n \tstruct ring_queue rx_ring_queues[RTE_PMD_RING_MAX_RX_RINGS];\n \tstruct ring_queue tx_ring_queues[RTE_PMD_RING_MAX_TX_RINGS];\n@@ -55,12 +55,11 @@ struct pmd_internals {\n \tenum dev_action action;\n };\n \n-\n static struct rte_eth_link pmd_link = {\n-\t\t.link_speed = ETH_SPEED_NUM_10G,\n-\t\t.link_duplex = ETH_LINK_FULL_DUPLEX,\n-\t\t.link_status = ETH_LINK_DOWN,\n-\t\t.link_autoneg = ETH_LINK_FIXED,\n+\t.link_speed = ETH_SPEED_NUM_10G,\n+\t.link_duplex = ETH_LINK_FULL_DUPLEX,\n+\t.link_status = ETH_LINK_DOWN,\n+\t.link_autoneg = ETH_LINK_FIXED,\n };\n \n static int eth_ring_logtype;\n@@ -138,6 +137,7 @@ eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t rx_queue_id,\n \t\t\t\t struct rte_mempool *mb_pool __rte_unused)\n {\n \tstruct pmd_internals *internals = dev->data->dev_private;\n+\n \tdev->data->rx_queues[rx_queue_id] = &internals->rx_ring_queues[rx_queue_id];\n \treturn 0;\n }\n@@ -149,6 +149,7 @@ eth_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id,\n \t\t\t\t const struct rte_eth_txconf *tx_conf __rte_unused)\n {\n \tstruct pmd_internals *internals = dev->data->dev_private;\n+\n \tdev->data->tx_queues[tx_queue_id] = &internals->tx_ring_queues[tx_queue_id];\n \treturn 0;\n }\n@@ -156,9 +157,10 @@ eth_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id,\n \n static void\n eth_dev_info(struct rte_eth_dev *dev,\n-\t\tstruct rte_eth_dev_info *dev_info)\n+\t struct rte_eth_dev_info *dev_info)\n {\n \tstruct pmd_internals *internals = dev->data->dev_private;\n+\n \tdev_info->max_mac_addrs = 1;\n \tdev_info->max_rx_pktlen = (uint32_t)-1;\n \tdev_info->max_rx_queues = (uint16_t)internals->max_rx_queues;\n@@ -169,7 +171,7 @@ eth_dev_info(struct rte_eth_dev *dev,\n static int\n eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n {\n-\tunsigned i;\n+\tunsigned int i;\n \tunsigned long rx_total = 0, tx_total = 0, tx_err_total = 0;\n \tconst struct pmd_internals *internal = dev->data->dev_private;\n \n@@ -197,8 +199,9 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n static void\n eth_stats_reset(struct rte_eth_dev *dev)\n {\n-\tunsigned i;\n+\tunsigned int i;\n \tstruct pmd_internals *internal = dev->data->dev_private;\n+\n \tfor (i = 0; i < dev->data->nb_rx_queues; i++)\n \t\tinternal->rx_ring_queues[i].rx_pkts.cnt = 0;\n \tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n@@ -250,8 +253,10 @@ static struct rte_vdev_driver pmd_ring_drv;\n \n static int\n do_eth_dev_ring_create(const char *name,\n-\t\tstruct rte_ring * const rx_queues[], const unsigned nb_rx_queues,\n-\t\tstruct rte_ring *const tx_queues[], const unsigned nb_tx_queues,\n+\t\tstruct rte_ring * const rx_queues[],\n+\t\tconst unsigned int nb_rx_queues,\n+\t\tstruct rte_ring *const tx_queues[],\n+\t\tconst unsigned int nb_tx_queues,\n \t\tconst unsigned int numa_node, enum dev_action action,\n \t\tstruct rte_eth_dev **eth_dev_p)\n {\n@@ -260,7 +265,7 @@ do_eth_dev_ring_create(const char *name,\n \tstruct rte_eth_dev *eth_dev = NULL;\n \tvoid **rx_queues_local = NULL;\n \tvoid **tx_queues_local = NULL;\n-\tunsigned i;\n+\tunsigned int i;\n \n \tPMD_LOG(INFO, \"Creating rings-backed ethdev on numa socket %u\",\n \t\t\tnuma_node);\n@@ -344,10 +349,10 @@ do_eth_dev_ring_create(const char *name,\n \n int\n rte_eth_from_rings(const char *name, struct rte_ring *const rx_queues[],\n-\t\tconst unsigned nb_rx_queues,\n+\t\tconst unsigned int nb_rx_queues,\n \t\tstruct rte_ring *const tx_queues[],\n-\t\tconst unsigned nb_tx_queues,\n-\t\tconst unsigned numa_node)\n+\t\tconst unsigned int nb_tx_queues,\n+\t\tconst unsigned int numa_node)\n {\n \tstruct ring_internal_args args = {\n \t\t.rx_queues = rx_queues,\n@@ -398,16 +403,16 @@ rte_eth_from_ring(struct rte_ring *r)\n }\n \n static int\n-eth_dev_ring_create(const char *name, const unsigned numa_node,\n+eth_dev_ring_create(const char *name, const unsigned int numa_node,\n \t\tenum dev_action action, struct rte_eth_dev **eth_dev)\n {\n \t/* rx and tx are so-called from point of view of first port.\n \t * They are inverted from the point of view of second port\n \t */\n \tstruct rte_ring *rxtx[RTE_PMD_RING_MAX_RX_RINGS];\n-\tunsigned i;\n+\tunsigned int i;\n \tchar rng_name[RTE_RING_NAMESIZE];\n-\tunsigned num_rings = RTE_MIN(RTE_PMD_RING_MAX_RX_RINGS,\n+\tunsigned int num_rings = RTE_MIN(RTE_PMD_RING_MAX_RX_RINGS,\n \t\t\tRTE_PMD_RING_MAX_TX_RINGS);\n \n \tfor (i = 0; i < num_rings; i++) {\n@@ -429,17 +434,18 @@ eth_dev_ring_create(const char *name, const unsigned numa_node,\n \n struct node_action_pair {\n \tchar name[PATH_MAX];\n-\tunsigned node;\n+\tunsigned int node;\n \tenum dev_action action;\n };\n \n struct node_action_list {\n-\tunsigned total;\n-\tunsigned count;\n+\tunsigned int total;\n+\tunsigned int count;\n \tstruct node_action_pair *list;\n };\n \n-static int parse_kvlist (const char *key __rte_unused, const char *value, void *data)\n+static int parse_kvlist(const char *key __rte_unused,\n+\t\t\tconst char *value, void *data)\n {\n \tstruct node_action_list *info = data;\n \tint ret;\n@@ -553,8 +559,8 @@ rte_pmd_ring_probe(struct rte_vdev_device *dev)\n \t\tkvlist = rte_kvargs_parse(params, valid_arguments);\n \n \t\tif (!kvlist) {\n-\t\t\tPMD_LOG(INFO, \"Ignoring unsupported parameters when creating\"\n-\t\t\t\t\t\" rings-backed ethernet device\");\n+\t\t\tPMD_LOG(INFO,\n+\t\t\t\t\"Ignoring unsupported parameters when creatingrings-backed ethernet device\");\n \t\t\tret = eth_dev_ring_create(name, rte_socket_id(),\n \t\t\t\t\t\t DEV_CREATE, ð_dev);\n \t\t\tif (ret == -1) {\n@@ -598,7 +604,7 @@ rte_pmd_ring_probe(struct rte_vdev_device *dev)\n \t\t\t\tgoto out_free;\n \n \t\t\tinfo->total = ret;\n-\t\t\tinfo->list = (struct node_action_pair*)(info + 1);\n+\t\t\tinfo->list = (struct node_action_pair *)(info + 1);\n \n \t\t\tret = rte_kvargs_process(kvlist, ETH_RING_NUMA_NODE_ACTION_ARG,\n \t\t\t\t\t\t parse_kvlist, info);\n", "prefixes": [ "1/4" ] }