Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/53002/?format=api
{ "id": 53002, "url": "http://patches.dpdk.org/api/patches/53002/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190423154357.29877-2-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190423154357.29877-2-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190423154357.29877-2-bruce.richardson@intel.com", "date": "2019-04-23T15:43:55", "name": "[v2,1/3] crypto/aesni_gcm: add dependency version check", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "6b287c0719a9a8eb73df3b278eb702f5bbe8c5ff", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 6690, "url": "http://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190423154357.29877-2-bruce.richardson@intel.com/mbox/", "series": [ { "id": 4429, "url": "http://patches.dpdk.org/api/series/4429/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4429", "date": "2019-04-23T15:43:54", "name": "improve IPsec_MB dependency checks", "version": 2, "mbox": "http://patches.dpdk.org/series/4429/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/53002/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/53002/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6868E1B434;\n\tTue, 23 Apr 2019 17:44:12 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id DC1FA1B434\n\tfor <dev@dpdk.org>; Tue, 23 Apr 2019 17:44:10 +0200 (CEST)", "from orsmga004.jf.intel.com ([10.7.209.38])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t23 Apr 2019 08:44:10 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.222.236])\n\tby orsmga004.jf.intel.com with ESMTP; 23 Apr 2019 08:44:09 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,386,1549958400\"; d=\"scan'208\";a=\"293854390\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "pablo.de.lara.guarch@intel.com,\n\tdev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>", "Date": "Tue, 23 Apr 2019 16:43:55 +0100", "Message-Id": "<20190423154357.29877-2-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190423154357.29877-1-bruce.richardson@intel.com>", "References": "<20190423154357.29877-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 1/3] crypto/aesni_gcm: add dependency version\n\tcheck", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The aesni_mb driver and the aesni_gcm driver both require the same version\nof the IPSec_MB library, but only the former has a check of the library\nfound by meson to see if it's the correct version. Add a similar check to\nthe aesni_gcm library's meson.build file, so that the auto-detection of\ndependencies works correctly.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/crypto/aesni_gcm/meson.build | 11 +++++++++++\n 1 file changed, 11 insertions(+)", "diff": "diff --git a/drivers/crypto/aesni_gcm/meson.build b/drivers/crypto/aesni_gcm/meson.build\nindex 70f57ad73..7183cfcba 100644\n--- a/drivers/crypto/aesni_gcm/meson.build\n+++ b/drivers/crypto/aesni_gcm/meson.build\n@@ -1,11 +1,22 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2018 Intel Corporation\n \n+IMB_required_ver = '0.52.0'\n lib = cc.find_library('IPSec_MB', required: false)\n if not lib.found()\n \tbuild = false\n else\n \text_deps += lib\n+\n+\t# version comes with quotes, so we split based on \" and take the middle\n+\timb_ver = cc.get_define('IMB_VERSION_STR',\n+\t\tprefix : '#include<intel-ipsec-mb.h>').split('\"')[1]\n+\n+\tif (imb_ver == '') or (imb_ver.version_compare('<' + IMB_required_ver))\n+\t\tmessage('IPSec_MB version >= @0@ is required, found version @1@'.format(\n+\t\t\t\tIMB_required_ver, imb_ver))\n+\t\tbuild = false\n+\tendif\n endif\n \n allow_experimental_apis = true\n", "prefixes": [ "v2", "1/3" ] }