Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52882/?format=api
{ "id": 52882, "url": "http://patches.dpdk.org/api/patches/52882/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/a2c84c27e9548363c1ef21ef0fe731a51eceb5e5.1555515863.git.igor.russkikh@aquantia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<a2c84c27e9548363c1ef21ef0fe731a51eceb5e5.1555515863.git.igor.russkikh@aquantia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/a2c84c27e9548363c1ef21ef0fe731a51eceb5e5.1555515863.git.igor.russkikh@aquantia.com", "date": "2019-04-17T15:45:36", "name": "[v2,4/7] net/atlantic: interrupt handling of macsec events", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "83725526269681b99bff58e2f20fe4d893332e0a", "submitter": { "id": 1124, "url": "http://patches.dpdk.org/api/people/1124/?format=api", "name": "Igor Russkikh", "email": "igor.russkikh@aquantia.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/a2c84c27e9548363c1ef21ef0fe731a51eceb5e5.1555515863.git.igor.russkikh@aquantia.com/mbox/", "series": [ { "id": 4355, "url": "http://patches.dpdk.org/api/series/4355/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4355", "date": "2019-04-17T15:45:25", "name": "add MACSEC hw offload to atlantic PMD", "version": 2, "mbox": "http://patches.dpdk.org/series/4355/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/52882/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/52882/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 243D61B767;\n\tWed, 17 Apr 2019 17:45:43 +0200 (CEST)", "from NAM03-CO1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr790083.outbound.protection.outlook.com [40.107.79.83])\n\tby dpdk.org (Postfix) with ESMTP id 614691B76F\n\tfor <dev@dpdk.org>; Wed, 17 Apr 2019 17:45:41 +0200 (CEST)", "from DM6PR11MB3625.namprd11.prod.outlook.com (20.178.230.149) by\n\tDM6PR11MB3738.namprd11.prod.outlook.com (20.179.16.20) with Microsoft\n\tSMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1813.12; Wed, 17 Apr 2019 15:45:37 +0000", "from DM6PR11MB3625.namprd11.prod.outlook.com\n\t([fe80::f035:2c20:5a61:7653]) by\n\tDM6PR11MB3625.namprd11.prod.outlook.com\n\t([fe80::f035:2c20:5a61:7653%3]) with mapi id 15.20.1813.011;\n\tWed, 17 Apr 2019 15:45:37 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=DP+mPRTQOTIzL+aNqyou6U4d24w1PqxnSm6dJ0bMpmM=;\n\tb=F2yrzkIQbIy4rE7XfsRB8+V2SXxOUFhzWBzeB65NuMzBZQA+cUg0cWNSr84qUQ1QyRacPrBY58sNGg6al6rA6uI3vEOCpbpS7hCQO3hiugWByPbchp/9dxV4PTKx7xK9QeP0lXnxKys9B/Jm3pQrl7nUI2N7h0FZrBLrIxFdG50=", "From": "Igor Russkikh <Igor.Russkikh@aquantia.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>", "CC": "\"ferruh.yigit@intel.com\" <ferruh.yigit@intel.com>, \"thomas@monjalon.net\"\n\t<thomas@monjalon.net>, \"arybchenko@solarflare.com\"\n\t<arybchenko@solarflare.com>, \"konstantin.ananyev@intel.com\"\n\t<konstantin.ananyev@intel.com>,\n\tIgor Russkikh <Igor.Russkikh@aquantia.com>, \n\tPavel Belous <Pavel.Belous@aquantia.com>", "Thread-Topic": "[PATCH v2 4/7] net/atlantic: interrupt handling of macsec\n\tevents", "Thread-Index": "AQHU9TSZxnSHYjnTokyZqphDrMXoHA==", "Date": "Wed, 17 Apr 2019 15:45:36 +0000", "Message-ID": "<a2c84c27e9548363c1ef21ef0fe731a51eceb5e5.1555515863.git.igor.russkikh@aquantia.com>", "References": "<cover.1555515863.git.igor.russkikh@aquantia.com>", "In-Reply-To": "<cover.1555515863.git.igor.russkikh@aquantia.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "BYAPR07CA0027.namprd07.prod.outlook.com\n\t(2603:10b6:a02:bc::40) To DM6PR11MB3625.namprd11.prod.outlook.com\n\t(2603:10b6:5:13a::21)", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=Igor.Russkikh@aquantia.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-mailer": "git-send-email 2.17.1", "x-originating-ip": "[95.79.108.179]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "d15d32d7-3e7c-4b08-245b-08d6c34bbbdc", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600140)(711020)(4605104)(2017052603328)(7193020);\n\tSRVR:DM6PR11MB3738; ", "x-ms-traffictypediagnostic": "DM6PR11MB3738:", "x-microsoft-antispam-prvs": "<DM6PR11MB3738B557470B3451E6E8949098250@DM6PR11MB3738.namprd11.prod.outlook.com>", "x-forefront-prvs": "0010D93EFE", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(39850400004)(346002)(396003)(136003)(376002)(366004)(199004)(189003)(2906002)(25786009)(54906003)(14444005)(256004)(7736002)(97736004)(316002)(4326008)(71200400001)(53936002)(5640700003)(107886003)(71190400001)(99286004)(68736007)(8676002)(1730700003)(5660300002)(86362001)(2351001)(6512007)(305945005)(52116002)(6436002)(106356001)(81166006)(2501003)(36756003)(81156014)(105586002)(8936002)(6916009)(386003)(102836004)(26005)(6116002)(186003)(50226002)(72206003)(6506007)(76176011)(6486002)(14454004)(66066001)(478600001)(3846002)(476003)(118296001)(486006)(2616005)(44832011)(446003)(11346002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR11MB3738;\n\tH:DM6PR11MB3625.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: aquantia.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "2DKMkb2XmiSUtCjPv/+flaenVxKCbEYDDrOV33nyevY/eUOWb8pjeAjMG3WxknvbfElFDl0lYH9fPet3nlpkcT1/4FxjAMjReOb1JirozmoSe1XNi+g6SvBHnhMELgXj0EHPW6hwQyoDZcACNKTX3lc1pQwbbm6RYLNNCs++7Q7aHc5sUqOHc6r4pwLgyn6qe+sKniC8x8o2d/yr3ejUOtvIkLL6dwAvJ/tUy8Cy3ASf7jnPiobqlpFklvWK1Wmqi6j+etvH53s4DXmycCk77eTdVjTVjgrXgCRYZfmvF0MHow/+jW/nLNLivALUelEQFKf3UhCYQqYuXktr92YUDShK6bIZa3hLorWDw6chkPG7UBw4PeRgt8rExfex97yF3WGCu+U/Afzjm7KYR41Qii2CNRPzucueKiOCk9cTj7g=", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "MIME-Version": "1.0", "X-OriginatorOrg": "aquantia.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "d15d32d7-3e7c-4b08-245b-08d6c34bbbdc", "X-MS-Exchange-CrossTenant-originalarrivaltime": "17 Apr 2019 15:45:36.8689\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "83e2e134-991c-4ede-8ced-34d47e38e6b1", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "DM6PR11MB3738", "Subject": "[dpdk-dev] [PATCH v2 4/7] net/atlantic: interrupt handling of\n\tmacsec events", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Pavel Belous <pavel.belous@aquantia.com>\n\nMACSEC should be configured only after link up event, thus we use\nlink interrupt to file an alarm for configuration.\n\nFW also uses link interrupt line to indicate incoming events from\nMACSEC. These may include key expiration, packet counter wrap, etc.\nWe pass these events to the upper layers.\n\nSigned-off-by: Pavel Belous <pavel.belous@aquantia.com>\nSigned-off-by: Igor Russkikh <igor.russkikh@aquantia.com>\n---\n drivers/net/atlantic/atl_ethdev.c | 66 ++++++++++++++++++++++++++-----\n drivers/net/atlantic/atl_ethdev.h | 2 +-\n 2 files changed, 57 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/atlantic/atl_ethdev.c b/drivers/net/atlantic/atl_ethdev.c\r\nindex 1e91f162f6c2..dfcb3029b92f 100644\r\n--- a/drivers/net/atlantic/atl_ethdev.c\r\n+++ b/drivers/net/atlantic/atl_ethdev.c\r\n@@ -4,6 +4,7 @@\r\n \r\n #include <rte_string_fns.h>\r\n #include <rte_ethdev_pci.h>\r\n+#include <rte_alarm.h>\r\n \r\n #include \"atl_ethdev.h\"\r\n #include \"atl_common.h\"\r\n@@ -1070,13 +1071,20 @@ atl_dev_supported_ptypes_get(struct rte_eth_dev *dev)\r\n \treturn NULL;\r\n }\r\n \r\n+static void\r\n+atl_dev_delayed_handler(void *param)\r\n+{\r\n+\tstruct rte_eth_dev *dev = (struct rte_eth_dev *)param;\r\n+\r\n+\tatl_dev_configure_macsec(dev);\r\n+}\r\n+\r\n+\r\n /* return 0 means link status changed, -1 means not changed */\r\n static int\r\n atl_dev_link_update(struct rte_eth_dev *dev, int wait __rte_unused)\r\n {\r\n \tstruct aq_hw_s *hw = ATL_DEV_PRIVATE_TO_HW(dev->data->dev_private);\r\n-\tstruct atl_interrupt *intr =\r\n-\t\tATL_DEV_PRIVATE_TO_INTR(dev->data->dev_private);\r\n \tstruct rte_eth_link link, old;\r\n \tint err = 0;\r\n \r\n@@ -1103,8 +1111,6 @@ atl_dev_link_update(struct rte_eth_dev *dev, int wait __rte_unused)\r\n \t\treturn 0;\r\n \t}\r\n \r\n-\tintr->flags &= ~ATL_FLAG_NEED_LINK_CONFIG;\r\n-\r\n \tlink.link_status = ETH_LINK_UP;\r\n \tlink.link_duplex = ETH_LINK_FULL_DUPLEX;\r\n \tlink.link_speed = hw->aq_link_status.mbps;\r\n@@ -1114,6 +1120,10 @@ atl_dev_link_update(struct rte_eth_dev *dev, int wait __rte_unused)\r\n \tif (link.link_status == old.link_status)\r\n \t\treturn -1;\r\n \r\n+\tif (rte_eal_alarm_set(1000 * 1000,\r\n+\t\t\t atl_dev_delayed_handler, (void *)dev) < 0)\r\n+\t\tPMD_DRV_LOG(ERR, \"rte_eal_alarm_set fail\");\r\n+\r\n \treturn 0;\r\n }\r\n \r\n@@ -1191,8 +1201,9 @@ atl_dev_interrupt_get_status(struct rte_eth_dev *dev)\r\n \thw_atl_b0_hw_irq_read(hw, &cause);\r\n \r\n \tatl_disable_intr(hw);\r\n-\tintr->flags = cause & BIT(ATL_IRQ_CAUSE_LINK) ?\r\n-\t\t\tATL_FLAG_NEED_LINK_UPDATE : 0;\r\n+\r\n+\tif (cause & BIT(ATL_IRQ_CAUSE_LINK))\r\n+\t\tintr->flags |= ATL_FLAG_NEED_LINK_UPDATE;\r\n \r\n \treturn 0;\r\n }\r\n@@ -1257,15 +1268,50 @@ atl_dev_interrupt_action(struct rte_eth_dev *dev,\r\n {\r\n \tstruct atl_interrupt *intr =\r\n \t\tATL_DEV_PRIVATE_TO_INTR(dev->data->dev_private);\r\n+\tstruct atl_adapter *adapter =\r\n+\t\t(struct atl_adapter *)dev->data->dev_private;\r\n+\tstruct aq_hw_s *hw = &adapter->hw;\r\n+\r\n+\tif (!(intr->flags & ATL_FLAG_NEED_LINK_UPDATE))\r\n+\t\tgoto done;\r\n \r\n-\tif (intr->flags & ATL_FLAG_NEED_LINK_UPDATE) {\r\n-\t\tatl_dev_link_update(dev, 0);\r\n-\t\tintr->flags &= ~ATL_FLAG_NEED_LINK_UPDATE;\r\n+\tintr->flags &= ~ATL_FLAG_NEED_LINK_UPDATE;\r\n+\r\n+\t/* Notify userapp if link status changed */\r\n+\tif (!atl_dev_link_update(dev, 0)) {\r\n \t\tatl_dev_link_status_print(dev);\r\n \t\t_rte_eth_dev_callback_process(dev,\r\n \t\t\tRTE_ETH_EVENT_INTR_LSC, NULL);\r\n+\t} else {\r\n+\t\tif (hw->aq_fw_ops->send_macsec_req == NULL)\r\n+\t\t\tgoto done;\r\n+\r\n+\t\t/* Check macsec Keys expired */\r\n+\t\tstruct get_stats req = { 0 };\r\n+\t\tstruct macsec_msg_fw_request msg = { 0 };\r\n+\t\tstruct macsec_msg_fw_response resp = { 0 };\r\n+\r\n+\t\treq.ingress_sa_index = 0x0;\r\n+\t\treq.egress_sc_index = 0x0;\r\n+\t\treq.egress_sa_index = 0x0;\r\n+\t\tmsg.msg_type = macsec_get_stats_msg;\r\n+\t\tmsg.stats = req;\r\n+\r\n+\t\tint err = hw->aq_fw_ops->send_macsec_req(hw, &msg, &resp);\r\n+\t\tif (err) {\r\n+\t\t\tPMD_DRV_LOG(ERR, \"send_macsec_req fail\");\r\n+\t\t\tgoto done;\r\n+\t\t}\r\n+\t\tif (resp.stats.egress_threshold_expired ||\r\n+\t\t resp.stats.ingress_threshold_expired ||\r\n+\t\t resp.stats.egress_expired ||\r\n+\t\t resp.stats.ingress_expired) {\r\n+\t\t\tPMD_DRV_LOG(INFO, \"RTE_ETH_EVENT_MACSEC\");\r\n+\t\t\t_rte_eth_dev_callback_process(dev,\r\n+\t\t\t\tRTE_ETH_EVENT_MACSEC, NULL);\r\n+\t\t}\r\n \t}\r\n-\r\n+done:\r\n \tatl_enable_intr(dev);\r\n \trte_intr_enable(intr_handle);\r\n \r\ndiff --git a/drivers/net/atlantic/atl_ethdev.h b/drivers/net/atlantic/atl_ethdev.h\r\nindex b162138c59d3..f547571b5c97 100644\r\n--- a/drivers/net/atlantic/atl_ethdev.h\r\n+++ b/drivers/net/atlantic/atl_ethdev.h\r\n@@ -34,7 +34,7 @@\r\n \t(&((struct atl_adapter *)adapter)->hw_cfg)\r\n \r\n #define ATL_FLAG_NEED_LINK_UPDATE (uint32_t)(1 << 0)\r\n-#define ATL_FLAG_NEED_LINK_CONFIG (uint32_t)(4 << 0)\r\n+#define ATL_FLAG_MACSEC (uint32_t)(4 << 0)\r\n \r\n struct atl_interrupt {\r\n \tuint32_t flags;\r\n", "prefixes": [ "v2", "4/7" ] }