Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 5282,
    "url": "http://patches.dpdk.org/api/patches/5282/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/1433760090-17110-2-git-send-email-konstantin.ananyev@intel.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1433760090-17110-2-git-send-email-konstantin.ananyev@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1433760090-17110-2-git-send-email-konstantin.ananyev@intel.com",
    "date": "2015-06-08T10:41:23",
    "name": "[dpdk-dev,PATCHv2,1/8] acl: fix invalid rule wildness calculation for bitmask field type",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "db36c2db8a08bdcc693180ed670a6ad624719fa3",
    "submitter": {
        "id": 33,
        "url": "http://patches.dpdk.org/api/people/33/?format=api",
        "name": "Ananyev, Konstantin",
        "email": "konstantin.ananyev@intel.com"
    },
    "delegate": null,
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/1433760090-17110-2-git-send-email-konstantin.ananyev@intel.com/mbox/",
    "series": [],
    "comments": "http://patches.dpdk.org/api/patches/5282/comments/",
    "check": "pending",
    "checks": "http://patches.dpdk.org/api/patches/5282/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id C499B5A50;\n\tMon,  8 Jun 2015 12:43:56 +0200 (CEST)",
            "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id E139ADE0\n\tfor <dev@dpdk.org>; Mon,  8 Jun 2015 12:43:53 +0200 (CEST)",
            "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby fmsmga103.fm.intel.com with ESMTP; 08 Jun 2015 03:41:38 -0700",
            "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga002.jf.intel.com with ESMTP; 08 Jun 2015 03:41:37 -0700",
            "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\n\t[10.237.217.46])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tt58AfajB029627; Mon, 8 Jun 2015 11:41:36 +0100",
            "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev02.ir.intel.com with ESMTP id t58AfaMX017551;\n\tMon, 8 Jun 2015 11:41:36 +0100",
            "(from kananye1@localhost)\n\tby sivswdev02.ir.intel.com with  id t58AfacF017547;\n\tMon, 8 Jun 2015 11:41:36 +0100"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.13,573,1427785200\"; d=\"scan'208\";a=\"742911381\"",
        "From": "Konstantin Ananyev <konstantin.ananyev@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Mon,  8 Jun 2015 11:41:23 +0100",
        "Message-Id": "<1433760090-17110-2-git-send-email-konstantin.ananyev@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "In-Reply-To": "<1433760090-17110-1-git-send-email-konstantin.ananyev@intel.com>",
        "References": "<1433373024-5558-2-git-send-email-konstantin.ananyev@intel.com>\n\t<1433760090-17110-1-git-send-email-konstantin.ananyev@intel.com>",
        "Subject": "[dpdk-dev] [PATCHv2 1/8] acl: fix invalid rule wildness calculation\n\tfor bitmask field type",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Signed-off-by: Konstantin Ananyev <konstantin.ananyev@intel.com>\n---\n lib/librte_acl/acl_bld.c | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/lib/librte_acl/acl_bld.c b/lib/librte_acl/acl_bld.c\nindex 3801843..aee6ed5 100644\n--- a/lib/librte_acl/acl_bld.c\n+++ b/lib/librte_acl/acl_bld.c\n@@ -1362,6 +1362,9 @@ acl_calc_wildness(struct rte_acl_build_rule *head,\n \t\tfor (n = 0; n < config->num_fields; n++) {\n \n \t\t\tdouble wild = 0;\n+\t\t\tuint64_t msk_val =\n+\t\t\t\tRTE_LEN2MASK(CHAR_BIT * config->defs[n].size,\n+\t\t\t\ttypeof(msk_val));\n \t\t\tdouble size = CHAR_BIT * config->defs[n].size;\n \t\t\tint field_index = config->defs[n].field_index;\n \t\t\tconst struct rte_acl_field *fld = rule->f->field +\n@@ -1369,8 +1372,8 @@ acl_calc_wildness(struct rte_acl_build_rule *head,\n \n \t\t\tswitch (rule->config->defs[n].type) {\n \t\t\tcase RTE_ACL_FIELD_TYPE_BITMASK:\n-\t\t\t\twild = (size - __builtin_popcount(\n-\t\t\t\t\tfld->mask_range.u8)) /\n+\t\t\t\twild = (size - __builtin_popcountll(\n+\t\t\t\t\tfld->mask_range.u64 & msk_val)) /\n \t\t\t\t\tsize;\n \t\t\t\tbreak;\n \n",
    "prefixes": [
        "dpdk-dev",
        "PATCHv2",
        "1/8"
    ]
}