Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 52748,
    "url": "http://patches.dpdk.org/api/patches/52748/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190413190121.15416-2-jerinj@marvell.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190413190121.15416-2-jerinj@marvell.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190413190121.15416-2-jerinj@marvell.com",
    "date": "2019-04-13T19:01:19",
    "name": "[v9,2/4] meson: add infra to support machine specific flags",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "fdaf67380659e1bf888d4e12b16bb39a34ef18d8",
    "submitter": {
        "id": 1188,
        "url": "http://patches.dpdk.org/api/people/1188/?format=api",
        "name": "Jerin Jacob Kollanukkaran",
        "email": "jerinj@marvell.com"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190413190121.15416-2-jerinj@marvell.com/mbox/",
    "series": [
        {
            "id": 4300,
            "url": "http://patches.dpdk.org/api/series/4300/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4300",
            "date": "2019-04-13T19:01:18",
            "name": "[v9,1/4] mk: introduce helper to check valid compiler argument",
            "version": 9,
            "mbox": "http://patches.dpdk.org/series/4300/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/52748/comments/",
    "check": "warning",
    "checks": "http://patches.dpdk.org/api/patches/52748/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 538571B113;\n\tSat, 13 Apr 2019 21:01:48 +0200 (CEST)",
            "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n\t[67.231.156.173]) by dpdk.org (Postfix) with ESMTP id F221F1B113\n\tfor <dev@dpdk.org>; Sat, 13 Apr 2019 21:01:45 +0200 (CEST)",
            "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n\tby mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id\n\tx3DJ03Ib013832; Sat, 13 Apr 2019 12:01:45 -0700",
            "from sc-exch04.marvell.com ([199.233.58.184])\n\tby mx0b-0016f401.pphosted.com with ESMTP id 2ruf9jrtjs-1\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); \n\tSat, 13 Apr 2019 12:01:45 -0700",
            "from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH04.marvell.com\n\t(10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3;\n\tSat, 13 Apr 2019 12:01:43 -0700",
            "from maili.marvell.com (10.93.176.43) by SC-EXCH01.marvell.com\n\t(10.93.176.81) with Microsoft SMTP Server id 15.0.1367.3 via Frontend\n\tTransport; Sat, 13 Apr 2019 12:01:43 -0700",
            "from jerin-lab.marvell.com (unknown [10.28.34.14])\n\tby maili.marvell.com (Postfix) with ESMTP id DAD1A3F703F;\n\tSat, 13 Apr 2019 12:01:41 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n\th=from : to : cc :\n\tsubject : date : message-id : in-reply-to : references : mime-version\n\t: content-transfer-encoding : content-type; s=pfpt0818;\n\tbh=l1t7FD4KeBpw0l452weo/JoqiLxqvJFSCdubOE6CD+g=;\n\tb=aISDI/qvURu0c6R20hgLgvvwaNNVvxCN+TixwezZCrUEPUaOqEpghhM8gkUdU+oe9jXP\n\thIwJthFNznhSiw3e+4s9dICPwgwG2WlMSfboelDu26B8s/UGx5NCbH7XTna4Z71b52ys\n\tjIA5e+t/TYklkAK4LJH860heYeANfEut7gf8F/TZsxbFfVFNRYc+VhhMdHnM7J/KEUlM\n\tTJDTogegITd1RZe3m5G/yxBfncU1ib8wDcwyVSmAUQ+JcjVfUWoqQUya2lac2hNSD6Ef\n\trRTcCmKgwP74cOk9KIEIbZFqXUhmbqcNccHI0/TuRI+G6sLjMki3HI0JkngUopNvm8Me\n\tpg== ",
        "From": "<jerinj@marvell.com>",
        "To": "<dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>",
        "CC": "<yskoh@mellanox.com>, Pavan Nikhilesh <pbhagavatula@marvell.com>, \"Jerin\n\tJacob\" <jerinj@marvell.com>",
        "Date": "Sun, 14 Apr 2019 00:31:19 +0530",
        "Message-ID": "<20190413190121.15416-2-jerinj@marvell.com>",
        "X-Mailer": "git-send-email 2.21.0",
        "In-Reply-To": "<20190413190121.15416-1-jerinj@marvell.com>",
        "References": "<20190410161400.9361-1-jerinj@marvell.com>\n\t<20190413190121.15416-1-jerinj@marvell.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Proofpoint-Virus-Version": "vendor=fsecure engine=2.50.10434:, ,\n\tdefinitions=2019-04-13_06:, , signatures=0",
        "Subject": "[dpdk-dev] [PATCH v9 2/4] meson: add infra to support machine\n\tspecific flags",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "From: Pavan Nikhilesh <pbhagavatula@marvell.com>\n\nCurrently, RTE_* flags are set based on the implementer ID but there might\nbe some micro arch specific differences from the same vendor\neg. CACHE_LINESIZE. Add support to set micro arch specific flags.\n\nSigned-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>\nSigned-off-by: Jerin Jacob <jerinj@marvell.com>\n---\n config/arm/meson.build | 67 +++++++++++++++++++++---------------------\n 1 file changed, 33 insertions(+), 34 deletions(-)",
    "diff": "diff --git a/config/arm/meson.build b/config/arm/meson.build\nindex 170a4981a..d30a17426 100644\n--- a/config/arm/meson.build\n+++ b/config/arm/meson.build\n@@ -7,25 +7,6 @@ march_opt = '-march=@0@'.format(machine)\n \n arm_force_native_march = false\n \n-machine_args_generic = [\n-\t['default', ['-march=armv8-a+crc+crypto']],\n-\t['native', ['-march=native']],\n-\t['0xd03', ['-mcpu=cortex-a53']],\n-\t['0xd04', ['-mcpu=cortex-a35']],\n-\t['0xd05', ['-mcpu=cortex-a55']],\n-\t['0xd07', ['-mcpu=cortex-a57']],\n-\t['0xd08', ['-mcpu=cortex-a72']],\n-\t['0xd09', ['-mcpu=cortex-a73']],\n-\t['0xd0a', ['-mcpu=cortex-a75']],\n-\t['0xd0b', ['-mcpu=cortex-a76']],\n-]\n-machine_args_cavium = [\n-\t['default', ['-march=armv8-a+crc+crypto','-mcpu=thunderx']],\n-\t['native', ['-march=native']],\n-\t['0xa1', ['-mcpu=thunderxt88']],\n-\t['0xa2', ['-mcpu=thunderxt81']],\n-\t['0xa3', ['-mcpu=thunderxt83']]]\n-\n flags_common_default = [\n \t# Accelarate rte_memcpy. Be sure to run unit test (memcpy_perf_autotest)\n \t# to determine the best threshold in code. Refer to notes in source file\n@@ -52,12 +33,10 @@ flags_generic = [\n \t['RTE_USE_C11_MEM_MODEL', true],\n \t['RTE_CACHE_LINE_SIZE', 128]]\n flags_cavium = [\n-\t['RTE_MACHINE', '\"thunderx\"'],\n \t['RTE_CACHE_LINE_SIZE', 128],\n \t['RTE_MAX_NUMA_NODES', 2],\n \t['RTE_MAX_LCORE', 96],\n-\t['RTE_MAX_VFIO_GROUPS', 128],\n-\t['RTE_USE_C11_MEM_MODEL', false]]\n+\t['RTE_MAX_VFIO_GROUPS', 128]]\n flags_dpaa = [\n \t['RTE_MACHINE', '\"dpaa\"'],\n \t['RTE_USE_C11_MEM_MODEL', true],\n@@ -71,6 +50,27 @@ flags_dpaa2 = [\n \t['RTE_MAX_NUMA_NODES', 1],\n \t['RTE_MAX_LCORE', 16],\n \t['RTE_LIBRTE_DPAA2_USE_PHYS_IOVA', false]]\n+flags_default_extra = []\n+flags_thunderx_extra = [\n+\t['RTE_MACHINE', '\"thunderx\"'],\n+\t['RTE_USE_C11_MEM_MODEL', false]]\n+\n+machine_args_generic = [\n+\t['default', ['-march=armv8-a+crc+crypto']],\n+\t['native', ['-march=native']],\n+\t['0xd03', ['-mcpu=cortex-a53']],\n+\t['0xd04', ['-mcpu=cortex-a35']],\n+\t['0xd07', ['-mcpu=cortex-a57']],\n+\t['0xd08', ['-mcpu=cortex-a72']],\n+\t['0xd09', ['-mcpu=cortex-a73']],\n+\t['0xd0a', ['-mcpu=cortex-a75']]]\n+\n+machine_args_cavium = [\n+\t['default', ['-march=armv8-a+crc+crypto','-mcpu=thunderx']],\n+\t['native', ['-march=native']],\n+\t['0xa1', ['-mcpu=thunderxt88'], flags_thunderx_extra],\n+\t['0xa2', ['-mcpu=thunderxt81'], flags_thunderx_extra],\n+\t['0xa3', ['-mcpu=thunderxt83'], flags_thunderx_extra]]\n \n ## Arm implementer ID (ARM DDI 0487C.a, Section G7.2.106, Page G7-5321)\n impl_generic = ['Generic armv8', flags_generic, machine_args_generic]\n@@ -145,20 +145,19 @@ else\n \t\t\tdpdk_conf.set(flag[0], flag[1])\n \t\tendif\n \tendforeach\n-\t# Primary part number based mcpu flags are supported\n-\t# for gcc versions > 7\n-\tif cc.version().version_compare(\n-\t\t\t'<7.0') or cmd_output.length() == 0\n-\t\tif not meson.is_cross_build() and arm_force_native_march == true\n-\t\t\timpl_pn = 'native'\n-\t\telse\n-\t\t\timpl_pn = 'default'\n-\t\tendif\n-\tendif\n+\t\n \tforeach marg: machine[2]\n \t\tif marg[0] == impl_pn\n-\t\t\tforeach f: marg[1]\n-\t\t\t\tmachine_args += f\n+\t\t\tforeach flag: marg[1]\n+\t\t\t\tif cc.has_argument(flag)\n+\t\t\t\t\tmachine_args += flag\n+\t\t\t\tendif\n+\t\t\tendforeach\n+\t\t\t# Apply any extra machine specific flags.\n+\t\t\tforeach flag: marg.get(2, flags_default_extra)\n+\t\t\t\tif flag.length() > 0\n+\t\t\t\t\tdpdk_conf.set(flag[0], flag[1])\n+\t\t\t\tendif\n \t\t\tendforeach\n \t\tendif\n \tendforeach\n",
    "prefixes": [
        "v9",
        "2/4"
    ]
}