Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52737/?format=api
{ "id": 52737, "url": "http://patches.dpdk.org/api/patches/52737/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190412232451.30197-4-yskoh@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190412232451.30197-4-yskoh@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190412232451.30197-4-yskoh@mellanox.com", "date": "2019-04-12T23:24:48", "name": "[3/6] net/mlx: fix library search in meson build", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "16bd3aa4c0ce3a130d27e3e3f39fe68eccedbbbc", "submitter": { "id": 636, "url": "http://patches.dpdk.org/api/people/636/?format=api", "name": "Yongseok Koh", "email": "yskoh@mellanox.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190412232451.30197-4-yskoh@mellanox.com/mbox/", "series": [ { "id": 4296, "url": "http://patches.dpdk.org/api/series/4296/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4296", "date": "2019-04-12T23:24:45", "name": "build: fix build for arm64", "version": 1, "mbox": "http://patches.dpdk.org/series/4296/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/52737/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/52737/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 593A61B40F;\n\tSat, 13 Apr 2019 01:25:09 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id 7817F1B3F0\n\tfor <dev@dpdk.org>; Sat, 13 Apr 2019 01:25:07 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n\tyskoh@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 13 Apr 2019 02:25:05 +0300", "from mtibiz05-l.mti.labs.mlnx. (mtibiz05-l.mti.labs.mlnx\n\t[10.20.10.109])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x3CNOrWI006596;\n\tSat, 13 Apr 2019 02:25:02 +0300" ], "From": "Yongseok Koh <yskoh@mellanox.com>", "To": "bruce.richardson@intel.com, jerinj@marvell.com, pbhagavatula@marvell.com,\n\tshahafs@mellanox.com", "Cc": "dev@dpdk.org, thomas@monjalon.net, gavin.hu@arm.com,\n\tHonnappa.Nagarahalli@arm.com, bluca@debian.org, stable@dpdk.org", "Date": "Fri, 12 Apr 2019 16:24:48 -0700", "Message-Id": "<20190412232451.30197-4-yskoh@mellanox.com>", "X-Mailer": "git-send-email 2.21.0.196.g041f5ea", "In-Reply-To": "<20190412232451.30197-1-yskoh@mellanox.com>", "References": "<20190412232451.30197-1-yskoh@mellanox.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 3/6] net/mlx: fix library search in meson build", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If MLNX_OFED is installed, there's no .pc file installed for libraries and\ndependency() can't find libraries by pkg-config. By adding fallback of\nusing cc.find_library(), libraries are properly located.\n\nFixes: e30b4e566f47 (\"build: improve dependency handling\")\nCc: bluca@debian.org\nCc: stable@dpdk.org\n\nSigned-off-by: Yongseok Koh <yskoh@mellanox.com>\n---\n drivers/net/mlx4/meson.build | 19 +++++++++++--------\n drivers/net/mlx5/meson.build | 19 +++++++++++--------\n 2 files changed, 22 insertions(+), 16 deletions(-)", "diff": "diff --git a/drivers/net/mlx4/meson.build b/drivers/net/mlx4/meson.build\nindex de020701d1..9082f69f25 100644\n--- a/drivers/net/mlx4/meson.build\n+++ b/drivers/net/mlx4/meson.build\n@@ -13,21 +13,24 @@ if pmd_dlopen\n \t\t'-DMLX4_GLUE_VERSION=\"@0@\"'.format(LIB_GLUE_VERSION),\n \t]\n endif\n-libs = [\n-\tdependency('libmnl', required:false),\n-\tdependency('libmlx4', required:false),\n-\tdependency('libibverbs', required:false),\n-]\n+libs = [ 'libmnl', 'libmlx4', 'libibverbs' ]\n+lib_deps = []\n build = true\n foreach lib:libs\n-\tif not lib.found()\n+\tlib_dep = dependency(lib, required:false)\n+\tif not lib_dep.found()\n+\t\tlib_dep = cc.find_library(lib, required:false)\n+\tendif\n+\tif lib_dep.found()\n+\t\tlib_deps += [ lib_dep ]\n+\telse\n \t\tbuild = false\n \tendif\n endforeach\n # Compile PMD\n if build\n \tallow_experimental_apis = true\n-\text_deps += libs\n+\text_deps += lib_deps\n \tsources = files(\n \t\t'mlx4.c',\n \t\t'mlx4_ethdev.c',\n@@ -103,7 +106,7 @@ if pmd_dlopen and build\n \t\tdlopen_sources,\n \t\tinclude_directories: global_inc,\n \t\tc_args: cflags,\n-\t\tdependencies: libs,\n+\t\tdependencies: libs_deps,\n \t\tlink_args: [\n \t\t'-Wl,-export-dynamic',\n \t\t'-Wl,-h,@0@'.format(LIB_GLUE),\ndiff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build\nindex a4c684e1b5..42701c51de 100644\n--- a/drivers/net/mlx5/meson.build\n+++ b/drivers/net/mlx5/meson.build\n@@ -13,20 +13,23 @@ if pmd_dlopen\n \t\t'-DMLX5_GLUE_VERSION=\"@0@\"'.format(LIB_GLUE_VERSION),\n \t]\n endif\n-libs = [\n-\tdependency('libmnl', required:false),\n-\tdependency('libmlx5', required:false),\n-\tdependency('libibverbs', required:false),\n-]\n+libs = [ 'libmnl', 'libmlx5', 'libibverbs' ]\n+lib_deps = []\n build = true\n foreach lib:libs\n-\tif not lib.found()\n+\tlib_dep = dependency(lib, required:false)\n+\tif not lib_dep.found()\n+\t\tlib_dep = cc.find_library(lib, required:false)\n+\tendif\n+\tif lib_dep.found()\n+\t\tlib_deps += [ lib_dep ]\n+\telse\n \t\tbuild = false\n \tendif\n endforeach\n if build\n \tallow_experimental_apis = true\n-\text_deps += libs\n+\text_deps += lib_deps\n \tsources = files(\n \t\t'mlx5.c',\n \t\t'mlx5_ethdev.c',\n@@ -299,7 +302,7 @@ if pmd_dlopen and build\n \t\tdlopen_sources,\n \t\tinclude_directories: global_inc,\n \t\tc_args: cflags,\n-\t\tdependencies: libs,\n+\t\tdependencies: lib_deps,\n \t\tlink_args: [\n \t\t'-Wl,-export-dynamic',\n \t\t'-Wl,-h,@0@'.format(LIB_GLUE),\n", "prefixes": [ "3/6" ] }