Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52730/?format=api
{ "id": 52730, "url": "http://patches.dpdk.org/api/patches/52730/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190412162141.23327-4-aconole@redhat.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190412162141.23327-4-aconole@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190412162141.23327-4-aconole@redhat.com", "date": "2019-04-12T16:21:41", "name": "[v2,3/3] app/test/meson: auto detect number of cores", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ebb70c4c5f8e7db64f646db5ba6bf8b00d0e3b6e", "submitter": { "id": 332, "url": "http://patches.dpdk.org/api/people/332/?format=api", "name": "Aaron Conole", "email": "aconole@redhat.com" }, "delegate": null, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190412162141.23327-4-aconole@redhat.com/mbox/", "series": [ { "id": 4294, "url": "http://patches.dpdk.org/api/series/4294/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4294", "date": "2019-04-12T16:21:38", "name": "travis: enhancements for build (plus a meson fix)", "version": 2, "mbox": "http://patches.dpdk.org/series/4294/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/52730/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/52730/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 039691B3A3;\n\tFri, 12 Apr 2019 18:22:04 +0200 (CEST)", "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id B99C51B293\n\tfor <dev@dpdk.org>; Fri, 12 Apr 2019 18:21:52 +0200 (CEST)", "from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])\n\t(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n\t(No client certificate requested)\n\tby mx1.redhat.com (Postfix) with ESMTPS id EE0C88666D;\n\tFri, 12 Apr 2019 16:21:51 +0000 (UTC)", "from dhcp-25.97.bos.redhat.com (ovpn-122-94.rdu2.redhat.com\n\t[10.10.122.94])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 3C1AD5D6A9;\n\tFri, 12 Apr 2019 16:21:51 +0000 (UTC)" ], "From": "Aaron Conole <aconole@redhat.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n\tLuca Boccassi <bluca@debian.org>,\n\tReshma Pattan <reshma.pattan@intel.com>, \n\tAgalya Babu RadhaKrishnan <agalyax.babu.radhakrishnan@intel.com>,\n\tDavid Marchand <dmarchan@redhat.com>", "Date": "Fri, 12 Apr 2019 12:21:41 -0400", "Message-Id": "<20190412162141.23327-4-aconole@redhat.com>", "In-Reply-To": "<20190412162141.23327-1-aconole@redhat.com>", "References": "<20190411195229.7841-1-aconole@redhat.com>\n\t<20190412162141.23327-1-aconole@redhat.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Scanned-By": "MIMEDefang 2.79 on 10.5.11.15", "X-Greylist": "Sender IP whitelisted, not delayed by milter-greylist-4.5.16\n\t(mx1.redhat.com [10.5.110.26]); Fri, 12 Apr 2019 16:21:52 +0000 (UTC)", "Subject": "[dpdk-dev] [PATCH v2 3/3] app/test/meson: auto detect number of\n\tcores", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The arguments being passed will cause failures on laptops that have,\nfor instance, 2 cores only. Most of the tests don't require more\nthan a single core. Some require multiple cores (but those tests\nshould be modified to 'SKIP' when the correct number of cores\naren't available).\n\nThe unit test results shouldn't be impacted by this change, but it\nallows for a future enhancement to pass flags such as '--no-huge'.\n\nAlso include a fix to a reported issue with running on FreeBSD.\n\nSigned-off-by: Aaron Conole <aconole@redhat.com>\nReviewed-by: David Marchand <david.marchand@redhat.com>\nAcked-by: Luca Boccassi <bluca@debian.org>\n---\nv2:\n* Fix a spelling mistake\n* Add support for FreeBSD\n* Include a default fallback\n* Use a more robust core-mask argument source (rather than lscpu)\n\nConflicts with http://patches.dpdk.org/patch/50850/\n\n app/test/meson.build | 35 ++++++++++++++++++++++++++++++++---\n 1 file changed, 32 insertions(+), 3 deletions(-)", "diff": "diff --git a/app/test/meson.build b/app/test/meson.build\nindex 867cc5863..5e056eb59 100644\n--- a/app/test/meson.build\n+++ b/app/test/meson.build\n@@ -344,17 +344,43 @@ if get_option('tests')\n \ttimeout_seconds = 600\n \ttimeout_seconds_fast = 10\n \n+\t# Retrieve the number of CPU cores, defaulting to 4.\n+\tnum_cores = '0-3'\n+\tif host_machine.system() == 'linux'\n+\t\tnum_cores = run_command('cat',\n+\t\t\t\t\t'/sys/devices/system/cpu/present'\n+\t\t\t\t ).stdout().strip()\n+\telif host_machine.system() == 'freebsd'\n+\t\tsnum_cores = run_command('/sbin/sysctl', '-n',\n+\t\t\t\t\t 'hw.ncpu').stdout().strip()\n+\t\tinum_cores = snum_cores.to_int() - 1\n+ num_cores = '0-@0@'.format(inum_cores)\n+\tendif\n+\n+\tnum_cores_arg = '-l ' + num_cores\n+\n+\ttest_args = [num_cores_arg, '-n 4']\n \tforeach arg : fast_parallel_test_names\n-\t\ttest(arg, dpdk_test,\n-\t\t\tenv : ['DPDK_TEST=' + arg],\n-\t\t\targs : ['-c f','-n 4', '--file-prefix=@0@'.format(arg)],\n+\t\tif host_machine.system() == 'linux'\n+\t\t\ttest(arg, dpdk_test,\n+\t\t\t\t env : ['DPDK_TEST=' + arg],\n+\t\t\t\t args : test_args +\n+\t\t\t\t\t ['--file-prefix=@0@'.format(arg)],\n+\t\t\ttimeout : timeout_seconds_fast,\n+\t\t\tsuite : 'fast-tests')\n+\t\telse\n+\t\t\ttest(arg, dpdk_test,\n+\t\t\t\tenv : ['DPDK_TEST=' + arg],\n+\t\t\t\targs : test_args,\n \t\t\ttimeout : timeout_seconds_fast,\n \t\t\tsuite : 'fast-tests')\n+\t\tendif\n \tendforeach\n \n \tforeach arg : fast_non_parallel_test_names\n \t\ttest(arg, dpdk_test,\n \t\t\tenv : ['DPDK_TEST=' + arg],\n+\t\t\targs : test_args,\n \t\t\ttimeout : timeout_seconds_fast,\n \t\t\tis_parallel : false,\n \t\t\tsuite : 'fast-tests')\n@@ -363,6 +389,7 @@ if get_option('tests')\n \tforeach arg : perf_test_names\n \t\ttest(arg, dpdk_test,\n \t\tenv : ['DPDK_TEST=' + arg],\n+\t\targs : test_args,\n \t\ttimeout : timeout_seconds,\n \t\tis_parallel : false,\n \t\tsuite : 'perf-tests')\n@@ -371,6 +398,7 @@ if get_option('tests')\n \tforeach arg : driver_test_names\n \t\ttest(arg, dpdk_test,\n \t\t\tenv : ['DPDK_TEST=' + arg],\n+\t\t\targs : test_args,\n \t\t\ttimeout : timeout_seconds,\n \t\t\tis_parallel : false,\n \t\t\tsuite : 'driver-tests')\n@@ -379,6 +407,7 @@ if get_option('tests')\n \tforeach arg : dump_test_names\n \t\ttest(arg, dpdk_test,\n \t\t\tenv : ['DPDK_TEST=' + arg],\n+\t\t\targs : test_args,\n \t\t\ttimeout : timeout_seconds,\n \t\t\tis_parallel : false,\n \t\t\tsuite : 'debug-tests')\n", "prefixes": [ "v2", "3/3" ] }