Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52722/?format=api
{ "id": 52722, "url": "http://patches.dpdk.org/api/patches/52722/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1555083927-24499-1-git-send-email-viacheslavo@mellanox.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1555083927-24499-1-git-send-email-viacheslavo@mellanox.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1555083927-24499-1-git-send-email-viacheslavo@mellanox.com", "date": "2019-04-12T15:45:27", "name": "[1/1] net/mlx5: fix memory region cleanup routine", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "abb037ef5f9b16592dd9aae427b73675dfa032a3", "submitter": { "id": 1102, "url": "http://patches.dpdk.org/api/people/1102/?format=api", "name": "Slava Ovsiienko", "email": "viacheslavo@mellanox.com" }, "delegate": { "id": 6624, "url": "http://patches.dpdk.org/api/users/6624/?format=api", "username": "shahafs", "first_name": "Shahaf", "last_name": "Shuler", "email": "shahafs@mellanox.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1555083927-24499-1-git-send-email-viacheslavo@mellanox.com/mbox/", "series": [ { "id": 4289, "url": "http://patches.dpdk.org/api/series/4289/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4289", "date": "2019-04-12T15:45:27", "name": "[1/1] net/mlx5: fix memory region cleanup routine", "version": 1, "mbox": "http://patches.dpdk.org/series/4289/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/52722/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/52722/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C76091B209;\n\tFri, 12 Apr 2019 17:45:37 +0200 (CEST)", "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id 6B6101B209\n\tfor <dev@dpdk.org>; Fri, 12 Apr 2019 17:45:35 +0200 (CEST)", "from Internal Mail-Server by MTLPINE1 (envelope-from\n\tviacheslavo@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 12 Apr 2019 18:45:34 +0300", "from pegasus12.mtr.labs.mlnx. (pegasus12.mtr.labs.mlnx\n\t[10.210.17.40])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x3CFjYgV011494;\n\tFri, 12 Apr 2019 18:45:34 +0300" ], "From": "Viacheslav Ovsiienko <viacheslavo@mellanox.com>", "To": "dev@dpdk.org", "Cc": "shahafs@mellanox.com, stable@dpdk.org", "Date": "Fri, 12 Apr 2019 15:45:27 +0000", "Message-Id": "<1555083927-24499-1-git-send-email-viacheslavo@mellanox.com>", "X-Mailer": "git-send-email 1.8.3.1", "Subject": "[dpdk-dev] [PATCH 1/1] net/mlx5: fix memory region cleanup routine", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "mlx5 driver has a global list of Memory Regions created by\ndevice, and there is a ml5_mr_release() routine which makes\na memory cleanup at device closing. The head of device MR list\nwas fetched outside the rwlock protected section. Also some\nnoticed typos are fixed.\n\nFixes: 974f1e7ef146 (\"net/mlx5: add new memory region support\")\nCc: stable@dpdk.org\n\nSigned-off-by: Viacheslav Ovsiienko <viacheslavo@mellanox.com>\n---\n drivers/net/mlx5/mlx5_mr.c | 13 +++++++------\n 1 file changed, 7 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_mr.c b/drivers/net/mlx5/mlx5_mr.c\nindex 44b6591..a3732d4 100644\n--- a/drivers/net/mlx5/mlx5_mr.c\n+++ b/drivers/net/mlx5/mlx5_mr.c\n@@ -466,7 +466,7 @@ struct mr_update_mp_data {\n }\n \n /**\n- * Releass resources of detached MR having no online entry.\n+ * Release resources of detached MR having no online entry.\n *\n * @param dev\n * Pointer to Ethernet device.\n@@ -516,7 +516,7 @@ struct mr_update_mp_data {\n }\n \n /**\n- * Create a new global Memroy Region (MR) for a missing virtual address.\n+ * Create a new global Memory Region (MR) for a missing virtual address.\n * This API should be called on a secondary process, then a request is sent to\n * the primary process in order to create a MR for the address. As the global MR\n * list is on the shared memory, following LKey lookup should succeed unless the\n@@ -562,7 +562,7 @@ struct mr_update_mp_data {\n }\n \n /**\n- * Create a new global Memroy Region (MR) for a missing virtual address.\n+ * Create a new global Memory Region (MR) for a missing virtual address.\n * Register entire virtually contiguous memory chunk around the address.\n * This must be called from the primary process.\n *\n@@ -673,7 +673,7 @@ struct mr_update_mp_data {\n \tbmp_mem = RTE_PTR_ALIGN_CEIL(mr + 1, RTE_CACHE_LINE_SIZE);\n \tmr->ms_bmp = rte_bitmap_init(ms_n, bmp_mem, bmp_size);\n \tif (mr->ms_bmp == NULL) {\n-\t\tDEBUG(\"port %u unable to initialize bitamp for a new MR of\"\n+\t\tDEBUG(\"port %u unable to initialize bitmap for a new MR of\"\n \t\t \" address (%p).\",\n \t\t dev->data->port_id, (void *)addr);\n \t\trte_errno = EINVAL;\n@@ -811,7 +811,7 @@ struct mr_update_mp_data {\n }\n \n /**\n- * Create a new global Memroy Region (MR) for a missing virtual address.\n+ * Create a new global Memory Region (MR) for a missing virtual address.\n * This can be called from primary and secondary process.\n *\n * @param dev\n@@ -1600,7 +1600,7 @@ struct mr_update_mp_data {\n mlx5_mr_release(struct rte_eth_dev *dev)\n {\n \tstruct mlx5_priv *priv = dev->data->dev_private;\n-\tstruct mlx5_mr *mr_next = LIST_FIRST(&priv->mr.mr_list);\n+\tstruct mlx5_mr *mr_next;\n \n \t/* Remove from memory callback device list. */\n \trte_rwlock_write_lock(&mlx5_shared_data->mem_event_rwlock);\n@@ -1610,6 +1610,7 @@ struct mr_update_mp_data {\n \t\tmlx5_mr_dump_dev(dev);\n \trte_rwlock_write_lock(&priv->mr.rwlock);\n \t/* Detach from MR list and move to free list. */\n+\tmr_next = LIST_FIRST(&priv->mr.mr_list);\n \twhile (mr_next != NULL) {\n \t\tstruct mlx5_mr *mr = mr_next;\n \n", "prefixes": [ "1/1" ] }