Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52716/?format=api
http://patches.dpdk.org/api/patches/52716/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1555077139-244831-3-git-send-email-ying.a.wang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1555077139-244831-3-git-send-email-ying.a.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1555077139-244831-3-git-send-email-ying.a.wang@intel.com", "date": "2019-04-12T13:52:19", "name": "[2/2] net/ice: fix promiscuous mode", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "aef5b2a5359384b792db5e737bdad2aab6450dfe", "submitter": { "id": 1280, "url": "http://patches.dpdk.org/api/people/1280/?format=api", "name": "Ying Wang", "email": "ying.a.wang@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1555077139-244831-3-git-send-email-ying.a.wang@intel.com/mbox/", "series": [ { "id": 4284, "url": "http://patches.dpdk.org/api/series/4284/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4284", "date": "2019-04-12T13:52:17", "name": "ice: code clean and promisc mode fix", "version": 1, "mbox": "http://patches.dpdk.org/series/4284/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/52716/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/52716/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9346F1B1EE;\n\tFri, 12 Apr 2019 16:03:46 +0200 (CEST)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id A78F01B1E8;\n\tFri, 12 Apr 2019 16:03:44 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t12 Apr 2019 07:03:43 -0700", "from unknown (HELO npg-dpdk-cvl-yingwang-117d94.sh.intel.com)\n\t([10.67.117.94])\n\tby orsmga008.jf.intel.com with ESMTP; 12 Apr 2019 07:03:42 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,341,1549958400\"; d=\"scan'208\";a=\"133735459\"", "From": "Wang Ying A <ying.a.wang@intel.com>", "To": "wenzhuo.lu@intel.com,\n\tqiming.yang@intel.com", "Cc": "dev@dpdk.org,\n\tWang Ying A <ying.a.wang@intel.com>,\n\tstable@dpdk.org", "Date": "Fri, 12 Apr 2019 21:52:19 +0800", "Message-Id": "<1555077139-244831-3-git-send-email-ying.a.wang@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1555077139-244831-1-git-send-email-ying.a.wang@intel.com>", "References": "<1555077139-244831-1-git-send-email-ying.a.wang@intel.com>", "Subject": "[dpdk-dev] [PATCH 2/2] net/ice: fix promiscuous mode", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "When device promiscuous mode has already been enabled,\nif user re-enables the promisc mode, he/she should be\nprompted with \"Promisc has already been enabled\"\nrather than \"Failed to enable promisc\".\n\nFixes: c945e4bf9063 (\"net/ice: support promiscuous mode\")\nCc: stable@dpdk.org\n\nSigned-off-by: Wang Ying A <ying.a.wang@intel.com>\n---\n drivers/net/ice/ice_ethdev.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c\nindex 72831bb..cb82a6f 100644\n--- a/drivers/net/ice/ice_ethdev.c\n+++ b/drivers/net/ice/ice_ethdev.c\n@@ -2759,7 +2759,9 @@ static int ice_macaddr_set(struct rte_eth_dev *dev,\n \t\tICE_PROMISC_MCAST_RX | ICE_PROMISC_MCAST_TX;\n \n \tstatus = ice_set_vsi_promisc(hw, vsi->idx, pmask, 0);\n-\tif (status != ICE_SUCCESS)\n+\tif (status == ICE_ERR_ALREADY_EXISTS)\n+\t\tPMD_DRV_LOG(DEBUG, \"Promisc mode has already been enabled\");\n+\telse if (status != ICE_SUCCESS)\n \t\tPMD_DRV_LOG(ERR, \"Failed to enable promisc, err=%d\", status);\n }\n \n", "prefixes": [ "2/2" ] }{ "id": 52716, "url": "