Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52715/?format=api
http://patches.dpdk.org/api/patches/52715/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1555077139-244831-2-git-send-email-ying.a.wang@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1555077139-244831-2-git-send-email-ying.a.wang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1555077139-244831-2-git-send-email-ying.a.wang@intel.com", "date": "2019-04-12T13:52:18", "name": "[1/2] net/ice: code clean", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "85a0d9f63bf0c474f38979db4ee523253fbb1085", "submitter": { "id": 1280, "url": "http://patches.dpdk.org/api/people/1280/?format=api", "name": "Ying Wang", "email": "ying.a.wang@intel.com" }, "delegate": { "id": 1540, "url": "http://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1555077139-244831-2-git-send-email-ying.a.wang@intel.com/mbox/", "series": [ { "id": 4284, "url": "http://patches.dpdk.org/api/series/4284/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4284", "date": "2019-04-12T13:52:17", "name": "ice: code clean and promisc mode fix", "version": 1, "mbox": "http://patches.dpdk.org/series/4284/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/52715/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/52715/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 030CC1B1A0;\n\tFri, 12 Apr 2019 16:03:38 +0200 (CEST)", "from mga14.intel.com (mga14.intel.com [192.55.52.115])\n\tby dpdk.org (Postfix) with ESMTP id 999961B163;\n\tFri, 12 Apr 2019 16:03:36 +0200 (CEST)", "from orsmga008.jf.intel.com ([10.7.209.65])\n\tby fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t12 Apr 2019 07:03:35 -0700", "from unknown (HELO npg-dpdk-cvl-yingwang-117d94.sh.intel.com)\n\t([10.67.117.94])\n\tby orsmga008.jf.intel.com with ESMTP; 12 Apr 2019 07:03:34 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,341,1549958400\"; d=\"scan'208\";a=\"133735419\"", "From": "Wang Ying A <ying.a.wang@intel.com>", "To": "wenzhuo.lu@intel.com,\n\tqiming.yang@intel.com", "Cc": "dev@dpdk.org,\n\tWang Ying A <ying.a.wang@intel.com>,\n\tstable@dpdk.org", "Date": "Fri, 12 Apr 2019 21:52:18 +0800", "Message-Id": "<1555077139-244831-2-git-send-email-ying.a.wang@intel.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1555077139-244831-1-git-send-email-ying.a.wang@intel.com>", "References": "<1555077139-244831-1-git-send-email-ying.a.wang@intel.com>", "Subject": "[dpdk-dev] [PATCH 1/2] net/ice: code clean", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Variable \"status\" should be difined as \"int\" instead of \"uint_16t\".\nThis patch fixes the issue.\n\nFixes: c945e4bf9063 (\"net/ice: support promiscuous mode\")\nCc: stable@dpdk.org\n\nSigned-off-by: Wang Ying A <ying.a.wang@intel.com>\n---\n drivers/net/ice/ice_ethdev.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c\nindex 9d01018..72831bb 100644\n--- a/drivers/net/ice/ice_ethdev.c\n+++ b/drivers/net/ice/ice_ethdev.c\n@@ -2753,7 +2753,7 @@ static int ice_macaddr_set(struct rte_eth_dev *dev,\n \tstruct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \tstruct ice_vsi *vsi = pf->main_vsi;\n \tuint8_t pmask;\n-\tuint16_t status;\n+\tint status;\n \n \tpmask = ICE_PROMISC_UCAST_RX | ICE_PROMISC_UCAST_TX |\n \t\tICE_PROMISC_MCAST_RX | ICE_PROMISC_MCAST_TX;\n@@ -2769,7 +2769,7 @@ static int ice_macaddr_set(struct rte_eth_dev *dev,\n \tstruct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);\n \tstruct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \tstruct ice_vsi *vsi = pf->main_vsi;\n-\tuint16_t status;\n+\tint status;\n \tuint8_t pmask;\n \n \tpmask = ICE_PROMISC_UCAST_RX | ICE_PROMISC_UCAST_TX |\n@@ -2787,7 +2787,7 @@ static int ice_macaddr_set(struct rte_eth_dev *dev,\n \tstruct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \tstruct ice_vsi *vsi = pf->main_vsi;\n \tuint8_t pmask;\n-\tuint16_t status;\n+\tint status;\n \n \tpmask = ICE_PROMISC_MCAST_RX | ICE_PROMISC_MCAST_TX;\n \n@@ -2802,7 +2802,7 @@ static int ice_macaddr_set(struct rte_eth_dev *dev,\n \tstruct ice_pf *pf = ICE_DEV_PRIVATE_TO_PF(dev->data->dev_private);\n \tstruct ice_hw *hw = ICE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \tstruct ice_vsi *vsi = pf->main_vsi;\n-\tuint16_t status;\n+\tint status;\n \tuint8_t pmask;\n \n \tif (dev->data->promiscuous == 1)\n", "prefixes": [ "1/2" ] }{ "id": 52715, "url": "