Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52709/?format=api
{ "id": 52709, "url": "http://patches.dpdk.org/api/patches/52709/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190412122840.1908-12-g.singh@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190412122840.1908-12-g.singh@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190412122840.1908-12-g.singh@nxp.com", "date": "2019-04-12T12:29:08", "name": "[v4,11/13] net/enetc: enable CRC offload feature", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "a514e476b999093bb7effa28c73d92e54e8af12f", "submitter": { "id": 1068, "url": "http://patches.dpdk.org/api/people/1068/?format=api", "name": "Gagandeep Singh", "email": "g.singh@nxp.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190412122840.1908-12-g.singh@nxp.com/mbox/", "series": [ { "id": 4281, "url": "http://patches.dpdk.org/api/series/4281/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4281", "date": "2019-04-12T12:28:51", "name": "ENETC PMD basic features and bug fixes", "version": 4, "mbox": "http://patches.dpdk.org/series/4281/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/52709/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/52709/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id ACDAF1B227;\n\tFri, 12 Apr 2019 14:29:46 +0200 (CEST)", "from EUR04-VI1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr80087.outbound.protection.outlook.com [40.107.8.87])\n\tby dpdk.org (Postfix) with ESMTP id B5F981B137\n\tfor <dev@dpdk.org>; Fri, 12 Apr 2019 14:29:09 +0200 (CEST)", "from VE1PR04MB6365.eurprd04.prod.outlook.com (10.255.118.78) by\n\tVE1PR04MB6702.eurprd04.prod.outlook.com (20.179.235.203) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1792.17; Fri, 12 Apr 2019 12:29:08 +0000", "from VE1PR04MB6365.eurprd04.prod.outlook.com\n\t([fe80::f5ad:f178:4c55:13e0]) by\n\tVE1PR04MB6365.eurprd04.prod.outlook.com\n\t([fe80::f5ad:f178:4c55:13e0%3]) with mapi id 15.20.1792.016;\n\tFri, 12 Apr 2019 12:29:08 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=plxKDS/slg+bfwgfPxsqO+A/8yySzctQ6Kv0YoaFyxQ=;\n\tb=rbs3Cn7SPAtfCbeMDCwg8ctsRkFdi44TchIX6IOAPRY3BDi/VD4Fd3RgIIXfI5u0eVvOS6gSlbvDJDerrkREpVRAZjltPKWvF/XsmwICffmptHcjJWnV4t4jNMLfgUMlai6qB0KfVC7MdbOPBlRPq7CHIHpcdRZPd7LlRjPt5Xc=", "From": "Gagandeep Singh <G.Singh@nxp.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>, \"ferruh.yigit@intel.com\"\n\t<ferruh.yigit@intel.com>", "CC": "Gagandeep Singh <G.Singh@nxp.com>", "Thread-Topic": "[PATCH v4 11/13] net/enetc: enable CRC offload feature", "Thread-Index": "AQHU8StT1S5612dBkESsctgGyiS/Eg==", "Date": "Fri, 12 Apr 2019 12:29:08 +0000", "Message-ID": "<20190412122840.1908-12-g.singh@nxp.com>", "References": "<20190412105105.24351-1-g.singh@nxp.com>\n\t<20190412122840.1908-1-g.singh@nxp.com>", "In-Reply-To": "<20190412122840.1908-1-g.singh@nxp.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "BMXPR01CA0029.INDPRD01.PROD.OUTLOOK.COM\n\t(2603:1096:b00:c::15) To VE1PR04MB6365.eurprd04.prod.outlook.com\n\t(2603:10a6:803:12a::14)", "x-mailer": "git-send-email 2.19.1", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=G.Singh@nxp.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-originating-ip": "[92.120.0.8]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "51c5051b-4027-49ec-b4af-08d6bf427573", "x-ms-office365-filtering-ht": "Tenant", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(4618075)(2017052603328)(7193020);\n\tSRVR:VE1PR04MB6702; ", "x-ms-traffictypediagnostic": "VE1PR04MB6702:", "x-microsoft-antispam-prvs": "<VE1PR04MB67023442ECFC6950AE6614AEE1280@VE1PR04MB6702.eurprd04.prod.outlook.com>", "x-forefront-prvs": "0005B05917", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(136003)(396003)(376002)(366004)(39860400002)(346002)(199004)(189003)(476003)(102836004)(97736004)(2616005)(5660300002)(52116002)(6486002)(76176011)(36756003)(11346002)(486006)(446003)(26005)(6506007)(386003)(256004)(14444005)(186003)(2906002)(4326008)(8936002)(50226002)(3846002)(14454004)(53936002)(86362001)(105586002)(478600001)(66066001)(106356001)(6116002)(1076003)(72206003)(81166006)(316002)(110136005)(81156014)(68736007)(25786009)(305945005)(7736002)(99286004)(2501003)(8676002)(71190400001)(71200400001)(6436002)(6512007);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6702;\n\tH:VE1PR04MB6365.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "h+WUn4sZAJn7Ic0GxUQePCjVcI2KvlnkTacgN9N9I+FWPA5LNcUuPlpKNlsOEzPvHuE6i7VTihJ+a6UfdgkNFd0jSL8RYf8UdVpLGb8pGxZLM+TzV5HnAJ/9x/EYx8O6S8/bAMO6FtibeiEQTJs3YaG/RDoNXqwYI1R1h80ujizcjFYym23HyOSkAX19masMK9/PxlAavB2I9e5pC0BXa9SCIuzd/R2bE/hc0E2RG139l3WRPqvjXJlXnMJ53r2ZY4u0tina7LfCFjCUy2PFzIFBmF9cDQbg/Pv77rlAzbK3VIHGaMzpJjW9J2+sX2YOiBT9WlTB9cGuz9+ixZMF2rltodh3la4sepXXm1u1dOa2T6u+Q9qPVnDvKGZzddwPhEg8xb2WgiXGEo+zSf/KhCeGPpeuQ3nVkV4GVFpRlEU=", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "MIME-Version": "1.0", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "51c5051b-4027-49ec-b4af-08d6bf427573", "X-MS-Exchange-CrossTenant-originalarrivaltime": "12 Apr 2019 12:29:08.2670\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VE1PR04MB6702", "Subject": "[dpdk-dev] [PATCH v4 11/13] net/enetc: enable CRC offload feature", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "CRC offload keep feature supported\n\nSigned-off-by: Gagandeep Singh <g.singh@nxp.com>\n---\n doc/guides/nics/enetc.rst | 1 +\n doc/guides/nics/features/enetc.ini | 1 +\n drivers/net/enetc/base/enetc_hw.h | 1 +\n drivers/net/enetc/enetc.h | 1 +\n drivers/net/enetc/enetc_ethdev.c | 20 +++++++++++++++++---\n drivers/net/enetc/enetc_rxtx.c | 6 ++++--\n 6 files changed, 25 insertions(+), 5 deletions(-)", "diff": "diff --git a/doc/guides/nics/enetc.rst b/doc/guides/nics/enetc.rst\r\nindex 26d61f67d..26204601a 100644\r\n--- a/doc/guides/nics/enetc.rst\r\n+++ b/doc/guides/nics/enetc.rst\r\n@@ -52,6 +52,7 @@ ENETC Features\r\n - Jumbo packets\r\n - Queue Start/Stop\r\n - Deferred Queue Start\r\n+- CRC offload\r\n \r\n NIC Driver (PMD)\r\n ~~~~~~~~~~~~~~~~\r\ndiff --git a/doc/guides/nics/features/enetc.ini b/doc/guides/nics/features/enetc.ini\r\nindex bd901faf4..101dc0a69 100644\r\n--- a/doc/guides/nics/features/enetc.ini\r\n+++ b/doc/guides/nics/features/enetc.ini\r\n@@ -12,6 +12,7 @@ Allmulticast mode = Y\r\n MTU update = Y\r\n Jumbo frame = Y\r\n Queue start/stop = Y\r\n+CRC offload = Y\r\n Linux VFIO = Y\r\n ARMv8 = Y\r\n Usage doc = Y\r\ndiff --git a/drivers/net/enetc/base/enetc_hw.h b/drivers/net/enetc/base/enetc_hw.h\r\nindex 2eb1df30e..261ad157a 100644\r\n--- a/drivers/net/enetc/base/enetc_hw.h\r\n+++ b/drivers/net/enetc/base/enetc_hw.h\r\n@@ -97,6 +97,7 @@ enum enetc_bdr_type {TX, RX};\r\n #define ENETC_PM0_CMD_CFG\t\t0x08008\r\n #define ENETC_PM0_TX_EN\t\t\tBIT(0)\r\n #define ENETC_PM0_RX_EN\t\t\tBIT(1)\r\n+#define ENETC_PM0_CRC\t\t\tBIT(6)\r\n \r\n #define ENETC_PM0_MAXFRM\t\t0x08014\r\n #define ENETC_SET_TX_MTU(val)\t\t((val) << 16)\r\ndiff --git a/drivers/net/enetc/enetc.h b/drivers/net/enetc/enetc.h\r\nindex e494eb8b8..8c830a5c0 100644\r\n--- a/drivers/net/enetc/enetc.h\r\n+++ b/drivers/net/enetc/enetc.h\r\n@@ -69,6 +69,7 @@ struct enetc_bdr {\r\n \t\tvoid *tcisr; /* Tx */\r\n \t\tint next_to_alloc; /* Rx */\r\n \t};\r\n+\tuint8_t\tcrc_len; /* 0 if CRC stripped, 4 otherwise */\r\n };\r\n \r\n /*\r\ndiff --git a/drivers/net/enetc/enetc_ethdev.c b/drivers/net/enetc/enetc_ethdev.c\r\nindex ff9301e01..ffae8ae25 100644\r\n--- a/drivers/net/enetc/enetc_ethdev.c\r\n+++ b/drivers/net/enetc/enetc_ethdev.c\r\n@@ -162,7 +162,9 @@ enetc_dev_infos_get(struct rte_eth_dev *dev __rte_unused,\r\n \tdev_info->max_rx_queues = MAX_RX_RINGS;\r\n \tdev_info->max_tx_queues = MAX_TX_RINGS;\r\n \tdev_info->max_rx_pktlen = ENETC_MAC_MAXFRM_SIZE;\r\n-\tdev_info->rx_offload_capa = DEV_RX_OFFLOAD_JUMBO_FRAME;\r\n+\tdev_info->rx_offload_capa =\r\n+\t\t(DEV_RX_OFFLOAD_KEEP_CRC |\r\n+\t\t DEV_RX_OFFLOAD_JUMBO_FRAME);\r\n }\r\n \r\n static int\r\n@@ -378,6 +380,7 @@ enetc_rx_queue_setup(struct rte_eth_dev *dev,\r\n \tstruct rte_eth_dev_data *data = dev->data;\r\n \tstruct enetc_eth_adapter *adapter =\r\n \t\t\tENETC_DEV_PRIVATE(data->dev_private);\r\n+\tuint64_t rx_offloads = data->dev_conf.rxmode.offloads;\r\n \r\n \tPMD_INIT_FUNC_TRACE();\r\n \tif (nb_rx_desc > MAX_BD_COUNT)\r\n@@ -410,6 +413,9 @@ enetc_rx_queue_setup(struct rte_eth_dev *dev,\r\n \t\t\t RTE_ETH_QUEUE_STATE_STOPPED;\r\n \t}\r\n \r\n+\trx_ring->crc_len = (uint8_t)((rx_offloads & DEV_RX_OFFLOAD_KEEP_CRC) ?\r\n+\t\t\t\t ETHER_CRC_LEN : 0);\r\n+\r\n \treturn 0;\r\n fail:\r\n \trte_free(rx_ring);\r\n@@ -625,11 +631,11 @@ enetc_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)\r\n static int\r\n enetc_dev_configure(struct rte_eth_dev *dev)\r\n {\r\n-\tstruct rte_eth_conf *eth_conf = &dev->data->dev_conf;\r\n-\tuint64_t rx_offloads = eth_conf->rxmode.offloads;\r\n \tstruct enetc_eth_hw *hw =\r\n \t\tENETC_DEV_PRIVATE_TO_HW(dev->data->dev_private);\r\n \tstruct enetc_hw *enetc_hw = &hw->hw;\r\n+\tstruct rte_eth_conf *eth_conf = &dev->data->dev_conf;\r\n+\tuint64_t rx_offloads = eth_conf->rxmode.offloads;\r\n \r\n \tPMD_INIT_FUNC_TRACE();\r\n \r\n@@ -647,6 +653,14 @@ enetc_dev_configure(struct rte_eth_dev *dev)\r\n \t\tdev->data->mtu = ETHER_MAX_LEN - ETHER_HDR_LEN - ETHER_CRC_LEN;\r\n \t}\r\n \r\n+\tif (rx_offloads & DEV_RX_OFFLOAD_KEEP_CRC) {\r\n+\t\tint config;\r\n+\r\n+\t\tconfig = enetc_port_rd(enetc_hw, ENETC_PM0_CMD_CFG);\r\n+\t\tconfig |= ENETC_PM0_CRC;\r\n+\t\tenetc_port_wr(enetc_hw, ENETC_PM0_CMD_CFG, config);\r\n+\t}\r\n+\r\n \treturn 0;\r\n }\r\n \r\ndiff --git a/drivers/net/enetc/enetc_rxtx.c b/drivers/net/enetc/enetc_rxtx.c\r\nindex 42f16cab1..4a758d25a 100644\r\n--- a/drivers/net/enetc/enetc_rxtx.c\r\n+++ b/drivers/net/enetc/enetc_rxtx.c\r\n@@ -208,8 +208,10 @@ enetc_clean_rx_ring(struct enetc_bdr *rx_ring,\r\n \t\tif (!bd_status)\r\n \t\t\tbreak;\r\n \r\n-\t\trx_swbd->buffer_addr->pkt_len = rxbd->r.buf_len;\r\n-\t\trx_swbd->buffer_addr->data_len = rxbd->r.buf_len;\r\n+\t\trx_swbd->buffer_addr->pkt_len = rxbd->r.buf_len -\r\n+\t\t\t\t\t\trx_ring->crc_len;\r\n+\t\trx_swbd->buffer_addr->data_len = rxbd->r.buf_len -\r\n+\t\t\t\t\t\t rx_ring->crc_len;\r\n \t\trx_swbd->buffer_addr->hash.rss = rxbd->r.rss_hash;\r\n \t\trx_swbd->buffer_addr->ol_flags = 0;\r\n \t\tenetc_dev_rx_parse(rx_swbd->buffer_addr,\r\n", "prefixes": [ "v4", "11/13" ] }