Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52699/?format=api
{ "id": 52699, "url": "http://patches.dpdk.org/api/patches/52699/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190412122840.1908-2-g.singh@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190412122840.1908-2-g.singh@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190412122840.1908-2-g.singh@nxp.com", "date": "2019-04-12T12:28:53", "name": "[v4,01/13] net/enetc: support physical addressing mode", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "916566433544d94f581f377415ffbb8f8adba6b5", "submitter": { "id": 1068, "url": "http://patches.dpdk.org/api/people/1068/?format=api", "name": "Gagandeep Singh", "email": "g.singh@nxp.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190412122840.1908-2-g.singh@nxp.com/mbox/", "series": [ { "id": 4281, "url": "http://patches.dpdk.org/api/series/4281/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4281", "date": "2019-04-12T12:28:51", "name": "ENETC PMD basic features and bug fixes", "version": 4, "mbox": "http://patches.dpdk.org/series/4281/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/52699/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/52699/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CA2A41B11F;\n\tFri, 12 Apr 2019 14:29:00 +0200 (CEST)", "from EUR04-VI1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr80088.outbound.protection.outlook.com [40.107.8.88])\n\tby dpdk.org (Postfix) with ESMTP id 97A357D4A\n\tfor <dev@dpdk.org>; Fri, 12 Apr 2019 14:28:54 +0200 (CEST)", "from VE1PR04MB6365.eurprd04.prod.outlook.com (10.255.118.78) by\n\tVE1PR04MB6367.eurprd04.prod.outlook.com (10.255.118.80) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1792.15; Fri, 12 Apr 2019 12:28:53 +0000", "from VE1PR04MB6365.eurprd04.prod.outlook.com\n\t([fe80::f5ad:f178:4c55:13e0]) by\n\tVE1PR04MB6365.eurprd04.prod.outlook.com\n\t([fe80::f5ad:f178:4c55:13e0%3]) with mapi id 15.20.1792.016;\n\tFri, 12 Apr 2019 12:28:53 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=QGpRWQeUWo1OGZOOUIYnGI+KQ4yfbHGjU+BBURNvUNs=;\n\tb=cW7qgRNzafGyXpZPY9out1c8OmWREgBs7hZAqMfaG8n8EYf0NkoPWIKOOwrwbUaZhU/YwWQVqvk5R7L4KBBj6n13S0yw831Sfcp4shrB+Z/pbsZzwKpHE3AWID1BPKc1PFdM2jNvDdE1Lhl8UZSpyAdAPb5UAJDdzZ5uM9dJRXc=", "From": "Gagandeep Singh <G.Singh@nxp.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>, \"ferruh.yigit@intel.com\"\n\t<ferruh.yigit@intel.com>", "CC": "Gagandeep Singh <G.Singh@nxp.com>", "Thread-Topic": "[PATCH v4 01/13] net/enetc: support physical addressing mode", "Thread-Index": "AQHU8StKkKp0fttOpkiMjmvBko09zw==", "Date": "Fri, 12 Apr 2019 12:28:53 +0000", "Message-ID": "<20190412122840.1908-2-g.singh@nxp.com>", "References": "<20190412105105.24351-1-g.singh@nxp.com>\n\t<20190412122840.1908-1-g.singh@nxp.com>", "In-Reply-To": "<20190412122840.1908-1-g.singh@nxp.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "BMXPR01CA0029.INDPRD01.PROD.OUTLOOK.COM\n\t(2603:1096:b00:c::15) To VE1PR04MB6365.eurprd04.prod.outlook.com\n\t(2603:10a6:803:12a::14)", "x-mailer": "git-send-email 2.19.1", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=G.Singh@nxp.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-originating-ip": "[92.120.0.8]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "04affc15-b91c-46ed-248e-08d6bf426c7d", "x-ms-office365-filtering-ht": "Tenant", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(4618075)(2017052603328)(7193020);\n\tSRVR:VE1PR04MB6367; ", "x-ms-traffictypediagnostic": "VE1PR04MB6367:", "x-microsoft-antispam-prvs": "<VE1PR04MB63675EA2F2C34E27BDDC2827E1280@VE1PR04MB6367.eurprd04.prod.outlook.com>", "x-forefront-prvs": "0005B05917", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(376002)(346002)(396003)(39860400002)(366004)(136003)(189003)(199004)(476003)(99286004)(1076003)(8936002)(2501003)(5660300002)(186003)(6486002)(97736004)(3846002)(6436002)(106356001)(6116002)(7736002)(6506007)(102836004)(386003)(305945005)(256004)(446003)(76176011)(2616005)(105586002)(26005)(71190400001)(53936002)(36756003)(66066001)(25786009)(8676002)(486006)(11346002)(14454004)(50226002)(71200400001)(81156014)(6512007)(86362001)(2906002)(316002)(478600001)(110136005)(72206003)(4326008)(52116002)(68736007)(81166006);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6367;\n\tH:VE1PR04MB6365.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; MX:1; A:1; ", "received-spf": "None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "CEKqj4y6Zo3u6HEo+dG+kyNES8YIpak70PLeBoU3AXBAv7Oj7fehLc6slfLWx0fGv6S5h8M3AJbGtEmZOEKvofl0GZ3wtsFWawyfCaZos/BlleZtkqUwQmnHK4twIn1YJOqIRwpauz00mTInpjZ+aVG4KjwZfqn0QZvz/zcF+qzOg/h/i8Zc1f6QZN5ngQVrW8mX6t1mVWI/XhMkK6OGuHSItifjVHsr90LKvNN9SorefyAhqOYlqTR9PNGjuyhvJx8EFMQjD5EcEsyEVk73i7RV0+jRQtZ7n5qFgpjqKFXdgFs3XR2aWLEdS1u05crGRvtzNaZA8OmHMpNoKsl16edQakU4njOYNRvt+VCtp3MvnwCkHDClEYW9ZVby49J9jeBTdDUquz/F4CxpgpiWpRPgaJCwXIgj5KSuaP7FHMg=", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "MIME-Version": "1.0", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "04affc15-b91c-46ed-248e-08d6bf426c7d", "X-MS-Exchange-CrossTenant-originalarrivaltime": "12 Apr 2019 12:28:53.1994\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VE1PR04MB6367", "Subject": "[dpdk-dev] [PATCH v4 01/13] net/enetc: support physical addressing\n\tmode", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Support added for physical addressing mode and\nchange driver flags to don't care.\n\nSigned-off-by: Gagandeep Singh <g.singh@nxp.com>\n---\n drivers/net/enetc/enetc_ethdev.c | 22 ++++++++++++----------\n drivers/net/enetc/enetc_rxtx.c | 6 +++---\n 2 files changed, 15 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/enetc/enetc_ethdev.c b/drivers/net/enetc/enetc_ethdev.c\r\nindex 023fe7517..7a9a97deb 100644\r\n--- a/drivers/net/enetc/enetc_ethdev.c\r\n+++ b/drivers/net/enetc/enetc_ethdev.c\r\n@@ -1,5 +1,5 @@\r\n /* SPDX-License-Identifier: BSD-3-Clause\r\n- * Copyright 2018 NXP\r\n+ * Copyright 2018-2019 NXP\r\n */\r\n \r\n #include <stdbool.h>\r\n@@ -334,14 +334,15 @@ static void\r\n enetc_setup_txbdr(struct enetc_hw *hw, struct enetc_bdr *tx_ring)\r\n {\r\n \tint idx = tx_ring->index;\r\n-\tuintptr_t base_addr;\r\n \tuint32_t tbmr;\r\n+\tphys_addr_t bd_address;\r\n \r\n-\tbase_addr = (uintptr_t)tx_ring->bd_base;\r\n+\tbd_address = (phys_addr_t)\r\n+\t\t rte_mem_virt2iova((const void *)tx_ring->bd_base);\r\n \tenetc_txbdr_wr(hw, idx, ENETC_TBBAR0,\r\n-\t\t lower_32_bits((uint64_t)base_addr));\r\n+\t\t lower_32_bits((uint64_t)bd_address));\r\n \tenetc_txbdr_wr(hw, idx, ENETC_TBBAR1,\r\n-\t\t upper_32_bits((uint64_t)base_addr));\r\n+\t\t upper_32_bits((uint64_t)bd_address));\r\n \tenetc_txbdr_wr(hw, idx, ENETC_TBLENR,\r\n \t\t ENETC_RTBLENR_LEN(tx_ring->bd_count));\r\n \r\n@@ -478,14 +479,15 @@ enetc_setup_rxbdr(struct enetc_hw *hw, struct enetc_bdr *rx_ring,\r\n \t\t struct rte_mempool *mb_pool)\r\n {\r\n \tint idx = rx_ring->index;\r\n-\tuintptr_t base_addr;\r\n \tuint16_t buf_size;\r\n+\tphys_addr_t bd_address;\r\n \r\n-\tbase_addr = (uintptr_t)rx_ring->bd_base;\r\n+\tbd_address = (phys_addr_t)\r\n+\t\t rte_mem_virt2iova((const void *)rx_ring->bd_base);\r\n \tenetc_rxbdr_wr(hw, idx, ENETC_RBBAR0,\r\n-\t\t lower_32_bits((uint64_t)base_addr));\r\n+\t\t lower_32_bits((uint64_t)bd_address));\r\n \tenetc_rxbdr_wr(hw, idx, ENETC_RBBAR1,\r\n-\t\t upper_32_bits((uint64_t)base_addr));\r\n+\t\t upper_32_bits((uint64_t)bd_address));\r\n \tenetc_rxbdr_wr(hw, idx, ENETC_RBLENR,\r\n \t\t ENETC_RTBLENR_LEN(rx_ring->bd_count));\r\n \r\n@@ -612,7 +614,7 @@ enetc_pci_remove(struct rte_pci_device *pci_dev)\r\n \r\n static struct rte_pci_driver rte_enetc_pmd = {\r\n \t.id_table = pci_id_enetc_map,\r\n-\t.drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_IOVA_AS_VA,\r\n+\t.drv_flags = RTE_PCI_DRV_NEED_MAPPING,\r\n \t.probe = enetc_pci_probe,\r\n \t.remove = enetc_pci_remove,\r\n };\r\ndiff --git a/drivers/net/enetc/enetc_rxtx.c b/drivers/net/enetc/enetc_rxtx.c\r\nindex 631e2430d..a31a38725 100644\r\n--- a/drivers/net/enetc/enetc_rxtx.c\r\n+++ b/drivers/net/enetc/enetc_rxtx.c\r\n@@ -1,5 +1,5 @@\r\n /* SPDX-License-Identifier: BSD-3-Clause\r\n- * Copyright 2018 NXP\r\n+ * Copyright 2018-2019 NXP\r\n */\r\n \r\n #include <stdbool.h>\r\n@@ -64,7 +64,7 @@ enetc_xmit_pkts(void *tx_queue,\r\n \t\ttxbd->buf_len = txbd->frm_len;\r\n \t\ttxbd->flags = rte_cpu_to_le_16(ENETC_TXBD_FLAGS_F);\r\n \t\ttxbd->addr = (uint64_t)(uintptr_t)\r\n-\t\trte_cpu_to_le_64((size_t)tx_swbd->buffer_addr->buf_addr +\r\n+\t\trte_cpu_to_le_64((size_t)tx_swbd->buffer_addr->buf_iova +\r\n \t\t\t\t tx_swbd->buffer_addr->data_off);\r\n \t\ti++;\r\n \t\tstart++;\r\n@@ -91,7 +91,7 @@ enetc_refill_rx_ring(struct enetc_bdr *rx_ring, const int buff_cnt)\r\n \t\trx_swbd->buffer_addr =\r\n \t\t\trte_cpu_to_le_64(rte_mbuf_raw_alloc(rx_ring->mb_pool));\r\n \t\trxbd->w.addr = (uint64_t)(uintptr_t)\r\n-\t\t\t rx_swbd->buffer_addr->buf_addr +\r\n+\t\t\t rx_swbd->buffer_addr->buf_iova +\r\n \t\t\t rx_swbd->buffer_addr->data_off;\r\n \t\t/* clear 'R\" as well */\r\n \t\trxbd->r.lstatus = 0;\r\n", "prefixes": [ "v4", "01/13" ] }