Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52692/?format=api
{ "id": 52692, "url": "http://patches.dpdk.org/api/patches/52692/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190412105105.24351-9-g.singh@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190412105105.24351-9-g.singh@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190412105105.24351-9-g.singh@nxp.com", "date": "2019-04-12T11:01:39", "name": "[v3,08/13] net/enetc: enable promiscuous and allmulticast feature", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ac5dd8376336e921f5f28a7917fd0dc198f18880", "submitter": { "id": 1068, "url": "http://patches.dpdk.org/api/people/1068/?format=api", "name": "Gagandeep Singh", "email": "g.singh@nxp.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190412105105.24351-9-g.singh@nxp.com/mbox/", "series": [ { "id": 4280, "url": "http://patches.dpdk.org/api/series/4280/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4280", "date": "2019-04-12T11:01:11", "name": "ENETC PMD basic features and bug fixes", "version": 3, "mbox": "http://patches.dpdk.org/series/4280/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/52692/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/52692/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0C9EA1B11F;\n\tFri, 12 Apr 2019 13:01:50 +0200 (CEST)", "from EUR03-VE1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr50059.outbound.protection.outlook.com [40.107.5.59])\n\tby dpdk.org (Postfix) with ESMTP id 93D0D1B108\n\tfor <dev@dpdk.org>; Fri, 12 Apr 2019 13:01:41 +0200 (CEST)", "from VE1PR04MB6365.eurprd04.prod.outlook.com (10.255.118.78) by\n\tVE1PR04MB6384.eurprd04.prod.outlook.com (20.179.232.15) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1792.18; Fri, 12 Apr 2019 11:01:40 +0000", "from VE1PR04MB6365.eurprd04.prod.outlook.com\n\t([fe80::f5ad:f178:4c55:13e0]) by\n\tVE1PR04MB6365.eurprd04.prod.outlook.com\n\t([fe80::f5ad:f178:4c55:13e0%3]) with mapi id 15.20.1792.016;\n\tFri, 12 Apr 2019 11:01:39 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=iVklB46Ye+BrxVKg1PdY50VmM195mQU9KZv22hDwfzw=;\n\tb=HI4l3s2/+cc/aKC8b7naPL3mZ0CwE+m80CoFhUsA+Xb1PUcXRnyUC8UTEogamdfgqE8R44wtkKtHSyjVZyHoxUO/27/aUZIOcmAKYIWac3HH13DpU0KlsPf/gxUuA9EVM2NdCUWuBnaqDlG3YujL9Ug2XkZiKPU0jBiZ8lORKiw=", "From": "Gagandeep Singh <G.Singh@nxp.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>, \"ferruh.yigit@intel.com\"\n\t<ferruh.yigit@intel.com>", "CC": "Gagandeep Singh <G.Singh@nxp.com>", "Thread-Topic": "[PATCH v3 08/13] net/enetc: enable promiscuous and allmulticast\n\tfeature", "Thread-Index": "AQHU8R8aU8La/2WrkUCax3rtSnwGHQ==", "Date": "Fri, 12 Apr 2019 11:01:39 +0000", "Message-ID": "<20190412105105.24351-9-g.singh@nxp.com>", "References": "<1555075598-4988-1-git-send-email-g.singh@nxp.com>\n\t<20190412105105.24351-1-g.singh@nxp.com>", "In-Reply-To": "<20190412105105.24351-1-g.singh@nxp.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "TYAPR01CA0204.jpnprd01.prod.outlook.com\n\t(2603:1096:404:29::24) To VE1PR04MB6365.eurprd04.prod.outlook.com\n\t(2603:10a6:803:12a::14)", "x-mailer": "git-send-email 2.17.1", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=G.Singh@nxp.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-originating-ip": "[92.120.1.68]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "9089402d-322c-4c5e-da1a-08d6bf363d08", "x-ms-office365-filtering-ht": "Tenant", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(4618075)(2017052603328)(7193020);\n\tSRVR:VE1PR04MB6384; ", "x-ms-traffictypediagnostic": "VE1PR04MB6384:", "x-microsoft-antispam-prvs": "<VE1PR04MB638407A4D1E60EB910748C42E1280@VE1PR04MB6384.eurprd04.prod.outlook.com>", "x-forefront-prvs": "0005B05917", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(136003)(366004)(396003)(376002)(346002)(39860400002)(189003)(199004)(8676002)(8936002)(14454004)(186003)(446003)(478600001)(476003)(11346002)(72206003)(81166006)(81156014)(50226002)(2616005)(66066001)(4326008)(2501003)(26005)(305945005)(2906002)(5660300002)(3846002)(6116002)(486006)(386003)(6506007)(7736002)(102836004)(1076003)(68736007)(99286004)(76176011)(14444005)(86362001)(6486002)(25786009)(97736004)(110136005)(6436002)(316002)(52116002)(105586002)(6512007)(256004)(71200400001)(71190400001)(106356001)(53936002)(36756003);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6384;\n\tH:VE1PR04MB6365.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; MX:1; A:1; ", "received-spf": "None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "pxULCJzy3UyX4N5z6bMjzYrXPKuD+tJrnLurBB6t+wlkNyNpeUCB79SoTrJBOYggxNmAzLjy7153xwgw73razPt2xhuE+OFEcgyMnGdOsLpBOU+eTdAjshLOtIxjpWGZ4AYQR+Cjk51kOspukW6CClwEMsz7ta2kKE9lZG1/xczby/gj5aH+xXSCdgk8uliQW6AHeWzPlL01sZNRYP+7ht47455YyhvO85SL8cxg997bHCB8CvPIooK9rbrSq6Jccx7UtVwDS6FTU6prTeIBhVlS37zTz0aTbUE4PPDzA8eIpkJCBEWAQOUok9w+rK0fsQ8T4Gqbq/OJnyylJlfk9My1GyxRqFQBbehd0UTanFPgDQJ9uulFz9+8Y6zoubeqtD4W+87zcqw1RdYqz+6xuB02mXpQowk73t/GtxL9vRk=", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "MIME-Version": "1.0", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "9089402d-322c-4c5e-da1a-08d6bf363d08", "X-MS-Exchange-CrossTenant-originalarrivaltime": "12 Apr 2019 11:01:39.7706\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VE1PR04MB6384", "Subject": "[dpdk-dev] [PATCH v3 08/13] net/enetc: enable promiscuous and\n\tallmulticast feature", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Promiscuous and allmulticast enable/disable APIs added.\n\nSigned-off-by: Gagandeep Singh <g.singh@nxp.com>\n---\n doc/guides/nics/enetc.rst | 2 +\n doc/guides/nics/features/enetc.ini | 2 +\n drivers/net/enetc/base/enetc_hw.h | 3 +-\n drivers/net/enetc/enetc_ethdev.c | 90 ++++++++++++++++++++++++++++++++------\n 4 files changed, 81 insertions(+), 16 deletions(-)", "diff": "diff --git a/doc/guides/nics/enetc.rst b/doc/guides/nics/enetc.rst\r\nindex 9f575d2..ab13211 100644\r\n--- a/doc/guides/nics/enetc.rst\r\n+++ b/doc/guides/nics/enetc.rst\r\n@@ -47,6 +47,8 @@ ENETC Features\r\n - Link Status\r\n - Packet type information\r\n - Basic stats\r\n+- Promiscuous\r\n+- Multicast\r\n \r\n NIC Driver (PMD)\r\n ~~~~~~~~~~~~~~~~\r\ndiff --git a/doc/guides/nics/features/enetc.ini b/doc/guides/nics/features/enetc.ini\r\nindex d8bd567..6b7bbfb 100644\r\n--- a/doc/guides/nics/features/enetc.ini\r\n+++ b/doc/guides/nics/features/enetc.ini\r\n@@ -7,6 +7,8 @@\r\n Packet type parsing = Y\r\n Link status = Y\r\n Basic stats = Y\r\n+Promiscuous mode = Y\r\n+Allmulticast mode = Y\r\n Linux VFIO = Y\r\n ARMv8 = Y\r\n Usage doc = Y\r\ndiff --git a/drivers/net/enetc/base/enetc_hw.h b/drivers/net/enetc/base/enetc_hw.h\r\nindex 3f0a2a9..90a383a 100644\r\n--- a/drivers/net/enetc/base/enetc_hw.h\r\n+++ b/drivers/net/enetc/base/enetc_hw.h\r\n@@ -78,8 +78,7 @@\r\n #define ENETC_PSR\t\t\t0x00004 /* RO */\r\n #define ENETC_PSIPMR\t\t\t0x00018\r\n #define ENETC_PSIPMR_SET_UP(n)\t\t(0x1 << (n)) /* n = SI index */\r\n-#define ENETC_PSIPMR_SET_MP(n)\t\t(0x1 << ((n) + 8))\r\n-#define ENETC_PSIPMR_SET_VLAN_MP(n)\t(0x1 << ((n) + 16))\r\n+#define ENETC_PSIPMR_SET_MP(n)\t\t(0x1 << ((n) + 16))\r\n #define ENETC_PSIPMAR0(n)\t\t(0x00100 + (n) * 0x20)\r\n #define ENETC_PSIPMAR1(n)\t\t(0x00104 + (n) * 0x20)\r\n #define ENETC_PCAPR0\t\t\t0x00900\r\ndiff --git a/drivers/net/enetc/enetc_ethdev.c b/drivers/net/enetc/enetc_ethdev.c\r\nindex d0f9e2b..a7dddc5 100644\r\n--- a/drivers/net/enetc/enetc_ethdev.c\r\n+++ b/drivers/net/enetc/enetc_ethdev.c\r\n@@ -133,8 +133,8 @@\r\n static int\r\n enetc_hardware_init(struct enetc_eth_hw *hw)\r\n {\r\n-\tuint32_t psipmr = 0;\r\n \tstruct enetc_hw *enetc_hw = &hw->hw;\r\n+\tuint32_t *mac = (uint32_t *)hw->mac.addr;\r\n \r\n \tPMD_INIT_FUNC_TRACE();\r\n \t/* Calculating and storing the base HW addresses */\r\n@@ -144,19 +144,9 @@\r\n \t/* Enabling Station Interface */\r\n \tenetc_wr(enetc_hw, ENETC_SIMR, ENETC_SIMR_EN);\r\n \r\n-\t/* Setting to accept broadcast packets for each inetrface */\r\n-\tpsipmr |= ENETC_PSIPMR_SET_UP(0) | ENETC_PSIPMR_SET_MP(0) |\r\n-\t\t ENETC_PSIPMR_SET_VLAN_MP(0);\r\n-\tpsipmr |= ENETC_PSIPMR_SET_UP(1) | ENETC_PSIPMR_SET_MP(1) |\r\n-\t\t ENETC_PSIPMR_SET_VLAN_MP(1);\r\n-\tpsipmr |= ENETC_PSIPMR_SET_UP(2) | ENETC_PSIPMR_SET_MP(2) |\r\n-\t\t ENETC_PSIPMR_SET_VLAN_MP(2);\r\n-\r\n-\tenetc_port_wr(enetc_hw, ENETC_PSIPMR, psipmr);\r\n-\r\n-\t/* Enabling broadcast address */\r\n-\tenetc_port_wr(enetc_hw, ENETC_PSIPMAR0(0), 0xFFFFFFFF);\r\n-\tenetc_port_wr(enetc_hw, ENETC_PSIPMAR1(0), 0xFFFF << 16);\r\n+\t*mac = (uint32_t)enetc_port_rd(enetc_hw, ENETC_PSIPMAR0(0));\r\n+\tmac++;\r\n+\t*mac = (uint16_t)enetc_port_rd(enetc_hw, ENETC_PSIPMAR1(0));\r\n \r\n \treturn 0;\r\n }\r\n@@ -539,6 +529,74 @@ int enetc_stats_get(struct rte_eth_dev *dev,\r\n \tdev->data->nb_tx_queues = 0;\r\n }\r\n \r\n+static void\r\n+enetc_promiscuous_enable(struct rte_eth_dev *dev)\r\n+{\r\n+\tstruct enetc_eth_hw *hw =\r\n+\t\tENETC_DEV_PRIVATE_TO_HW(dev->data->dev_private);\r\n+\tstruct enetc_hw *enetc_hw = &hw->hw;\r\n+\tuint32_t psipmr = 0;\r\n+\r\n+\tpsipmr = enetc_port_rd(enetc_hw, ENETC_PSIPMR);\r\n+\r\n+\t/* Setting to enable promiscuous mode*/\r\n+\tpsipmr |= ENETC_PSIPMR_SET_UP(0) | ENETC_PSIPMR_SET_MP(0);\r\n+\r\n+\tenetc_port_wr(enetc_hw, ENETC_PSIPMR, psipmr);\r\n+}\r\n+\r\n+static void\r\n+enetc_promiscuous_disable(struct rte_eth_dev *dev)\r\n+{\r\n+\tstruct enetc_eth_hw *hw =\r\n+\t\tENETC_DEV_PRIVATE_TO_HW(dev->data->dev_private);\r\n+\tstruct enetc_hw *enetc_hw = &hw->hw;\r\n+\tuint32_t psipmr = 0;\r\n+\r\n+\t/* Setting to disable promiscuous mode for SI0*/\r\n+\tpsipmr = enetc_port_rd(enetc_hw, ENETC_PSIPMR);\r\n+\tpsipmr &= (~ENETC_PSIPMR_SET_UP(0));\r\n+\r\n+\tif (dev->data->all_multicast == 0)\r\n+\t\tpsipmr &= (~ENETC_PSIPMR_SET_MP(0));\r\n+\r\n+\tenetc_port_wr(enetc_hw, ENETC_PSIPMR, psipmr);\r\n+}\r\n+\r\n+static void\r\n+enetc_allmulticast_enable(struct rte_eth_dev *dev)\r\n+{\r\n+\tstruct enetc_eth_hw *hw =\r\n+\t\tENETC_DEV_PRIVATE_TO_HW(dev->data->dev_private);\r\n+\tstruct enetc_hw *enetc_hw = &hw->hw;\r\n+\tuint32_t psipmr = 0;\r\n+\r\n+\tpsipmr = enetc_port_rd(enetc_hw, ENETC_PSIPMR);\r\n+\r\n+\t/* Setting to enable allmulticast mode for SI0*/\r\n+\tpsipmr |= ENETC_PSIPMR_SET_MP(0);\r\n+\r\n+\tenetc_port_wr(enetc_hw, ENETC_PSIPMR, psipmr);\r\n+}\r\n+\r\n+static void\r\n+enetc_allmulticast_disable(struct rte_eth_dev *dev)\r\n+{\r\n+\tstruct enetc_eth_hw *hw =\r\n+\t\tENETC_DEV_PRIVATE_TO_HW(dev->data->dev_private);\r\n+\tstruct enetc_hw *enetc_hw = &hw->hw;\r\n+\tuint32_t psipmr = 0;\r\n+\r\n+\tif (dev->data->promiscuous == 1)\r\n+\t\treturn; /* must remain in all_multicast mode */\r\n+\r\n+\t/* Setting to disable all multicast mode for SI0*/\r\n+\tpsipmr = enetc_port_rd(enetc_hw, ENETC_PSIPMR) &\r\n+\t\t\t ~(ENETC_PSIPMR_SET_MP(0));\r\n+\r\n+\tenetc_port_wr(enetc_hw, ENETC_PSIPMR, psipmr);\r\n+}\r\n+\r\n /*\r\n * The set of PCI devices this driver supports\r\n */\r\n@@ -557,6 +615,10 @@ int enetc_stats_get(struct rte_eth_dev *dev,\r\n \t.link_update = enetc_link_update,\r\n \t.stats_get = enetc_stats_get,\r\n \t.stats_reset = enetc_stats_reset,\r\n+\t.promiscuous_enable = enetc_promiscuous_enable,\r\n+\t.promiscuous_disable = enetc_promiscuous_disable,\r\n+\t.allmulticast_enable = enetc_allmulticast_enable,\r\n+\t.allmulticast_disable = enetc_allmulticast_disable,\r\n \t.dev_infos_get = enetc_dev_infos_get,\r\n \t.rx_queue_setup = enetc_rx_queue_setup,\r\n \t.rx_queue_release = enetc_rx_queue_release,\r\n", "prefixes": [ "v3", "08/13" ] }