Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52687/?format=api
{ "id": 52687, "url": "http://patches.dpdk.org/api/patches/52687/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190412105105.24351-4-g.singh@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190412105105.24351-4-g.singh@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190412105105.24351-4-g.singh@nxp.com", "date": "2019-04-12T11:01:23", "name": "[v3,03/13] net/enetc: fix big endian build and correct buffer allocation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "29e37855fd5157bf820934f367868f2d8cbc73eb", "submitter": { "id": 1068, "url": "http://patches.dpdk.org/api/people/1068/?format=api", "name": "Gagandeep Singh", "email": "g.singh@nxp.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@intel.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190412105105.24351-4-g.singh@nxp.com/mbox/", "series": [ { "id": 4280, "url": "http://patches.dpdk.org/api/series/4280/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4280", "date": "2019-04-12T11:01:11", "name": "ENETC PMD basic features and bug fixes", "version": 3, "mbox": "http://patches.dpdk.org/series/4280/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/52687/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/52687/checks/", "tags": {}, "related": [], "headers": { "X-BeenThere": "dev@dpdk.org", "Return-Path": "<dev-bounces@dpdk.org>", "MIME-Version": "1.0", "X-MS-TNEF-Correlator": "", "Subject": "[dpdk-dev] [PATCH v3 03/13] net/enetc: fix big endian build and\n\tcorrect buffer allocation", "Message-ID": "<20190412105105.24351-4-g.singh@nxp.com>", "Accept-Language": "en-US", "received-spf": "None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "References": "<1555075598-4988-1-git-send-email-g.singh@nxp.com>\n\t<20190412105105.24351-1-g.singh@nxp.com>", "In-Reply-To": "<20190412105105.24351-1-g.singh@nxp.com>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VE1PR04MB6462", "X-MS-Exchange-CrossTenant-id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "CC": "Gagandeep Singh <G.Singh@nxp.com>, \"thomas@monjalon.net\"\n\t<thomas@monjalon.net>, \"stable@dpdk.org\" <stable@dpdk.org>", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "Content-Type": "text/plain; charset=\"utf-8\"", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(136003)(376002)(366004)(396003)(346002)(39860400002)(189003)(199004)(2501003)(186003)(97736004)(7736002)(3846002)(110136005)(99286004)(6116002)(54906003)(102836004)(86362001)(316002)(2616005)(11346002)(476003)(6506007)(446003)(76176011)(305945005)(26005)(1076003)(106356001)(66066001)(486006)(4326008)(105586002)(386003)(478600001)(52116002)(72206003)(50226002)(5660300002)(6436002)(81156014)(6512007)(71200400001)(8936002)(71190400001)(6486002)(68736007)(53936002)(256004)(25786009)(8676002)(81166006)(36756003)(14454004)(2906002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6462;\n\tH:VE1PR04MB6365.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; MX:1; A:1; ", "Content-Transfer-Encoding": "base64", "Thread-Index": "AQHU8R8Qe8S/Y7ZtWUWVFziBgjJKnA==", "X-OriginatorOrg": "nxp.com", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "Sender": "\"dev\" <dev-bounces@dpdk.org>", "X-MS-Exchange-CrossTenant-Network-Message-Id": "2f35eff2-50cb-4cc3-4948-08d6bf3632fc", "Date": "Fri, 12 Apr 2019 11:01:23 +0000", "From": "Gagandeep Singh <G.Singh@nxp.com>", "x-ms-exchange-messagesentrepresentingtype": "1", "X-MS-Exchange-CrossTenant-originalarrivaltime": "12 Apr 2019 11:01:23.1763\n\t(UTC)", "X-Mailman-Version": "2.1.15", "List-Post": "<mailto:dev@dpdk.org>", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=TT6/SM0c4ndT25L7i1l2S5YoAgcpYSTVCcL332orcgA=;\n\tb=mbt/zMgguEW0I6Q+pyehaYH4oHIxvy3/nNVyXPrVdHNUZVMgc5/srcY9Jd3kMjkQnUopo7D8Aulb5XGHL7W5mrQ+ZaqPWy7QEPfpP/j15K8HPg4IN0My61bZMxV4+3Whc9oyB2b0351mNTW7+Z4+U+QTIUo/Mk60tylM/e+ffoM=", "x-ms-exchange-senderadcheck": "1", "To": "\"dev@dpdk.org\" <dev@dpdk.org>, \"ferruh.yigit@intel.com\"\n\t<ferruh.yigit@intel.com>", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 09A25683E;\n\tFri, 12 Apr 2019 13:01:28 +0200 (CEST)", "from EUR03-AM5-obe.outbound.protection.outlook.com\n\t(mail-eopbgr30058.outbound.protection.outlook.com [40.107.3.58])\n\tby dpdk.org (Postfix) with ESMTP id 6FFB15F3C;\n\tFri, 12 Apr 2019 13:01:24 +0200 (CEST)", "from VE1PR04MB6365.eurprd04.prod.outlook.com (10.255.118.78) by\n\tVE1PR04MB6462.eurprd04.prod.outlook.com (20.179.233.19) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1771.21; Fri, 12 Apr 2019 11:01:23 +0000", "from VE1PR04MB6365.eurprd04.prod.outlook.com\n\t([fe80::f5ad:f178:4c55:13e0]) by\n\tVE1PR04MB6365.eurprd04.prod.outlook.com\n\t([fe80::f5ad:f178:4c55:13e0%3]) with mapi id 15.20.1792.016;\n\tFri, 12 Apr 2019 11:01:23 +0000" ], "X-MS-Has-Attach": "", "x-microsoft-antispam-message-info": "/q+8jAx7I/yjXGM6l7TqGQSk0MtxEv7bpsM3H9TWaw2k7a2rfU1k8pgGqZUh/PBV5AxuBs04XOoMRYmxcPMA+1rnGd7GFKI0kyG87bW5vd46hFGfn3qb12LMhlk2kjTxdaRUmmpeb3u+WE4jd4/iag1Uaj7kxlLy7T73rZgILt4T+WaWUwMPBjKh49DUVpObHMujbT8DJiNFmYTdjljzI5X1owPHl0fQMjSimn+AKUm1UgF3nB3WncAj0S3JpW3jGMoyZoyhKpJavPPQ0l2bvxGfKLysaMhIHVy3putrhK1y/HTyVPF/KwEJYX/Xfm9z2W9HAizQkrCBuHP5q0TQPak0QWoX+tOStPhA5SpdcEYz5Pbxa3ss3X/+qIm00E5xNGGKmQkbnwenFCbM6EpwgG7AREVEoYnTPTAUyjqnbmI=", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(4618075)(2017052603328)(7193020);\n\tSRVR:VE1PR04MB6462; ", "Errors-To": "dev-bounces@dpdk.org", "x-clientproxiedby": "TYAPR01CA0204.jpnprd01.prod.outlook.com\n\t(2603:1096:404:29::24) To VE1PR04MB6365.eurprd04.prod.outlook.com\n\t(2603:10a6:803:12a::14)", "x-ms-traffictypediagnostic": "VE1PR04MB6462:", "x-originating-ip": "[92.120.1.68]", "Delivered-To": "patchwork@dpdk.org", "X-Original-To": "patchwork@dpdk.org", "x-forefront-prvs": "0005B05917", "x-ms-office365-filtering-ht": "Tenant", "x-ms-publictraffictype": "Email", "x-microsoft-antispam-prvs": "<VE1PR04MB64621850155D39B383718591E1280@VE1PR04MB6462.eurprd04.prod.outlook.com>", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "x-mailer": "git-send-email 2.17.1", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=G.Singh@nxp.com; ", "Thread-Topic": "[PATCH v3 03/13] net/enetc: fix big endian build and correct\n\tbuffer allocation", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "Content-Language": "en-US", "x-ms-office365-filtering-correlation-id": "2f35eff2-50cb-4cc3-4948-08d6bf3632fc", "Precedence": "list" }, "content": "There was an error at rte_constant_bswap64 while compiling\nwith big endian toolchain. so fixing it by adding type cast.\n\nAlso, rte_pktmbuf_alloc API should be used to allocate mbuf\ninstead of rte_pktmbuf_raw_alloc to avoid use of stale mbuf\ninformation.\n\nFixes: 469c6111a799 (\"net/enetc: enable Rx and Tx\")\nCc: thomas@monjalon.net\nCc: stable@dpdk.org\n\nSigned-off-by: Gagandeep Singh <g.singh@nxp.com>\n---\n drivers/net/enetc/enetc_rxtx.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/enetc/enetc_rxtx.c b/drivers/net/enetc/enetc_rxtx.c\r\nindex a31a387..42f16ca 100644\r\n--- a/drivers/net/enetc/enetc_rxtx.c\r\n+++ b/drivers/net/enetc/enetc_rxtx.c\r\n@@ -88,8 +88,9 @@\r\n \trx_swbd = &rx_ring->q_swbd[i];\r\n \trxbd = ENETC_RXBD(*rx_ring, i);\r\n \tfor (j = 0; j < buff_cnt; j++) {\r\n-\t\trx_swbd->buffer_addr =\r\n-\t\t\trte_cpu_to_le_64(rte_mbuf_raw_alloc(rx_ring->mb_pool));\r\n+\t\trx_swbd->buffer_addr = (void *)(uintptr_t)\r\n+\t\t\trte_cpu_to_le_64((uint64_t)(uintptr_t)\r\n+\t\t\t\t\trte_pktmbuf_alloc(rx_ring->mb_pool));\r\n \t\trxbd->w.addr = (uint64_t)(uintptr_t)\r\n \t\t\t rx_swbd->buffer_addr->buf_iova +\r\n \t\t\t rx_swbd->buffer_addr->data_off;\r\n", "prefixes": [ "v3", "03/13" ] }