Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 52614,
    "url": "http://patches.dpdk.org/api/patches/52614/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190410171603.8979-6-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190410171603.8979-6-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190410171603.8979-6-stephen@networkplumber.org",
    "date": "2019-04-10T17:16:03",
    "name": "[v2,5/5] app/test: use lcore accessor functions",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "d471439bf967040c657bb58ab6dff0522afe7bc3",
    "submitter": {
        "id": 27,
        "url": "http://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190410171603.8979-6-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 4248,
            "url": "http://patches.dpdk.org/api/series/4248/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4248",
            "date": "2019-04-10T17:15:58",
            "name": "make lcore_config internal",
            "version": 2,
            "mbox": "http://patches.dpdk.org/series/4248/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/52614/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/52614/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9190F1B39D;\n\tWed, 10 Apr 2019 19:16:26 +0200 (CEST)",
            "from mail-pf1-f194.google.com (mail-pf1-f194.google.com\n\t[209.85.210.194]) by dpdk.org (Postfix) with ESMTP id AFD691B21A\n\tfor <dev@dpdk.org>; Wed, 10 Apr 2019 19:16:15 +0200 (CEST)",
            "by mail-pf1-f194.google.com with SMTP id 8so1875607pfr.4\n\tfor <dev@dpdk.org>; Wed, 10 Apr 2019 10:16:15 -0700 (PDT)",
            "from shemminger-XPS-13-9360.lan (204-195-22-127.wavecable.com.\n\t[204.195.22.127]) by smtp.gmail.com with ESMTPSA id\n\td25sm48995244pfn.154.2019.04.10.10.16.13\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tWed, 10 Apr 2019 10:16:13 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=DFK4nzbv3V/eCutdXyaPdGzuXJCEj/DVBU8FHaA+nho=;\n\tb=wiqKEiadb6TTJqI7hwhpK/XqEAJoOQxvQNwUrUPy1h/tW9pqa0VlD/Qw8g5f/7sITd\n\tW6oqTc8V0Z8oW+Z3B/1lpmAgTS0VOfYHAKUMfgnKJ3uSbZR+ilziFQacFwItKJ+cGksk\n\tvfPb3pjCZiOhzxIIjulb0TnYegGBTmBZ4yiBqoO/903FsGU9GDqFBsLFKcoOA2wFovrv\n\t/VljBuaCnx7NRw9NZJVcXBJV+s4RR1VsvJe/ctSK8WT6P/SzbgKsuSM3SPq3itFtr9pe\n\tsemhH18wC7Loc442NgPQ3GQ9jrMQMfhlCZRPVAfVzH2/x5q8MdVoCuMsOCpIJ7zvLwbo\n\tFLxQ==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=DFK4nzbv3V/eCutdXyaPdGzuXJCEj/DVBU8FHaA+nho=;\n\tb=B60OLjLwGLWo0KWeqrB/DldPrXsfK/5iKhBTgbOmMtPzY4oTrC0zlNNu8o7rflYRyd\n\tJfXq4Q9LqUR77vGGA4oPniAcI75Es9rXR+RG4Jy7CS4QLr6rSOwd2ktFEPYm4UwLSE9i\n\trcHKwDIbLZ1PZSuyU5lUCRGzeIlojAqAymkHJ3qINyz9IEC4LJK3d6PV/TJ42IvqBLI5\n\t2G/wYJWTjemklg5KxpwqNgQOoesRACackgLsGxUp9jGVd3/XMAf3a5fl+VqUOg1gg4gD\n\t/yelBMJ8vOXEkTTzUiBXgNJJ5ckinJ00MG/fsXjBayXaXtDx5Nahcg9N9LhmPwtIM0RD\n\tyBQw==",
        "X-Gm-Message-State": "APjAAAWBkGbNM99WKDI2UrZUXAiFvFH/8Q9J1+40ssjpklJTR04/J/4p\n\tjbBo/asNw3YmQEKETwPmNkkzO8WQzdk=",
        "X-Google-Smtp-Source": "APXvYqw7KSWgOCrO8wMbhiRsZyXFcIP9dXJfyXZYVDzHZU4WGmsiBjCGiyQQRkjKNi38KtqlL8tPmA==",
        "X-Received": "by 2002:a63:2aca:: with SMTP id\n\tq193mr41847983pgq.269.1554916574563; \n\tWed, 10 Apr 2019 10:16:14 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>",
        "Date": "Wed, 10 Apr 2019 10:16:03 -0700",
        "Message-Id": "<20190410171603.8979-6-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20190410171603.8979-1-stephen@networkplumber.org>",
        "References": "<20190408182510.16078-1-stephen@networkplumber.org>\n\t<20190410171603.8979-1-stephen@networkplumber.org>",
        "Subject": "[dpdk-dev] [PATCH v2 5/5] app/test: use lcore accessor functions",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Don't refer to lcore_config directly.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nReviewed-by: David Marchand <david.marchand@redhat.com>\n---\n app/test/test_cryptodev.c         |  2 +-\n app/test/test_hash_readwrite_lf.c | 14 +++++++-------\n app/test/test_ring_perf.c         | 22 ++++++++++++----------\n app/test/test_stack_perf.c        | 20 ++++++++++----------\n 4 files changed, 30 insertions(+), 28 deletions(-)",
    "diff": "diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c\nindex 9f31aaa7e6b2..eca6d3db16a5 100644\n--- a/app/test/test_cryptodev.c\n+++ b/app/test/test_cryptodev.c\n@@ -378,7 +378,7 @@ testsuite_setup(void)\n \t\t\tstrcpy(temp_str, vdev_args);\n \t\t\tstrlcat(temp_str, \";\", sizeof(temp_str));\n \t\t\tslave_core_count++;\n-\t\t\tsocket_id = lcore_config[i].socket_id;\n+\t\t\tsocket_id = rte_lcore_to_socket_id(i);\n \t\t}\n \t\tif (slave_core_count != 2) {\n \t\t\tRTE_LOG(ERR, USER1,\ndiff --git a/app/test/test_hash_readwrite_lf.c b/app/test/test_hash_readwrite_lf.c\nindex 4ab4c8ee64cf..1361a8aa4c9c 100644\n--- a/app/test/test_hash_readwrite_lf.c\n+++ b/app/test/test_hash_readwrite_lf.c\n@@ -741,7 +741,7 @@ test_hash_add_no_ks_lookup_hit(struct rwc_perf *rwc_perf_results, int rwc_lf,\n \t\t\trte_eal_mp_wait_lcore();\n \n \t\t\tfor (i = 1; i <= rwc_core_cnt[n]; i++)\n-\t\t\t\tif (lcore_config[i].ret < 0)\n+\t\t\t\tif (rte_lcore_return_code(i) < 0)\n \t\t\t\t\tgoto err;\n \n \t\t\tunsigned long long cycles_per_lookup =\n@@ -813,7 +813,7 @@ test_hash_add_no_ks_lookup_miss(struct rwc_perf *rwc_perf_results, int rwc_lf,\n \t\t\tif (ret < 0)\n \t\t\t\tgoto err;\n \t\t\tfor (i = 1; i <= rwc_core_cnt[n]; i++)\n-\t\t\t\tif (lcore_config[i].ret < 0)\n+\t\t\t\tif (rte_lcore_return_code(i) < 0)\n \t\t\t\t\tgoto err;\n \n \t\t\tunsigned long long cycles_per_lookup =\n@@ -889,7 +889,7 @@ test_hash_add_ks_lookup_hit_non_sp(struct rwc_perf *rwc_perf_results,\n \t\t\tif (ret < 0)\n \t\t\t\tgoto err;\n \t\t\tfor (i = 1; i <= rwc_core_cnt[n]; i++)\n-\t\t\t\tif (lcore_config[i].ret < 0)\n+\t\t\t\tif (rte_lcore_return_code(i) < 0)\n \t\t\t\t\tgoto err;\n \n \t\t\tunsigned long long cycles_per_lookup =\n@@ -965,7 +965,7 @@ test_hash_add_ks_lookup_hit_sp(struct rwc_perf *rwc_perf_results, int rwc_lf,\n \t\t\tif (ret < 0)\n \t\t\t\tgoto err;\n \t\t\tfor (i = 1; i <= rwc_core_cnt[n]; i++)\n-\t\t\t\tif (lcore_config[i].ret < 0)\n+\t\t\t\tif (rte_lcore_return_code(i) < 0)\n \t\t\t\t\tgoto err;\n \n \t\t\tunsigned long long cycles_per_lookup =\n@@ -1040,7 +1040,7 @@ test_hash_add_ks_lookup_miss(struct rwc_perf *rwc_perf_results, int rwc_lf, int\n \t\t\tif (ret < 0)\n \t\t\t\tgoto err;\n \t\t\tfor (i = 1; i <= rwc_core_cnt[n]; i++)\n-\t\t\t\tif (lcore_config[i].ret < 0)\n+\t\t\t\tif (rte_lcore_return_code(i) < 0)\n \t\t\t\t\tgoto err;\n \n \t\t\tunsigned long long cycles_per_lookup =\n@@ -1141,7 +1141,7 @@ test_hash_multi_add_lookup(struct rwc_perf *rwc_perf_results, int rwc_lf,\n \t\t\t\trte_eal_mp_wait_lcore();\n \n \t\t\t\tfor (i = 1; i <= rwc_core_cnt[n]; i++)\n-\t\t\t\t\tif (lcore_config[i].ret < 0)\n+\t\t\t\t\tif (rte_lcore_return_code(i) < 0)\n \t\t\t\t\t\tgoto err;\n \n \t\t\t\tunsigned long long cycles_per_lookup =\n@@ -1225,7 +1225,7 @@ test_hash_add_ks_lookup_hit_extbkt(struct rwc_perf *rwc_perf_results,\n \t\t\trte_eal_mp_wait_lcore();\n \n \t\t\tfor (i = 1; i <= rwc_core_cnt[n]; i++)\n-\t\t\t\tif (lcore_config[i].ret < 0)\n+\t\t\t\tif (rte_lcore_return_code(i) < 0)\n \t\t\t\t\tgoto err;\n \n \t\t\tunsigned long long cycles_per_lookup =\ndiff --git a/app/test/test_ring_perf.c b/app/test/test_ring_perf.c\nindex ebb3939f51d0..6eccccfe93b4 100644\n--- a/app/test/test_ring_perf.c\n+++ b/app/test/test_ring_perf.c\n@@ -52,10 +52,11 @@ get_two_hyperthreads(struct lcore_pair *lcp)\n \t\tRTE_LCORE_FOREACH(id2) {\n \t\t\tif (id1 == id2)\n \t\t\t\tcontinue;\n-\t\t\tc1 = lcore_config[id1].core_id;\n-\t\t\tc2 = lcore_config[id2].core_id;\n-\t\t\ts1 = lcore_config[id1].socket_id;\n-\t\t\ts2 = lcore_config[id2].socket_id;\n+\n+\t\t\tc1 = rte_lcore_to_cpu_id(id1);\n+\t\t\tc2 = rte_lcore_to_cpu_id(id2);\n+\t\t\ts1 = rte_lcore_to_socket_id(id1);\n+\t\t\ts2 = rte_lcore_to_socket_id(id2);\n \t\t\tif ((c1 == c2) && (s1 == s2)){\n \t\t\t\tlcp->c1 = id1;\n \t\t\t\tlcp->c2 = id2;\n@@ -75,10 +76,11 @@ get_two_cores(struct lcore_pair *lcp)\n \t\tRTE_LCORE_FOREACH(id2) {\n \t\t\tif (id1 == id2)\n \t\t\t\tcontinue;\n-\t\t\tc1 = lcore_config[id1].core_id;\n-\t\t\tc2 = lcore_config[id2].core_id;\n-\t\t\ts1 = lcore_config[id1].socket_id;\n-\t\t\ts2 = lcore_config[id2].socket_id;\n+\n+\t\t\tc1 = rte_lcore_to_cpu_id(id1);\n+\t\t\tc2 = rte_lcore_to_cpu_id(id2);\n+\t\t\ts1 = rte_lcore_to_socket_id(id1);\n+\t\t\ts2 = rte_lcore_to_socket_id(id2);\n \t\t\tif ((c1 != c2) && (s1 == s2)){\n \t\t\t\tlcp->c1 = id1;\n \t\t\t\tlcp->c2 = id2;\n@@ -98,8 +100,8 @@ get_two_sockets(struct lcore_pair *lcp)\n \t\tRTE_LCORE_FOREACH(id2) {\n \t\t\tif (id1 == id2)\n \t\t\t\tcontinue;\n-\t\t\ts1 = lcore_config[id1].socket_id;\n-\t\t\ts2 = lcore_config[id2].socket_id;\n+\t\t\ts1 = rte_lcore_to_socket_id(id1);\n+\t\t\ts2 = rte_lcore_to_socket_id(id2);\n \t\t\tif (s1 != s2){\n \t\t\t\tlcp->c1 = id1;\n \t\t\t\tlcp->c2 = id2;\ndiff --git a/app/test/test_stack_perf.c b/app/test/test_stack_perf.c\nindex ba27fbf7076d..70561fecda0d 100644\n--- a/app/test/test_stack_perf.c\n+++ b/app/test/test_stack_perf.c\n@@ -44,10 +44,10 @@ get_two_hyperthreads(struct lcore_pair *lcp)\n \t\tRTE_LCORE_FOREACH(id[1]) {\n \t\t\tif (id[0] == id[1])\n \t\t\t\tcontinue;\n-\t\t\tcore[0] = lcore_config[id[0]].core_id;\n-\t\t\tcore[1] = lcore_config[id[1]].core_id;\n-\t\t\tsocket[0] = lcore_config[id[0]].socket_id;\n-\t\t\tsocket[1] = lcore_config[id[1]].socket_id;\n+\t\t\tcore[0] = rte_lcore_to_cpu_id(id[0]);\n+\t\t\tcore[1] = rte_lcore_to_cpu_id(id[1]);\n+\t\t\tsocket[0] = rte_lcore_to_socket_id(id[0]);\n+\t\t\tsocket[1] = rte_lcore_to_socket_id(id[1]);\n \t\t\tif ((core[0] == core[1]) && (socket[0] == socket[1])) {\n \t\t\t\tlcp->c1 = id[0];\n \t\t\t\tlcp->c2 = id[1];\n@@ -70,10 +70,10 @@ get_two_cores(struct lcore_pair *lcp)\n \t\tRTE_LCORE_FOREACH(id[1]) {\n \t\t\tif (id[0] == id[1])\n \t\t\t\tcontinue;\n-\t\t\tcore[0] = lcore_config[id[0]].core_id;\n-\t\t\tcore[1] = lcore_config[id[1]].core_id;\n-\t\t\tsocket[0] = lcore_config[id[0]].socket_id;\n-\t\t\tsocket[1] = lcore_config[id[1]].socket_id;\n+\t\t\tcore[0] = rte_lcore_to_cpu_id(id[0]);\n+\t\t\tcore[1] = rte_lcore_to_cpu_id(id[1]);\n+\t\t\tsocket[0] = rte_lcore_to_socket_id(id[0]);\n+\t\t\tsocket[1] = rte_lcore_to_socket_id(id[1]);\n \t\t\tif ((core[0] != core[1]) && (socket[0] == socket[1])) {\n \t\t\t\tlcp->c1 = id[0];\n \t\t\t\tlcp->c2 = id[1];\n@@ -95,8 +95,8 @@ get_two_sockets(struct lcore_pair *lcp)\n \t\tRTE_LCORE_FOREACH(id[1]) {\n \t\t\tif (id[0] == id[1])\n \t\t\t\tcontinue;\n-\t\t\tsocket[0] = lcore_config[id[0]].socket_id;\n-\t\t\tsocket[1] = lcore_config[id[1]].socket_id;\n+\t\t\tsocket[0] = rte_lcore_to_socket_id(id[0]);\n+\t\t\tsocket[1] = rte_lcore_to_socket_id(id[1]);\n \t\t\tif (socket[0] != socket[1]) {\n \t\t\t\tlcp->c1 = id[0];\n \t\t\t\tlcp->c2 = id[1];\n",
    "prefixes": [
        "v2",
        "5/5"
    ]
}