Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52599/?format=api
{ "id": 52599, "url": "http://patches.dpdk.org/api/patches/52599/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190410134517.63896-3-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190410134517.63896-3-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190410134517.63896-3-bruce.richardson@intel.com", "date": "2019-04-10T13:45:17", "name": "[2/2] bpf: remove use of weak functions", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "75253f520620b98ef92d66d9507857a26ad62e42", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190410134517.63896-3-bruce.richardson@intel.com/mbox/", "series": [ { "id": 4242, "url": "http://patches.dpdk.org/api/series/4242/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4242", "date": "2019-04-10T13:45:15", "name": "remove use of weak functions from libraries", "version": 1, "mbox": "http://patches.dpdk.org/series/4242/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/52599/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/52599/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0975E1B113;\n\tWed, 10 Apr 2019 15:45:48 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id A664F1B111\n\tfor <dev@dpdk.org>; Wed, 10 Apr 2019 15:45:46 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t10 Apr 2019 06:45:32 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.222.236])\n\tby orsmga003.jf.intel.com with ESMTP; 10 Apr 2019 06:45:31 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,332,1549958400\"; d=\"scan'208\";a=\"141569368\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "konstantin.ananyev@intel.com,\n\taconole@redhat.com", "Cc": "dev@dpdk.org,\n\tBruce Richardson <bruce.richardson@intel.com>", "Date": "Wed, 10 Apr 2019 14:45:17 +0100", "Message-Id": "<20190410134517.63896-3-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190410134517.63896-1-bruce.richardson@intel.com>", "References": "<20190410134517.63896-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 2/2] bpf: remove use of weak functions", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Weak functions don't work well with static libraries and require the use of\n\"whole-archive\" flag to ensure that the correct function is used when\nlinking. Since the weak function is only used as a placeholder within this\nlibrary alone, we can replace it with a non-weak version protected using\npreprocessor ifdefs.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n lib/librte_bpf/bpf_load.c | 4 +++-\n lib/librte_bpf/meson.build | 1 +\n 2 files changed, 4 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/librte_bpf/bpf_load.c b/lib/librte_bpf/bpf_load.c\nindex d9d163b7d..194103ec7 100644\n--- a/lib/librte_bpf/bpf_load.c\n+++ b/lib/librte_bpf/bpf_load.c\n@@ -131,7 +131,8 @@ rte_bpf_load(const struct rte_bpf_prm *prm)\n \treturn bpf;\n }\n \n-__rte_experimental __rte_weak struct rte_bpf *\n+#ifndef RTE_LIBRTE_BPF_ELF\n+__rte_experimental struct rte_bpf *\n rte_bpf_elf_load(const struct rte_bpf_prm *prm, const char *fname,\n \tconst char *sname)\n {\n@@ -146,3 +147,4 @@ rte_bpf_elf_load(const struct rte_bpf_prm *prm, const char *fname,\n \trte_errno = ENOTSUP;\n \treturn NULL;\n }\n+#endif\ndiff --git a/lib/librte_bpf/meson.build b/lib/librte_bpf/meson.build\nindex 8a79878ff..11c1fb558 100644\n--- a/lib/librte_bpf/meson.build\n+++ b/lib/librte_bpf/meson.build\n@@ -20,6 +20,7 @@ deps += ['mbuf', 'net', 'ethdev']\n \n dep = dependency('libelf', required: false)\n if dep.found()\n+\tdpdk_conf.set('RTE_LIBRTE_BPF_ELF', 1)\n \tsources += files('bpf_load_elf.c')\n \text_deps += dep\n endif\n", "prefixes": [ "2/2" ] }