Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52572/?format=api
{ "id": 52572, "url": "http://patches.dpdk.org/api/patches/52572/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/43e5c460000d04f7f8875189d746da05ab75e50a.1554894242.git.igor.russkikh@aquantia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<43e5c460000d04f7f8875189d746da05ab75e50a.1554894242.git.igor.russkikh@aquantia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/43e5c460000d04f7f8875189d746da05ab75e50a.1554894242.git.igor.russkikh@aquantia.com", "date": "2019-04-10T11:19:02", "name": "[06/10] net/atlantic: macsec firmware interface", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "810080b3c82dc64790577184423a7ba9e5a05a3f", "submitter": { "id": 1124, "url": "http://patches.dpdk.org/api/people/1124/?format=api", "name": "Igor Russkikh", "email": "igor.russkikh@aquantia.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/43e5c460000d04f7f8875189d746da05ab75e50a.1554894242.git.igor.russkikh@aquantia.com/mbox/", "series": [ { "id": 4234, "url": "http://patches.dpdk.org/api/series/4234/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4234", "date": "2019-04-10T11:18:35", "name": "add MACSEC hw offload to atlantic PMD", "version": 1, "mbox": "http://patches.dpdk.org/series/4234/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/52572/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/52572/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 2148F5F36;\n\tWed, 10 Apr 2019 13:19:08 +0200 (CEST)", "from NAM01-SN1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr820073.outbound.protection.outlook.com [40.107.82.73])\n\tby dpdk.org (Postfix) with ESMTP id 0BDB65F1B\n\tfor <dev@dpdk.org>; Wed, 10 Apr 2019 13:19:04 +0200 (CEST)", "from BN8PR11MB3618.namprd11.prod.outlook.com (20.178.219.85) by\n\tBN8PR11MB3540.namprd11.prod.outlook.com (20.178.218.78) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1771.21; Wed, 10 Apr 2019 11:19:02 +0000", "from BN8PR11MB3618.namprd11.prod.outlook.com\n\t([fe80::9d38:1845:842d:a489]) by\n\tBN8PR11MB3618.namprd11.prod.outlook.com\n\t([fe80::9d38:1845:842d:a489%3]) with mapi id 15.20.1771.016;\n\tWed, 10 Apr 2019 11:19:02 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=lYw3S5LZLGZXtSmBSnIuE+fgw76YLxEkEYe+YMVtQqQ=;\n\tb=kaN+Y7XMrcuej01svcRBYoBhSyzvgNmrOFdIfhLxnUy6fp9H/7ft4m1/30rWe9Exz6Qz2LOmz1VWh3i/OSnnviE468DYRKpZRgULNirogS1QKCruxxTaFRPr87oGx+JcKJuct0burWamGtNltdSgWh98K5QXTYmZ+GWx/JlsNTY=", "From": "Igor Russkikh <Igor.Russkikh@aquantia.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>", "CC": "Pavel Belous <Pavel.Belous@aquantia.com>, Wenzhuo Lu\n\t<wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>, Bernard\n\tIremonger <bernard.iremonger@intel.com>, John McNamara\n\t<john.mcnamara@intel.com>, Marko Kovacevic <marko.kovacevic@intel.com>,\n\tKonstantin Ananyev <konstantin.ananyev@intel.com>, Thomas Monjalon\n\t<thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@intel.com>, Andrew\n\tRybchenko <arybchenko@solarflare.com>, Igor Russkikh\n\t<Igor.Russkikh@aquantia.com>", "Thread-Topic": "[PATCH 06/10] net/atlantic: macsec firmware interface", "Thread-Index": "AQHU748zQ9psX1HDFE+0FODu/zRypQ==", "Date": "Wed, 10 Apr 2019 11:19:02 +0000", "Message-ID": "<43e5c460000d04f7f8875189d746da05ab75e50a.1554894242.git.igor.russkikh@aquantia.com>", "References": "<cover.1554894242.git.igor.russkikh@aquantia.com>", "In-Reply-To": "<cover.1554894242.git.igor.russkikh@aquantia.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "BYAPR05CA0061.namprd05.prod.outlook.com\n\t(2603:10b6:a03:74::38) To BN8PR11MB3618.namprd11.prod.outlook.com\n\t(2603:10b6:408:85::21)", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=Igor.Russkikh@aquantia.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-mailer": "git-send-email 2.17.1", "x-originating-ip": "[95.79.108.179]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "22c5dad4-ac72-48a0-bf92-08d6bda6559a", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(2017052603328)(7193020);\n\tSRVR:BN8PR11MB3540; ", "x-ms-traffictypediagnostic": "BN8PR11MB3540:", "x-microsoft-antispam-prvs": "<BN8PR11MB35402450234C4B275A4CA4F6982E0@BN8PR11MB3540.namprd11.prod.outlook.com>", "x-forefront-prvs": "00032065B2", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(396003)(39850400004)(376002)(366004)(136003)(346002)(199004)(189003)(486006)(107886003)(6506007)(316002)(2616005)(386003)(54906003)(7416002)(53936002)(8936002)(68736007)(446003)(6916009)(476003)(72206003)(2501003)(105586002)(11346002)(44832011)(99286004)(2351001)(52116002)(186003)(26005)(118296001)(106356001)(14454004)(102836004)(76176011)(71200400001)(81156014)(7736002)(14444005)(8676002)(81166006)(25786009)(256004)(6116002)(5660300002)(71190400001)(1730700003)(5640700003)(2906002)(66066001)(6512007)(478600001)(6486002)(50226002)(305945005)(97736004)(4326008)(3846002)(36756003)(6436002)(86362001);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:BN8PR11MB3540;\n\tH:BN8PR11MB3618.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: aquantia.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "PF5JezSs03qCSZQsSUNbk3R+W7xg7DBcjxhSDhSJ6cweLtR8AfDYqDDK0RUOKfIs38WUu/A46tD0ssiTqRQGnKvX8RhU89rVPXS6RnBmjzyXJFnXvYzgvkkQxiKkha6IClbWMSRbGgr8tkranv6QR3tfQkMBj0jxLupo9uga7Lk/4GoeFsuAOE6jE1GukRkZbDHeyh6wOa5oZ1S6LV/Q7caEixFqXgQ8kEb1/oGj/ZTQgeGI13Bz9VhCAuNZWlTo0U43Zn/qgMFNX4pH/QynvxaTLkwVZcJctMi0GtsDrr78czxcwKvM/1zHjZZC0YNYOtF5CMBBG+uYVub/SWOoLxpuI1+0K1DftotvnaIKKAf7a07UyuO/17XalCVFbHUoPMXeNVTuqSnKq+XZYG2ucegKMWUgGkWurEKSy7Kfm7o=", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "MIME-Version": "1.0", "X-OriginatorOrg": "aquantia.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "22c5dad4-ac72-48a0-bf92-08d6bda6559a", "X-MS-Exchange-CrossTenant-originalarrivaltime": "10 Apr 2019 11:19:02.1632\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "83e2e134-991c-4ede-8ced-34d47e38e6b1", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BN8PR11MB3540", "Subject": "[dpdk-dev] [PATCH 06/10] net/atlantic: macsec firmware interface", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Pavel Belous <pavel.belous@aquantia.com>\n\nImplementation of firmware interface for macsec configuration.\nStructure with config data is written into FW memory, then we trigger\nFW to execute the request and wait for result.\n\nSigned-off-by: Pavel Belous <pavel.belous@aquantia.com>\nSigned-off-by: Igor Russkikh <igor.russkikh@aquantia.com>\n---\n drivers/net/atlantic/atl_types.h | 2 +\n .../net/atlantic/hw_atl/hw_atl_utils_fw2x.c | 51 +++++++++++++++++++\n 2 files changed, 53 insertions(+)", "diff": "diff --git a/drivers/net/atlantic/atl_types.h b/drivers/net/atlantic/atl_types.h\r\nindex 3cc9e96089e8..dbaf2c635f50 100644\r\n--- a/drivers/net/atlantic/atl_types.h\r\n+++ b/drivers/net/atlantic/atl_types.h\r\n@@ -128,6 +128,8 @@ struct aq_hw_s {\r\n \tstruct hw_atl_stats_s last_stats;\r\n \tstruct aq_stats_s curr_stats;\r\n \r\n+\tu32 caps_lo;\r\n+\r\n \tu64 speed;\r\n \tunsigned int chip_features;\r\n \tu32 fw_ver_actual;\r\ndiff --git a/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c b/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c\r\nindex f215ceb70435..89a3759b89b4 100644\r\n--- a/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c\r\n+++ b/drivers/net/atlantic/hw_atl/hw_atl_utils_fw2x.c\r\n@@ -62,6 +62,7 @@ static int aq_fw2x_set_state(struct aq_hw_s *self,\r\n static int aq_fw2x_init(struct aq_hw_s *self)\r\n {\r\n \tint err = 0;\r\n+\tstruct hw_aq_atl_utils_mbox mbox;\r\n \r\n \t/* check 10 times by 1ms */\r\n \tAQ_HW_WAIT_FOR(0U != (self->mbox_addr =\r\n@@ -70,6 +71,12 @@ static int aq_fw2x_init(struct aq_hw_s *self)\r\n \tAQ_HW_WAIT_FOR(0U != (self->rpc_addr =\r\n \t\t aq_hw_read_reg(self, HW_ATL_FW2X_MPI_RPC_ADDR)),\r\n \t\t 1000U, 100U);\r\n+\r\n+\t/* Read caps */\r\n+\thw_atl_utils_mpi_read_stats(self, &mbox);\r\n+\r\n+\tself->caps_lo = mbox.info.caps_lo;\r\n+\r\n \treturn err;\r\n }\r\n \r\n@@ -623,6 +630,49 @@ static int aq_fw2x_set_eeprom(struct aq_hw_s *self, int dev_addr,\r\n \treturn 0;\r\n }\r\n \r\n+static int aq_fw2x_send_macsec_request(struct aq_hw_s *self,\r\n+\t\t\t\tstruct macsec_msg_fw_request *req,\r\n+\t\t\t\tstruct macsec_msg_fw_response *response)\r\n+{\r\n+\tint err = 0;\r\n+\tu32 mpi_opts = 0;\r\n+\r\n+\tif (!response || !response)\r\n+\t\treturn 0;\r\n+\r\n+\tif ((self->caps_lo & BIT(CAPS_LO_MACSEC)) == 0)\r\n+\t\treturn -EOPNOTSUPP;\r\n+\r\n+\t/* Write macsec request to cfg memory */\r\n+\terr = hw_atl_utils_fw_upload_dwords(self, self->rpc_addr,\r\n+\t\t(u32 *)(void *)req,\r\n+\t\tRTE_ALIGN(sizeof(*req) / sizeof(u32), sizeof(u32)));\r\n+\r\n+\tif (err < 0)\r\n+\t\treturn err;\r\n+\r\n+\t/* Toggle 0x368.CAPS_LO_MACSEC bit */\r\n+\tmpi_opts = aq_hw_read_reg(self, HW_ATL_FW2X_MPI_CONTROL_ADDR);\r\n+\tmpi_opts ^= BIT(CAPS_LO_MACSEC);\r\n+\r\n+\taq_hw_write_reg(self, HW_ATL_FW2X_MPI_CONTROL_ADDR, mpi_opts);\r\n+\r\n+\t/* Wait until REQUEST_BIT matched in 0x370 */\r\n+\tAQ_HW_WAIT_FOR((aq_hw_read_reg(self, HW_ATL_FW2X_MPI_STATE_ADDR) &\r\n+\t\tBIT(CAPS_LO_MACSEC)) == (mpi_opts & BIT(CAPS_LO_MACSEC)),\r\n+\t\t1000U, 10000U);\r\n+\r\n+\tif (err < 0)\r\n+\t\treturn err;\r\n+\r\n+\t/* Read status of write operation */\r\n+\terr = hw_atl_utils_fw_downld_dwords(self, self->rpc_addr + sizeof(u32),\r\n+\t\t(u32 *)(void *)response,\r\n+\t\tRTE_ALIGN(sizeof(*response) / sizeof(u32), sizeof(u32)));\r\n+\r\n+\treturn err;\r\n+}\r\n+\r\n const struct aq_fw_ops aq_fw_2x_ops = {\r\n \t.init = aq_fw2x_init,\r\n \t.deinit = aq_fw2x_deinit,\r\n@@ -641,4 +691,5 @@ const struct aq_fw_ops aq_fw_2x_ops = {\r\n \t.led_control = aq_fw2x_led_control,\r\n \t.get_eeprom = aq_fw2x_get_eeprom,\r\n \t.set_eeprom = aq_fw2x_set_eeprom,\r\n+\t.send_macsec_req = aq_fw2x_send_macsec_request,\r\n };\r\n", "prefixes": [ "06/10" ] }