Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52568/?format=api
{ "id": 52568, "url": "http://patches.dpdk.org/api/patches/52568/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/123a93a371be657e3e8481379db6f151350d4f90.1554894242.git.igor.russkikh@aquantia.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<123a93a371be657e3e8481379db6f151350d4f90.1554894242.git.igor.russkikh@aquantia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/123a93a371be657e3e8481379db6f151350d4f90.1554894242.git.igor.russkikh@aquantia.com", "date": "2019-04-10T11:18:44", "name": "[02/10] app/testpmd: use generic MACSEC API calls", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "3ce1422b324c805a5e6e762959ff6aa01a05dd23", "submitter": { "id": 1124, "url": "http://patches.dpdk.org/api/people/1124/?format=api", "name": "Igor Russkikh", "email": "igor.russkikh@aquantia.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/123a93a371be657e3e8481379db6f151350d4f90.1554894242.git.igor.russkikh@aquantia.com/mbox/", "series": [ { "id": 4234, "url": "http://patches.dpdk.org/api/series/4234/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4234", "date": "2019-04-10T11:18:35", "name": "add MACSEC hw offload to atlantic PMD", "version": 1, "mbox": "http://patches.dpdk.org/series/4234/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/52568/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/52568/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 248B458CB;\n\tWed, 10 Apr 2019 13:18:48 +0200 (CEST)", "from NAM03-CO1-obe.outbound.protection.outlook.com\n\t(mail-eopbgr790073.outbound.protection.outlook.com [40.107.79.73])\n\tby dpdk.org (Postfix) with ESMTP id 180D756A1\n\tfor <dev@dpdk.org>; Wed, 10 Apr 2019 13:18:46 +0200 (CEST)", "from BN8PR11MB3618.namprd11.prod.outlook.com (20.178.219.85) by\n\tBN8PR11MB3540.namprd11.prod.outlook.com (20.178.218.78) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1771.21; Wed, 10 Apr 2019 11:18:44 +0000", "from BN8PR11MB3618.namprd11.prod.outlook.com\n\t([fe80::9d38:1845:842d:a489]) by\n\tBN8PR11MB3618.namprd11.prod.outlook.com\n\t([fe80::9d38:1845:842d:a489%3]) with mapi id 15.20.1771.016;\n\tWed, 10 Apr 2019 11:18:44 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=AQUANTIA1COM.onmicrosoft.com; s=selector1-aquantia-com;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=J11C+mo7XHreX3ZBaPv19Chh6VjRQzY/yBBvi1DDCUQ=;\n\tb=fM0xKFGB3cIgb3YvULiiBq4RjUfrX3WxaaRfHd+U6DM1TmzWbZovVLO/UTOE3TFWOCubkuS5aOU4yFb781Snbs19wO7tCvJ1b6hB7Vnoi5ki2lJgA5X0VAcrciDHKg/Z5fFBsSD/udB0J6bNNTXvPf2hp4Fvx8EYP7hXOHndTd4=", "From": "Igor Russkikh <Igor.Russkikh@aquantia.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>", "CC": "Pavel Belous <Pavel.Belous@aquantia.com>, Wenzhuo Lu\n\t<wenzhuo.lu@intel.com>, Jingjing Wu <jingjing.wu@intel.com>, Bernard\n\tIremonger <bernard.iremonger@intel.com>, John McNamara\n\t<john.mcnamara@intel.com>, Marko Kovacevic <marko.kovacevic@intel.com>,\n\tKonstantin Ananyev <konstantin.ananyev@intel.com>, Thomas Monjalon\n\t<thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@intel.com>, Andrew\n\tRybchenko <arybchenko@solarflare.com>, Igor Russkikh\n\t<Igor.Russkikh@aquantia.com>", "Thread-Topic": "[PATCH 02/10] app/testpmd: use generic MACSEC API calls", "Thread-Index": "AQHU748oEXpx8Dpp7Uy3q8NBnBnfSg==", "Date": "Wed, 10 Apr 2019 11:18:44 +0000", "Message-ID": "<123a93a371be657e3e8481379db6f151350d4f90.1554894242.git.igor.russkikh@aquantia.com>", "References": "<cover.1554894242.git.igor.russkikh@aquantia.com>", "In-Reply-To": "<cover.1554894242.git.igor.russkikh@aquantia.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "BYAPR05CA0061.namprd05.prod.outlook.com\n\t(2603:10b6:a03:74::38) To BN8PR11MB3618.namprd11.prod.outlook.com\n\t(2603:10b6:408:85::21)", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=Igor.Russkikh@aquantia.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-mailer": "git-send-email 2.17.1", "x-originating-ip": "[95.79.108.179]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "d9fc63da-4a23-45f2-a5f9-08d6bda64b21", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(2017052603328)(7193020);\n\tSRVR:BN8PR11MB3540; ", "x-ms-traffictypediagnostic": "BN8PR11MB3540:", "x-microsoft-antispam-prvs": "<BN8PR11MB354097FBF06C3E5468A87892982E0@BN8PR11MB3540.namprd11.prod.outlook.com>", "x-forefront-prvs": "00032065B2", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(396003)(39850400004)(376002)(366004)(136003)(346002)(199004)(189003)(486006)(107886003)(6506007)(316002)(2616005)(386003)(54906003)(7416002)(53936002)(8936002)(68736007)(446003)(6916009)(476003)(72206003)(2501003)(105586002)(11346002)(44832011)(99286004)(2351001)(52116002)(186003)(26005)(118296001)(106356001)(14454004)(102836004)(76176011)(71200400001)(81156014)(7736002)(8676002)(81166006)(25786009)(256004)(6116002)(5660300002)(71190400001)(1730700003)(5640700003)(2906002)(66066001)(6512007)(478600001)(6486002)(50226002)(305945005)(97736004)(4326008)(3846002)(36756003)(6436002)(86362001)(41533002);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:BN8PR11MB3540;\n\tH:BN8PR11MB3618.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: aquantia.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "SCF1n4+9s8pxas+rTyUoxB2daKDXT16L2kg9Te7BeDdPCSEufR0Tj1OBM7LkNKwx/wUiCnNcm2cvWbn/ZpVI2XxrScg2jl2bI4qJNBtoq5AH+FUUjKmNhfYnN+pK9ex2jlgp9VBEcUESnSzff/sengK8urYgHn+xJ/e2Mflryv2JllMlZbkNaUK5llyHQaeU+x/EXVy8q8OepCCPRDcpNMcf8kD4Gx3trbc6imvzHyMaJyBrWptB4F8fVgxbBsXr/WqxInii1M6+U1TgOiCeEm4v0aZpoVvdpXOk4z9BjjtI5nbJ2SR09tzmSPVThFNiTIT8lwqL+gFC0ZWIz75hNOvnw1gIRh7kzlkDk6cY92Jhc4eLaclgk21VOQ/KaSYgCOMkrJb2vxqlgB4RhQ1tlcrfuIxOkcLH8AmbB+esqYQ=", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "base64", "MIME-Version": "1.0", "X-OriginatorOrg": "aquantia.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "d9fc63da-4a23-45f2-a5f9-08d6bda64b21", "X-MS-Exchange-CrossTenant-originalarrivaltime": "10 Apr 2019 11:18:44.5293\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "83e2e134-991c-4ede-8ced-34d47e38e6b1", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "BN8PR11MB3540", "Subject": "[dpdk-dev] [PATCH 02/10] app/testpmd: use generic MACSEC API calls", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Here we do repace testpmd direct usage of IXGBE driver calls\nwith generic ethdev macsec API calls\n\nSigned-off-by: Igor Russkikh <igor.russkikh@aquantia.com>\n---\n app/test-pmd/cmdline.c | 20 ++++++--------------\n 1 file changed, 6 insertions(+), 14 deletions(-)", "diff": "diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c\r\nindex 2ab03c111316..1730c76fe65c 100644\r\n--- a/app/test-pmd/cmdline.c\r\n+++ b/app/test-pmd/cmdline.c\r\n@@ -13958,9 +13958,7 @@ cmd_set_macsec_offload_on_parsed(\r\n \r\n \trte_eth_dev_info_get(port_id, &dev_info);\r\n \tif (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MACSEC_INSERT) {\r\n-#ifdef RTE_LIBRTE_IXGBE_PMD\r\n-\t\tret = rte_pmd_ixgbe_macsec_enable(port_id, en, rp);\r\n-#endif\r\n+\t\tret = rte_eth_macsec_enable(port_id, en, rp);\r\n \t}\r\n \tRTE_SET_USED(en);\r\n \tRTE_SET_USED(rp);\r\n@@ -14052,9 +14050,7 @@ cmd_set_macsec_offload_off_parsed(\r\n \r\n \trte_eth_dev_info_get(port_id, &dev_info);\r\n \tif (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MACSEC_INSERT) {\r\n-#ifdef RTE_LIBRTE_IXGBE_PMD\r\n-\t\tret = rte_pmd_ixgbe_macsec_disable(port_id);\r\n-#endif\r\n+\t\tret = rte_eth_macsec_disable(port_id);\r\n \t}\r\n \tswitch (ret) {\r\n \tcase 0:\r\n@@ -14138,13 +14134,11 @@ cmd_set_macsec_sc_parsed(\r\n \tint ret = -ENOTSUP;\r\n \tint is_tx = (strcmp(res->tx_rx, \"tx\") == 0) ? 1 : 0;\r\n \r\n-#ifdef RTE_LIBRTE_IXGBE_PMD\r\n \tret = is_tx ?\r\n-\t\trte_pmd_ixgbe_macsec_config_txsc(res->port_id,\r\n+\t\trte_eth_macsec_config_txsc(res->port_id,\r\n \t\t\t\tres->mac.addr_bytes) :\r\n-\t\trte_pmd_ixgbe_macsec_config_rxsc(res->port_id,\r\n+\t\trte_eth_macsec_config_rxsc(res->port_id,\r\n \t\t\t\tres->mac.addr_bytes, res->pi);\r\n-#endif\r\n \tRTE_SET_USED(is_tx);\r\n \r\n \tswitch (ret) {\r\n@@ -14257,13 +14251,11 @@ cmd_set_macsec_sa_parsed(\r\n \t\tkey[i] = (uint8_t) ((xdgt0 * 16) + xdgt1);\r\n \t}\r\n \r\n-#ifdef RTE_LIBRTE_IXGBE_PMD\r\n \tret = is_tx ?\r\n-\t\trte_pmd_ixgbe_macsec_select_txsa(res->port_id,\r\n+\t\trte_eth_macsec_select_txsa(res->port_id,\r\n \t\t\tres->idx, res->an, res->pn, key) :\r\n-\t\trte_pmd_ixgbe_macsec_select_rxsa(res->port_id,\r\n+\t\trte_eth_macsec_select_rxsa(res->port_id,\r\n \t\t\tres->idx, res->an, res->pn, key);\r\n-#endif\r\n \tRTE_SET_USED(is_tx);\r\n \tRTE_SET_USED(key);\r\n \r\n", "prefixes": [ "02/10" ] }