Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 52434,
    "url": "http://patches.dpdk.org/api/patches/52434/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190408164112.12471-1-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20190408164112.12471-1-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20190408164112.12471-1-stephen@networkplumber.org",
    "date": "2019-04-08T16:41:12",
    "name": "[v2] net/af_packet: fix vlan_insert corruption",
    "commit_ref": null,
    "pull_url": null,
    "state": "rejected",
    "archived": true,
    "hash": "ac397cb874b7d4710d0d33f7a695f86301c6f7b7",
    "submitter": {
        "id": 27,
        "url": "http://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190408164112.12471-1-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 4187,
            "url": "http://patches.dpdk.org/api/series/4187/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4187",
            "date": "2019-04-08T16:41:12",
            "name": "[v2] net/af_packet: fix vlan_insert corruption",
            "version": 2,
            "mbox": "http://patches.dpdk.org/series/4187/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/52434/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/52434/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 0F6B34F93;\n\tMon,  8 Apr 2019 18:41:19 +0200 (CEST)",
            "from mail-pf1-f196.google.com (mail-pf1-f196.google.com\n\t[209.85.210.196]) by dpdk.org (Postfix) with ESMTP id 902254F91\n\tfor <dev@dpdk.org>; Mon,  8 Apr 2019 18:41:17 +0200 (CEST)",
            "by mail-pf1-f196.google.com with SMTP id y13so7929501pfm.11\n\tfor <dev@dpdk.org>; Mon, 08 Apr 2019 09:41:17 -0700 (PDT)",
            "from shemminger-XPS-13-9360.lan (204-195-22-127.wavecable.com.\n\t[204.195.22.127]) by smtp.gmail.com with ESMTPSA id\n\tw1sm5698720pfw.101.2019.04.08.09.41.14\n\t(version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 08 Apr 2019 09:41:15 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=networkplumber-org.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=AJmCqw5CONEe+LTUHHLS48kczS+WPJM5+EAzh1CYMOU=;\n\tb=TSn33g8C8SKSB0yEMugVjLhiG2Ja/9EKR0oIcJvZ4w3cjMxe755m2J9UbOGE6IUzAJ\n\tpmjThpQHrWRCSYcr6OypMJkvE7MKHVQc2u8fLKYVOYcHNpwAQaRpT2j+2xG9J0H6wUSB\n\thRKwKzzWC+dJE6bivYPAFGaEsves4N26cq4vVeaEGAeMV1gOCtAfDqOHMZxdp9HMfkLk\n\txU1JfaJ2lqeRE85MpcxGsLKaLcNlCqruCwOmxQW8MLrg5Q65jDOmIQOX/8zoj31YGmkR\n\tDQZdqJEQyJGJuHC4ppx5zpoi7L52kgJFgf9MGLJuTOWqo+wvoSvahY4OmdwHfmCn6YSf\n\tlPng==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=AJmCqw5CONEe+LTUHHLS48kczS+WPJM5+EAzh1CYMOU=;\n\tb=qiosK9kwNSEjyRBw3T5n0oz+uCcAR+E3sI37X4pMVNfU/u7GZF2BKEPSR6T/KBL4md\n\tL4k8MG2nDVB1DOqzEI2i+pcrcB7t+AaSHZzmRwP2NRUF7PLp1kfVkd2s7F/34Cw1d011\n\tTcPEd2t/PLIAJrNH8lNRbwR8sjLPVvsN+BUpCCWhe779j1VHTpWtnVLj0YDuKPucQs3Q\n\tmGKA3qHCbv375J9BpoRw4QCiKaUD1evIc1/98DeVyVXU8r5DMzp3iJ36XuRFlJnA6TEm\n\tVdxe+7H2eVxgdw0NWU4rUOSK2PJAPKpPMT5qP5NOyiQCU1nSy7AmuYcu+38wamEjOL7t\n\tBnXQ==",
        "X-Gm-Message-State": "APjAAAX0j8zeD2Qn3cePDrLfzIB6Tw4v5laLu3+2aaMDJb1EutAbZMrZ\n\tQB15/YpX/YFMfZp/PtAShD0EnP/E4U7i1g==",
        "X-Google-Smtp-Source": "APXvYqwD5iGioEyxOr24NuLGzepTR9w71lW4RulCDej/FPz6P3PCFUPg3c/lyo3XwBFqMQU1vLLgUQ==",
        "X-Received": "by 2002:a63:4a5a:: with SMTP id\n\tj26mr29373857pgl.361.1554741676222; \n\tMon, 08 Apr 2019 09:41:16 -0700 (PDT)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>",
        "Date": "Mon,  8 Apr 2019 09:41:12 -0700",
        "Message-Id": "<20190408164112.12471-1-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.17.1",
        "In-Reply-To": "<20190408160419.7409-1-stephen@networkplumber.org>",
        "References": "<20190408160419.7409-1-stephen@networkplumber.org>",
        "Subject": "[dpdk-dev] [PATCH v2] net/af_packet: fix vlan_insert corruption",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "If the af_packet transmit is sending a VLAN packet,\nand the transmit path to the kernel os full, then it would\nmismanage the outgoing mbuf. The original mbuf would end up\nbeing freed twice, once by AF_PACKET PMD and once by caller.\n\nReported-by: Chas Williams <3chas3@gmail.com>\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\nv2 - fix unnecessary parenthesis (was in original code)\n\n drivers/net/af_packet/rte_eth_af_packet.c | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)",
    "diff": "diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c\nindex 99e13fe48a30..91ceb94ecbaa 100644\n--- a/drivers/net/af_packet/rte_eth_af_packet.c\n+++ b/drivers/net/af_packet/rte_eth_af_packet.c\n@@ -200,6 +200,11 @@ eth_af_packet_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t\t\tcontinue;\n \t\t}\n \n+\t\t/* point at the next incoming frame */\n+\t\tif (ppd->tp_status != TP_STATUS_AVAILABLE &&\n+\t\t    poll(&pfd, 1, -1) < 0)\n+\t\t\tbreak;\n+\n \t\t/* insert vlan info if necessary */\n \t\tif (mbuf->ol_flags & PKT_TX_VLAN_PKT) {\n \t\t\tif (rte_vlan_insert(&mbuf)) {\n@@ -208,11 +213,6 @@ eth_af_packet_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t\t\t}\n \t\t}\n \n-\t\t/* point at the next incoming frame */\n-\t\tif ((ppd->tp_status != TP_STATUS_AVAILABLE) &&\n-\t\t    (poll(&pfd, 1, -1) < 0))\n-\t\t\tbreak;\n-\n \t\t/* copy the tx frame data */\n \t\tpbuf = (uint8_t *) ppd + TPACKET2_HDRLEN -\n \t\t\tsizeof(struct sockaddr_ll);\n",
    "prefixes": [
        "v2"
    ]
}