Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52414/?format=api
{ "id": 52414, "url": "http://patches.dpdk.org/api/patches/52414/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1554745507-15089-10-git-send-email-g.singh@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1554745507-15089-10-git-send-email-g.singh@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1554745507-15089-10-git-send-email-g.singh@nxp.com", "date": "2019-04-08T11:22:42", "name": "[09/13] net/enetc: add MTU update and jumbo frames support", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f2c597d7325a30515315e21243d0095faa0f1054", "submitter": { "id": 1068, "url": "http://patches.dpdk.org/api/people/1068/?format=api", "name": "Gagandeep Singh", "email": "g.singh@nxp.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1554745507-15089-10-git-send-email-g.singh@nxp.com/mbox/", "series": [ { "id": 4173, "url": "http://patches.dpdk.org/api/series/4173/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4173", "date": "2019-04-08T11:22:28", "name": "ENETC PMD basic features and bug fixes", "version": 1, "mbox": "http://patches.dpdk.org/series/4173/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/52414/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/52414/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 7F2AE5B36;\n\tMon, 8 Apr 2019 13:23:05 +0200 (CEST)", "from EUR02-AM5-obe.outbound.protection.outlook.com\n\t(mail-eopbgr00044.outbound.protection.outlook.com [40.107.0.44])\n\tby dpdk.org (Postfix) with ESMTP id D7B7E4D3A\n\tfor <dev@dpdk.org>; Mon, 8 Apr 2019 13:22:43 +0200 (CEST)", "from VE1PR04MB6365.eurprd04.prod.outlook.com (10.255.118.78) by\n\tVE1PR04MB6606.eurprd04.prod.outlook.com (20.179.235.10) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1771.13; Mon, 8 Apr 2019 11:22:42 +0000", "from VE1PR04MB6365.eurprd04.prod.outlook.com\n\t([fe80::f5ad:f178:4c55:13e0]) by\n\tVE1PR04MB6365.eurprd04.prod.outlook.com\n\t([fe80::f5ad:f178:4c55:13e0%3]) with mapi id 15.20.1771.016;\n\tMon, 8 Apr 2019 11:22:42 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=ZGIK045+WVM4l7OyAkisxiexILW5QxNVeFDP0J8waf8=;\n\tb=PTUly9lgVnRvPgHq+nuYWyLoGW1J0KxgZk2Y6ZUMKdcoFxYzvpyNtilszrVnRf0oYV0Z8o50GdLAr2ftH+39JY64KkZM4P/N40uQ0+6mdyKD3nlHOzR0fxccyaksgWASApJiErageJkfVgslQ3GDnoSnpzvQwpatdIUNGdPSVZU=", "From": "Gagandeep Singh <G.Singh@nxp.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>, \"ferruh.yigit@intel.com\"\n\t<ferruh.yigit@intel.com>", "CC": "Gagandeep Singh <G.Singh@nxp.com>", "Thread-Topic": "[PATCH 09/13] net/enetc: add MTU update and jumbo frames\n\tsupport", "Thread-Index": "AQHU7f1hAK/P3tg84U6jjxBMN0gpSQ==", "Date": "Mon, 8 Apr 2019 11:22:42 +0000", "Message-ID": "<1554745507-15089-10-git-send-email-g.singh@nxp.com>", "References": "<1554745507-15089-1-git-send-email-g.singh@nxp.com>", "In-Reply-To": "<1554745507-15089-1-git-send-email-g.singh@nxp.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "BM1PR0101CA0003.INDPRD01.PROD.OUTLOOK.COM\n\t(2603:1096:b00:18::13) To VE1PR04MB6365.eurprd04.prod.outlook.com\n\t(2603:10a6:803:12a::14)", "x-mailer": "git-send-email 1.9.1", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=G.Singh@nxp.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-originating-ip": "[92.120.1.67]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "7abe5eac-06af-4bb6-0be2-08d6bc14841a", "x-ms-office365-filtering-ht": "Tenant", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(5600139)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020);\n\tSRVR:VE1PR04MB6606; ", "x-ms-traffictypediagnostic": "VE1PR04MB6606:", "x-microsoft-antispam-prvs": "<VE1PR04MB6606C5B988996493955A5FA5E12C0@VE1PR04MB6606.eurprd04.prod.outlook.com>", "x-forefront-prvs": "0001227049", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(366004)(376002)(346002)(39860400002)(396003)(136003)(199004)(189003)(76176011)(97736004)(81156014)(71200400001)(71190400001)(15650500001)(72206003)(3846002)(25786009)(81166006)(53936002)(2616005)(5660300002)(6116002)(8676002)(7736002)(446003)(478600001)(8936002)(11346002)(305945005)(2906002)(256004)(14444005)(66066001)(6512007)(476003)(6436002)(486006)(50226002)(2501003)(99286004)(106356001)(86362001)(110136005)(4326008)(6486002)(68736007)(105586002)(6506007)(52116002)(316002)(26005)(386003)(14454004)(186003)(36756003)(102836004);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6606;\n\tH:VE1PR04MB6365.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "POoKhsPXLM0XhVQSd2pJVHr/mKYkikGJvwgW22zmDOcKXoQoMbgWrtmKRTQV/TYXR1ENxKaAS/zAnQVxsNKm0ugOYd3qr9prqF5rEmJ5ZPdPuJVctq2RP/fYMjw1b8hG0JfB0YRZXrTtJRGybAQwpCR1SbuNRH2jkrDAKdDFzye6AopBYr68tfO0LXuP4xLmETwchx+48yE7d+1MiCHYmQdX/Hur6GBDUBavLdQHZHeu09sV2Iph8BxccsESJnqKILW6lQ1P7hp2BJavib1ANEkequ+e9XmdIOBKIH2kaVD3iDfXdlZMBLg+Zb66RZeyWXerTA34dYLN99itd+sQSjIoLIBls8r8PpQ4MxODBYU2iPhVnhuSJwUd5h3jtyb1wsqXYDswyKZWTngQVep2JrzO7vW3Wp4rn7ndgPfziy4=", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "7abe5eac-06af-4bb6-0be2-08d6bc14841a", "X-MS-Exchange-CrossTenant-originalarrivaltime": "08 Apr 2019 11:22:42.6234\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VE1PR04MB6606", "Subject": "[dpdk-dev] [PATCH 09/13] net/enetc: add MTU update and jumbo frames\n\tsupport", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Enable the jumbo frames and mtu update feature.\n\nSigned-off-by: Gagandeep Singh <g.singh@nxp.com>\n---\n doc/guides/nics/enetc.rst | 1 +\n doc/guides/nics/features/enetc.ini | 2 +\n drivers/net/enetc/base/enetc_hw.h | 6 ++-\n drivers/net/enetc/enetc.h | 5 +++\n drivers/net/enetc/enetc_ethdev.c | 86 ++++++++++++++++++++++++++++++++++----\n 5 files changed, 91 insertions(+), 9 deletions(-)", "diff": "diff --git a/doc/guides/nics/enetc.rst b/doc/guides/nics/enetc.rst\nindex ab13211..eeb0752 100644\n--- a/doc/guides/nics/enetc.rst\n+++ b/doc/guides/nics/enetc.rst\n@@ -49,6 +49,7 @@ ENETC Features\n - Basic stats\n - Promiscuous\n - Multicast\n+- Jumbo packets\n \n NIC Driver (PMD)\n ~~~~~~~~~~~~~~~~\ndiff --git a/doc/guides/nics/features/enetc.ini b/doc/guides/nics/features/enetc.ini\nindex 6b7bbfb..0eed2cb 100644\n--- a/doc/guides/nics/features/enetc.ini\n+++ b/doc/guides/nics/features/enetc.ini\n@@ -9,6 +9,8 @@ Link status = Y\n Basic stats = Y\n Promiscuous mode = Y\n Allmulticast mode = Y\n+MTU update = Y\n+Jumbo frame = Y\n Linux VFIO = Y\n ARMv8 = Y\n Usage doc = Y\ndiff --git a/drivers/net/enetc/base/enetc_hw.h b/drivers/net/enetc/base/enetc_hw.h\nindex 90a383a..2eb1df3 100644\n--- a/drivers/net/enetc/base/enetc_hw.h\n+++ b/drivers/net/enetc/base/enetc_hw.h\n@@ -99,7 +99,11 @@\n #define ENETC_PM0_RX_EN\t\t\tBIT(1)\n \n #define ENETC_PM0_MAXFRM\t\t0x08014\n-#define ENETC_SET_MAXFRM(val)\t\t((val) << 16)\n+#define ENETC_SET_TX_MTU(val)\t\t((val) << 16)\n+#define ENETC_SET_MAXFRM(val)\t\t((val) & 0xffff)\n+#define ENETC_PTXMBAR\t\t\t0x0608\n+/* n = TC index [0..7] */\n+#define ENETC_PTCMSDUR(n)\t\t(0x2020 + (n) * 4)\n \n #define ENETC_PM0_STATUS\t\t0x08304\n #define ENETC_LINK_MODE\t\t\t0x0000000000080000ULL\ndiff --git a/drivers/net/enetc/enetc.h b/drivers/net/enetc/enetc.h\nindex 56454dc..e494eb8 100644\n--- a/drivers/net/enetc/enetc.h\n+++ b/drivers/net/enetc/enetc.h\n@@ -24,6 +24,11 @@\n /* BD ALIGN */\n #define BD_ALIGN 8\n \n+/* minimum frame size supported */\n+#define ENETC_MAC_MINFRM_SIZE\t68\n+/* maximum frame size supported */\n+#define ENETC_MAC_MAXFRM_SIZE\t9600\n+\n /*\n * upper_32_bits - return bits 32-63 of a number\n * @n: the number we're accessing\ndiff --git a/drivers/net/enetc/enetc_ethdev.c b/drivers/net/enetc/enetc_ethdev.c\nindex 0bb3b2c..4428678 100644\n--- a/drivers/net/enetc/enetc_ethdev.c\n+++ b/drivers/net/enetc/enetc_ethdev.c\n@@ -11,13 +11,6 @@\n int enetc_logtype_pmd;\n \n static int\n-enetc_dev_configure(struct rte_eth_dev *dev __rte_unused)\n-{\n-\tPMD_INIT_FUNC_TRACE();\n-\treturn 0;\n-}\n-\n-static int\n enetc_dev_start(struct rte_eth_dev *dev)\n {\n \tstruct enetc_eth_hw *hw =\n@@ -168,7 +161,8 @@\n \t};\n \tdev_info->max_rx_queues = MAX_RX_RINGS;\n \tdev_info->max_tx_queues = MAX_TX_RINGS;\n-\tdev_info->max_rx_pktlen = 1500;\n+\tdev_info->max_rx_pktlen = ENETC_MAC_MAXFRM_SIZE;\n+\tdev_info->rx_offload_capa = DEV_RX_OFFLOAD_JUMBO_FRAME;\n }\n \n static int\n@@ -602,6 +596,76 @@ int enetc_stats_get(struct rte_eth_dev *dev,\n \tenetc_port_wr(enetc_hw, ENETC_PSIPMR, psipmr);\n }\n \n+static int\n+enetc_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)\n+{\n+\tstruct enetc_eth_hw *hw =\n+\t\tENETC_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n+\tstruct enetc_hw *enetc_hw = &hw->hw;\n+\tuint32_t frame_size = mtu + ETHER_HDR_LEN + ETHER_CRC_LEN;\n+\n+\t/* check that mtu is within the allowed range */\n+\tif (mtu < ENETC_MAC_MINFRM_SIZE || frame_size > ENETC_MAC_MAXFRM_SIZE)\n+\t\treturn -EINVAL;\n+\n+\t/*\n+\t * Refuse mtu that requires the support of scattered packets\n+\t * when this feature has not been enabled before.\n+\t */\n+\tif (dev->data->min_rx_buf_size &&\n+\t\t!dev->data->scattered_rx && frame_size >\n+\t\tdev->data->min_rx_buf_size - RTE_PKTMBUF_HEADROOM) {\n+\t\tENETC_PMD_ERR(\"SG not enabled, will not fit in one buffer\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tif (frame_size > ETHER_MAX_LEN)\n+\t\tdev->data->dev_conf.rxmode.offloads &=\n+\t\t\t\t\t\tDEV_RX_OFFLOAD_JUMBO_FRAME;\n+\telse\n+\t\tdev->data->dev_conf.rxmode.offloads &=\n+\t\t\t\t\t\t~DEV_RX_OFFLOAD_JUMBO_FRAME;\n+\n+\tenetc_port_wr(enetc_hw, ENETC_PTCMSDUR(0), ENETC_MAC_MAXFRM_SIZE);\n+\tenetc_port_wr(enetc_hw, ENETC_PTXMBAR, 2 * ENETC_MAC_MAXFRM_SIZE);\n+\n+\tdev->data->dev_conf.rxmode.max_rx_pkt_len = frame_size;\n+\n+\t/*setting the MTU*/\n+\tenetc_port_wr(enetc_hw, ENETC_PM0_MAXFRM, ENETC_SET_MAXFRM(frame_size) |\n+\t\t ENETC_SET_TX_MTU(ENETC_MAC_MAXFRM_SIZE));\n+\n+\treturn 0;\n+}\n+\n+static int\n+enetc_dev_configure(struct rte_eth_dev *dev)\n+{\n+\tstruct rte_eth_conf *eth_conf = &dev->data->dev_conf;\n+\tuint64_t rx_offloads = eth_conf->rxmode.offloads;\n+\tstruct enetc_eth_hw *hw =\n+\t\tENETC_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n+\tstruct enetc_hw *enetc_hw = &hw->hw;\n+\n+\tPMD_INIT_FUNC_TRACE();\n+\n+\tif (rx_offloads & DEV_RX_OFFLOAD_JUMBO_FRAME) {\n+\t\tuint32_t max_len;\n+\n+\t\tmax_len = dev->data->dev_conf.rxmode.max_rx_pkt_len;\n+\n+\t\tenetc_port_wr(enetc_hw, ENETC_PM0_MAXFRM,\n+\t\t\t ENETC_SET_MAXFRM(max_len));\n+\t\tenetc_port_wr(enetc_hw, ENETC_PTCMSDUR(0),\n+\t\t\t ENETC_MAC_MAXFRM_SIZE);\n+\t\tenetc_port_wr(enetc_hw, ENETC_PTXMBAR,\n+\t\t\t 2 * ENETC_MAC_MAXFRM_SIZE);\n+\t\tdev->data->mtu = ETHER_MAX_LEN - ETHER_HDR_LEN - ETHER_CRC_LEN;\n+\t}\n+\n+\treturn 0;\n+}\n+\n /*\n * The set of PCI devices this driver supports\n */\n@@ -625,6 +689,7 @@ int enetc_stats_get(struct rte_eth_dev *dev,\n \t.allmulticast_enable = enetc_allmulticast_enable,\n \t.allmulticast_disable = enetc_allmulticast_disable,\n \t.dev_infos_get = enetc_dev_infos_get,\n+\t.mtu_set = enetc_mtu_set,\n \t.rx_queue_setup = enetc_rx_queue_setup,\n \t.rx_queue_release = enetc_rx_queue_release,\n \t.tx_queue_setup = enetc_tx_queue_setup,\n@@ -679,6 +744,11 @@ int enetc_stats_get(struct rte_eth_dev *dev,\n \tether_addr_copy((struct ether_addr *)hw->mac.addr,\n \t\t\tð_dev->data->mac_addrs[0]);\n \n+\t/* Set MTU */\n+\tenetc_port_wr(&hw->hw, ENETC_PM0_MAXFRM,\n+\t\t ENETC_SET_MAXFRM(ETHER_MAX_LEN));\n+\teth_dev->data->mtu = ETHER_MAX_LEN - ETHER_HDR_LEN - ETHER_CRC_LEN;\n+\n \tENETC_PMD_DEBUG(\"port_id %d vendorID=0x%x deviceID=0x%x\",\n \t\t\teth_dev->data->port_id, pci_dev->id.vendor_id,\n \t\t\tpci_dev->id.device_id);\n", "prefixes": [ "09/13" ] }