Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52410/?format=api
{ "id": 52410, "url": "http://patches.dpdk.org/api/patches/52410/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1554745507-15089-6-git-send-email-g.singh@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1554745507-15089-6-git-send-email-g.singh@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1554745507-15089-6-git-send-email-g.singh@nxp.com", "date": "2019-04-08T11:22:36", "name": "[05/13] net/enetc: add statistics APIs", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9cf5d30e59f819fd01b65d4eb862ddb850db9928", "submitter": { "id": 1068, "url": "http://patches.dpdk.org/api/people/1068/?format=api", "name": "Gagandeep Singh", "email": "g.singh@nxp.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1554745507-15089-6-git-send-email-g.singh@nxp.com/mbox/", "series": [ { "id": 4173, "url": "http://patches.dpdk.org/api/series/4173/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4173", "date": "2019-04-08T11:22:28", "name": "ENETC PMD basic features and bug fixes", "version": 1, "mbox": "http://patches.dpdk.org/series/4173/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/52410/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/52410/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BCE3A56A1;\n\tMon, 8 Apr 2019 13:22:54 +0200 (CEST)", "from EUR02-AM5-obe.outbound.protection.outlook.com\n\t(mail-eopbgr00064.outbound.protection.outlook.com [40.107.0.64])\n\tby dpdk.org (Postfix) with ESMTP id 10A5F4D27\n\tfor <dev@dpdk.org>; Mon, 8 Apr 2019 13:22:38 +0200 (CEST)", "from VE1PR04MB6365.eurprd04.prod.outlook.com (10.255.118.78) by\n\tVE1PR04MB6606.eurprd04.prod.outlook.com (20.179.235.10) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1771.13; Mon, 8 Apr 2019 11:22:36 +0000", "from VE1PR04MB6365.eurprd04.prod.outlook.com\n\t([fe80::f5ad:f178:4c55:13e0]) by\n\tVE1PR04MB6365.eurprd04.prod.outlook.com\n\t([fe80::f5ad:f178:4c55:13e0%3]) with mapi id 15.20.1771.016;\n\tMon, 8 Apr 2019 11:22:36 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=8e8uw61QGdbBIdOpq5sc3GieXKZ3Sf2ZpubZo7JtkIo=;\n\tb=NzZJonqnF5++0XLVsWPLXf1L+I/3Xw5H9yOvxUcPc/izKnIeJt6mQIV4rCnV1dHH1E7ypr6noWB+pzzvB3sB1rQRZObeWg+GsTYoF0o4h3JQm46RKbjbmX5/D4ypaWfkcAsjv/7iTDlJdP6moinF6j8G4sLBnCkxd7GuN0b2wAI=", "From": "Gagandeep Singh <G.Singh@nxp.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>, \"ferruh.yigit@intel.com\"\n\t<ferruh.yigit@intel.com>", "CC": "Gagandeep Singh <G.Singh@nxp.com>", "Thread-Topic": "[PATCH 05/13] net/enetc: add statistics APIs", "Thread-Index": "AQHU7f1ekGH5ZeWco0C1VKbwhysAkw==", "Date": "Mon, 8 Apr 2019 11:22:36 +0000", "Message-ID": "<1554745507-15089-6-git-send-email-g.singh@nxp.com>", "References": "<1554745507-15089-1-git-send-email-g.singh@nxp.com>", "In-Reply-To": "<1554745507-15089-1-git-send-email-g.singh@nxp.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "BM1PR0101CA0003.INDPRD01.PROD.OUTLOOK.COM\n\t(2603:1096:b00:18::13) To VE1PR04MB6365.eurprd04.prod.outlook.com\n\t(2603:10a6:803:12a::14)", "x-mailer": "git-send-email 1.9.1", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=G.Singh@nxp.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-originating-ip": "[92.120.1.67]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "ae2d8a60-0be6-4f8d-2f35-08d6bc14807b", "x-ms-office365-filtering-ht": "Tenant", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(5600139)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020);\n\tSRVR:VE1PR04MB6606; ", "x-ms-traffictypediagnostic": "VE1PR04MB6606:", "x-microsoft-antispam-prvs": "<VE1PR04MB6606F541BB5E163B54FFB0CBE12C0@VE1PR04MB6606.eurprd04.prod.outlook.com>", "x-forefront-prvs": "0001227049", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(366004)(376002)(346002)(39860400002)(396003)(136003)(199004)(189003)(76176011)(97736004)(81156014)(71200400001)(71190400001)(72206003)(3846002)(25786009)(81166006)(53936002)(2616005)(5660300002)(6116002)(8676002)(7736002)(446003)(478600001)(8936002)(11346002)(305945005)(2906002)(256004)(14444005)(66066001)(6512007)(476003)(6436002)(486006)(50226002)(2501003)(99286004)(106356001)(86362001)(110136005)(4326008)(6486002)(68736007)(105586002)(6506007)(52116002)(316002)(26005)(386003)(14454004)(186003)(36756003)(102836004);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6606;\n\tH:VE1PR04MB6365.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "JF80fzSnqYJI2nXmUxuSSdOeU1xEnGs6ZE745hHvWDP6cE3fkBwBbb6+xgM24tg2x7pQ6OEw9tPSjtu3QUi3n6Ktaky+YqheWJSedxC8xBaBEbr6ZGCpnnsqmqdkXilAVdFx1alcE7AJDP+BmV2dd0CaSA7bY9iL6DNpnGTJ5gXcTZL4+XRIbnreg+xavW8+90AB5kAikF+SLOPZb10RDZqWW0bQSRrClx4VpTA5y7rEWT6kc+VnD5glBL3m7GcVn8wdLvzs27kDX+ssrnTFWm8nBYUMegAsWiQQjrmIUVaRCnyMOzwazJ8cLNAURmZHPM1UwBRKEm+5vlq6q4N0zzAylBIBSdWawvxsYP76vEqkw7lpusbNe593lhIVKctgttbF2fQzMNJNJiSynQT/7H076CTPeml7V2lQv4hYj2k=", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "ae2d8a60-0be6-4f8d-2f35-08d6bc14807b", "X-MS-Exchange-CrossTenant-originalarrivaltime": "08 Apr 2019 11:22:36.4491\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VE1PR04MB6606", "Subject": "[dpdk-dev] [PATCH 05/13] net/enetc: add statistics APIs", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Add basic statistics APIs enetc_stats_get\nand enetc_stats_reset.\n\nSigned-off-by: Gagandeep Singh <g.singh@nxp.com>\n---\n doc/guides/nics/enetc.rst | 1 +\n doc/guides/nics/features/enetc.ini | 1 +\n drivers/net/enetc/base/enetc_hw.h | 27 +++++++++++++++++++++-\n drivers/net/enetc/enetc_ethdev.c | 46 ++++++++++++++++++++++++++++++++++++++\n 4 files changed, 74 insertions(+), 1 deletion(-)", "diff": "diff --git a/doc/guides/nics/enetc.rst b/doc/guides/nics/enetc.rst\nindex 8038bf2..9f575d2 100644\n--- a/doc/guides/nics/enetc.rst\n+++ b/doc/guides/nics/enetc.rst\n@@ -46,6 +46,7 @@ ENETC Features\n \n - Link Status\n - Packet type information\n+- Basic stats\n \n NIC Driver (PMD)\n ~~~~~~~~~~~~~~~~\ndiff --git a/doc/guides/nics/features/enetc.ini b/doc/guides/nics/features/enetc.ini\nindex 69476a2..d8bd567 100644\n--- a/doc/guides/nics/features/enetc.ini\n+++ b/doc/guides/nics/features/enetc.ini\n@@ -6,6 +6,7 @@\n [Features]\n Packet type parsing = Y\n Link status = Y\n+Basic stats = Y\n Linux VFIO = Y\n ARMv8 = Y\n Usage doc = Y\ndiff --git a/drivers/net/enetc/base/enetc_hw.h b/drivers/net/enetc/base/enetc_hw.h\nindex e3738a6..3f0a2a9 100644\n--- a/drivers/net/enetc/base/enetc_hw.h\n+++ b/drivers/net/enetc/base/enetc_hw.h\n@@ -115,8 +115,33 @@\n #define ENETC_G_EIPBRR0\t\t\t0x00bf8\n #define ENETC_G_EIPBRR1\t\t\t0x00bfc\n \n-\n /* MAC Counters */\n+/* Config register to reset counters*/\n+#define ENETC_PM0_STAT_CONFIG\t\t0x080E0\n+/* Receive frames counter without error */\n+#define ENETC_PM0_RFRM\t\t\t0x08120\n+/* Receive packets counter, good + bad */\n+#define ENETC_PM0_RPKT\t\t\t0x08160\n+/* Received octets, good + bad */\n+#define ENETC_PM0_REOCT\t\t\t0x08120\n+/* Transmit octets, good + bad */\n+#define ENETC_PM0_TEOCT\t\t\t0x08200\n+/* Transmit frames counter without error */\n+#define ENETC_PM0_TFRM\t\t\t0x08220\n+/* Transmit packets counter, good + bad */\n+#define ENETC_PM0_TPKT\t\t\t0x08260\n+/* Dropped not Truncated packets counter */\n+#define ENETC_PM0_RDRNTP\t\t0x081C8\n+/* Dropped + trucated packets counter */\n+#define ENETC_PM0_RDRP\t\t\t0x08158\n+/* Receive packets error counter */\n+#define ENETC_PM0_RERR\t\t\t0x08138\n+/* Transmit packets error counter */\n+#define ENETC_PM0_TERR\t\t\t0x08238\n+\n+/* Stats Reset Bit*/\n+#define ENETC_CLEAR_STATS\t\tBIT(2)\n+\n #define ENETC_G_EPFBLPR(n)\t\t(0xd00 + 4 * (n))\n #define ENETC_G_EPFBLPR1_XGMII\t\t0x80000000\n \ndiff --git a/drivers/net/enetc/enetc_ethdev.c b/drivers/net/enetc/enetc_ethdev.c\nindex 91e9692..99c2ce7 100644\n--- a/drivers/net/enetc/enetc_ethdev.c\n+++ b/drivers/net/enetc/enetc_ethdev.c\n@@ -29,6 +29,9 @@ static int enetc_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id,\n \t\tconst struct rte_eth_txconf *tx_conf);\n static void enetc_tx_queue_release(void *txq);\n static const uint32_t *enetc_supported_ptypes_get(struct rte_eth_dev *dev);\n+static int enetc_stats_get(struct rte_eth_dev *dev,\n+\t\tstruct rte_eth_stats *stats);\n+static void enetc_stats_reset(struct rte_eth_dev *dev);\n \n /*\n * The set of PCI devices this driver supports\n@@ -46,6 +49,8 @@ static int enetc_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id,\n \t.dev_stop = enetc_dev_stop,\n \t.dev_close = enetc_dev_close,\n \t.link_update = enetc_link_update,\n+\t.stats_get = enetc_stats_get,\n+\t.stats_reset = enetc_stats_reset,\n \t.dev_infos_get = enetc_dev_infos_get,\n \t.rx_queue_setup = enetc_rx_queue_setup,\n \t.rx_queue_release = enetc_rx_queue_release,\n@@ -608,6 +613,47 @@ static int enetc_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id,\n \trte_free(rx_ring);\n }\n \n+static\n+int enetc_stats_get(struct rte_eth_dev *dev,\n+\t\t struct rte_eth_stats *stats)\n+{\n+\tstruct enetc_eth_hw *hw =\n+\t\tENETC_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n+\tstruct enetc_hw *enetc_hw = &hw->hw;\n+\n+\tif (stats == NULL)\n+\t\treturn -1;\n+\n+\tmemset(stats, 0, sizeof(struct rte_eth_stats));\n+\n+\t/* Total received packets, bad + good, if we want to get counters of\n+\t * only good received packets then use ENETC_PM0_RFRM,\n+\t * ENETC_PM0_TFRM registers.\n+\t */\n+\tstats->ipackets = enetc_port_rd(enetc_hw, ENETC_PM0_RPKT);\n+\tstats->opackets = enetc_port_rd(enetc_hw, ENETC_PM0_TPKT);\n+\tstats->ibytes = enetc_port_rd(enetc_hw, ENETC_PM0_REOCT);\n+\tstats->obytes = enetc_port_rd(enetc_hw, ENETC_PM0_TEOCT);\n+\t/* Dropped + Truncated packets, use ENETC_PM0_RDRNTP for without\n+\t * truncated packets\n+\t */\n+\tstats->imissed = enetc_port_rd(enetc_hw, ENETC_PM0_RDRP);\n+\tstats->ierrors = enetc_port_rd(enetc_hw, ENETC_PM0_RERR);\n+\tstats->oerrors = enetc_port_rd(enetc_hw, ENETC_PM0_TERR);\n+\n+\treturn 0;\n+}\n+\n+static void\n+enetc_stats_reset(struct rte_eth_dev *dev)\n+{\n+\tstruct enetc_eth_hw *hw =\n+\t\tENETC_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n+\tstruct enetc_hw *enetc_hw = &hw->hw;\n+\n+\tenetc_port_wr(enetc_hw, ENETC_PM0_STAT_CONFIG, ENETC_CLEAR_STATS);\n+}\n+\n static int\n enetc_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,\n \t\t\t struct rte_pci_device *pci_dev)\n", "prefixes": [ "05/13" ] }