Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52406/?format=api
{ "id": 52406, "url": "http://patches.dpdk.org/api/patches/52406/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/1554745507-15089-2-git-send-email-g.singh@nxp.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1554745507-15089-2-git-send-email-g.singh@nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1554745507-15089-2-git-send-email-g.singh@nxp.com", "date": "2019-04-08T11:22:30", "name": "[01/13] net/enetc: support physical addressing mode", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "916566433544d94f581f377415ffbb8f8adba6b5", "submitter": { "id": 1068, "url": "http://patches.dpdk.org/api/people/1068/?format=api", "name": "Gagandeep Singh", "email": "g.singh@nxp.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/1554745507-15089-2-git-send-email-g.singh@nxp.com/mbox/", "series": [ { "id": 4173, "url": "http://patches.dpdk.org/api/series/4173/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4173", "date": "2019-04-08T11:22:28", "name": "ENETC PMD basic features and bug fixes", "version": 1, "mbox": "http://patches.dpdk.org/series/4173/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/52406/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/52406/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 9212A4CA6;\n\tMon, 8 Apr 2019 13:22:36 +0200 (CEST)", "from EUR03-AM5-obe.outbound.protection.outlook.com\n\t(mail-eopbgr30048.outbound.protection.outlook.com [40.107.3.48])\n\tby dpdk.org (Postfix) with ESMTP id 8D0E22C24\n\tfor <dev@dpdk.org>; Mon, 8 Apr 2019 13:22:31 +0200 (CEST)", "from VE1PR04MB6365.eurprd04.prod.outlook.com (10.255.118.78) by\n\tVE1PR04MB6606.eurprd04.prod.outlook.com (20.179.235.10) with\n\tMicrosoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n\t15.20.1771.13; Mon, 8 Apr 2019 11:22:30 +0000", "from VE1PR04MB6365.eurprd04.prod.outlook.com\n\t([fe80::f5ad:f178:4c55:13e0]) by\n\tVE1PR04MB6365.eurprd04.prod.outlook.com\n\t([fe80::f5ad:f178:4c55:13e0%3]) with mapi id 15.20.1771.016;\n\tMon, 8 Apr 2019 11:22:30 +0000" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=ybZ61S27Q6kkgR0IkUGCVyPKuPN/TOiO6hj66IWrWPQ=;\n\tb=INj/H+GNqpzYgUDBidEkXHWyqh4G1UmdR9xSJS8pkRqbOzo98BpGxS/SuKGfQcWjBO5uDphpUkGzbTrT9cRhqgAX1yUjQXUINi9sM2LzMV2TqdP2cGeZpSMjQqxRvWtWOs3GcNHLqlaU85UDAjCcFho82XK8KVA6Al9feiFBy6k=", "From": "Gagandeep Singh <G.Singh@nxp.com>", "To": "\"dev@dpdk.org\" <dev@dpdk.org>, \"ferruh.yigit@intel.com\"\n\t<ferruh.yigit@intel.com>", "CC": "Gagandeep Singh <G.Singh@nxp.com>", "Thread-Topic": "[PATCH 01/13] net/enetc: support physical addressing mode", "Thread-Index": "AQHU7f1akMNK1l7MG0KptGTjV/DZiQ==", "Date": "Mon, 8 Apr 2019 11:22:30 +0000", "Message-ID": "<1554745507-15089-2-git-send-email-g.singh@nxp.com>", "References": "<1554745507-15089-1-git-send-email-g.singh@nxp.com>", "In-Reply-To": "<1554745507-15089-1-git-send-email-g.singh@nxp.com>", "Accept-Language": "en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-clientproxiedby": "BM1PR0101CA0003.INDPRD01.PROD.OUTLOOK.COM\n\t(2603:1096:b00:18::13) To VE1PR04MB6365.eurprd04.prod.outlook.com\n\t(2603:10a6:803:12a::14)", "x-mailer": "git-send-email 1.9.1", "authentication-results": "spf=none (sender IP is )\n\tsmtp.mailfrom=G.Singh@nxp.com; ", "x-ms-exchange-messagesentrepresentingtype": "1", "x-originating-ip": "[92.120.1.67]", "x-ms-publictraffictype": "Email", "x-ms-office365-filtering-correlation-id": "3ddbb8b2-6af6-4fc5-b7b4-08d6bc147cd0", "x-ms-office365-filtering-ht": "Tenant", "x-microsoft-antispam": "BCL:0; PCL:0;\n\tRULEID:(2390118)(7020095)(4652040)(8989299)(5600139)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020);\n\tSRVR:VE1PR04MB6606; ", "x-ms-traffictypediagnostic": "VE1PR04MB6606:", "x-microsoft-antispam-prvs": "<VE1PR04MB6606A51DF5FA4B4B9FC1CBF2E12C0@VE1PR04MB6606.eurprd04.prod.outlook.com>", "x-forefront-prvs": "0001227049", "x-forefront-antispam-report": "SFV:NSPM;\n\tSFS:(10009020)(366004)(376002)(346002)(39860400002)(396003)(136003)(199004)(189003)(76176011)(97736004)(81156014)(71200400001)(71190400001)(72206003)(3846002)(25786009)(81166006)(53936002)(2616005)(5660300002)(6116002)(8676002)(7736002)(446003)(478600001)(8936002)(11346002)(305945005)(2906002)(256004)(66066001)(6512007)(476003)(6436002)(486006)(50226002)(2501003)(99286004)(106356001)(86362001)(110136005)(4326008)(6486002)(68736007)(105586002)(6506007)(52116002)(316002)(26005)(386003)(14454004)(186003)(36756003)(102836004);\n\tDIR:OUT; SFP:1101; SCL:1; SRVR:VE1PR04MB6606;\n\tH:VE1PR04MB6365.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en;\n\tPTR:InfoNoRecords; A:1; MX:1; ", "received-spf": "None (protection.outlook.com: nxp.com does not designate\n\tpermitted sender hosts)", "x-ms-exchange-senderadcheck": "1", "x-microsoft-antispam-message-info": "BukpIo3IrzvhXlSbOr55FSEjzYBN+zZUsuRUX2M8eaegxDilmtawS3HgC6sLOS1ZPlaPVL3yCNxJ+Cc+AisshHhHXaeV4gGey4yki/AuQUKRhJ8ykVlGZINRs+Ln05ga2l+I+Jck4C7BX/1m1YB3N0YA7AE0jASjXgCFEY5nZWRmMwNyVi4GSGbf0PrWk1789GfjvYX3+o+fosyupfW3DyKhmeGSJzBbQjGD3cp0sc0n5lAZN4myNfYWs+PqAUsN4vDpWpG93FlfIm03/MMJdGKSeHhMBbarsLKt8NODpkl7S+RQMeO+NHlthw6RJtrTEFep9J7dLBAAE0Fs0Zzm25mf70HejAIUQ2+ibfUOIBQNx6TJYuEE2xSa9bFxPl5iHgsU6ORaTW2h87Gvpq2kwn8v0MlTZ/Ti9EQuDWfAfsc=", "Content-Type": "text/plain; charset=\"iso-8859-1\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "3ddbb8b2-6af6-4fc5-b7b4-08d6bc147cd0", "X-MS-Exchange-CrossTenant-originalarrivaltime": "08 Apr 2019 11:22:30.4518\n\t(UTC)", "X-MS-Exchange-CrossTenant-fromentityheader": "Hosted", "X-MS-Exchange-CrossTenant-id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-mailboxtype": "HOSTED", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VE1PR04MB6606", "Subject": "[dpdk-dev] [PATCH 01/13] net/enetc: support physical addressing mode", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Support added for physical addressing mode and\nchange driver flags to don't care.\n\nSigned-off-by: Gagandeep Singh <g.singh@nxp.com>\n---\n drivers/net/enetc/enetc_ethdev.c | 22 ++++++++++++----------\n drivers/net/enetc/enetc_rxtx.c | 6 +++---\n 2 files changed, 15 insertions(+), 13 deletions(-)", "diff": "diff --git a/drivers/net/enetc/enetc_ethdev.c b/drivers/net/enetc/enetc_ethdev.c\nindex 023fe75..7a9a97d 100644\n--- a/drivers/net/enetc/enetc_ethdev.c\n+++ b/drivers/net/enetc/enetc_ethdev.c\n@@ -1,5 +1,5 @@\n /* SPDX-License-Identifier: BSD-3-Clause\n- * Copyright 2018 NXP\n+ * Copyright 2018-2019 NXP\n */\n \n #include <stdbool.h>\n@@ -334,14 +334,15 @@ static int enetc_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id,\n enetc_setup_txbdr(struct enetc_hw *hw, struct enetc_bdr *tx_ring)\n {\n \tint idx = tx_ring->index;\n-\tuintptr_t base_addr;\n \tuint32_t tbmr;\n+\tphys_addr_t bd_address;\n \n-\tbase_addr = (uintptr_t)tx_ring->bd_base;\n+\tbd_address = (phys_addr_t)\n+\t\t rte_mem_virt2iova((const void *)tx_ring->bd_base);\n \tenetc_txbdr_wr(hw, idx, ENETC_TBBAR0,\n-\t\t lower_32_bits((uint64_t)base_addr));\n+\t\t lower_32_bits((uint64_t)bd_address));\n \tenetc_txbdr_wr(hw, idx, ENETC_TBBAR1,\n-\t\t upper_32_bits((uint64_t)base_addr));\n+\t\t upper_32_bits((uint64_t)bd_address));\n \tenetc_txbdr_wr(hw, idx, ENETC_TBLENR,\n \t\t ENETC_RTBLENR_LEN(tx_ring->bd_count));\n \n@@ -478,14 +479,15 @@ static int enetc_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id,\n \t\t struct rte_mempool *mb_pool)\n {\n \tint idx = rx_ring->index;\n-\tuintptr_t base_addr;\n \tuint16_t buf_size;\n+\tphys_addr_t bd_address;\n \n-\tbase_addr = (uintptr_t)rx_ring->bd_base;\n+\tbd_address = (phys_addr_t)\n+\t\t rte_mem_virt2iova((const void *)rx_ring->bd_base);\n \tenetc_rxbdr_wr(hw, idx, ENETC_RBBAR0,\n-\t\t lower_32_bits((uint64_t)base_addr));\n+\t\t lower_32_bits((uint64_t)bd_address));\n \tenetc_rxbdr_wr(hw, idx, ENETC_RBBAR1,\n-\t\t upper_32_bits((uint64_t)base_addr));\n+\t\t upper_32_bits((uint64_t)bd_address));\n \tenetc_rxbdr_wr(hw, idx, ENETC_RBLENR,\n \t\t ENETC_RTBLENR_LEN(rx_ring->bd_count));\n \n@@ -612,7 +614,7 @@ static int enetc_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id,\n \n static struct rte_pci_driver rte_enetc_pmd = {\n \t.id_table = pci_id_enetc_map,\n-\t.drv_flags = RTE_PCI_DRV_NEED_MAPPING | RTE_PCI_DRV_IOVA_AS_VA,\n+\t.drv_flags = RTE_PCI_DRV_NEED_MAPPING,\n \t.probe = enetc_pci_probe,\n \t.remove = enetc_pci_remove,\n };\ndiff --git a/drivers/net/enetc/enetc_rxtx.c b/drivers/net/enetc/enetc_rxtx.c\nindex 631e243..a31a387 100644\n--- a/drivers/net/enetc/enetc_rxtx.c\n+++ b/drivers/net/enetc/enetc_rxtx.c\n@@ -1,5 +1,5 @@\n /* SPDX-License-Identifier: BSD-3-Clause\n- * Copyright 2018 NXP\n+ * Copyright 2018-2019 NXP\n */\n \n #include <stdbool.h>\n@@ -64,7 +64,7 @@\n \t\ttxbd->buf_len = txbd->frm_len;\n \t\ttxbd->flags = rte_cpu_to_le_16(ENETC_TXBD_FLAGS_F);\n \t\ttxbd->addr = (uint64_t)(uintptr_t)\n-\t\trte_cpu_to_le_64((size_t)tx_swbd->buffer_addr->buf_addr +\n+\t\trte_cpu_to_le_64((size_t)tx_swbd->buffer_addr->buf_iova +\n \t\t\t\t tx_swbd->buffer_addr->data_off);\n \t\ti++;\n \t\tstart++;\n@@ -91,7 +91,7 @@\n \t\trx_swbd->buffer_addr =\n \t\t\trte_cpu_to_le_64(rte_mbuf_raw_alloc(rx_ring->mb_pool));\n \t\trxbd->w.addr = (uint64_t)(uintptr_t)\n-\t\t\t rx_swbd->buffer_addr->buf_addr +\n+\t\t\t rx_swbd->buffer_addr->buf_iova +\n \t\t\t rx_swbd->buffer_addr->data_off;\n \t\t/* clear 'R\" as well */\n \t\trxbd->r.lstatus = 0;\n", "prefixes": [ "01/13" ] }