Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52392/?format=api
{ "id": 52392, "url": "http://patches.dpdk.org/api/patches/52392/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190408094640.46030-6-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190408094640.46030-6-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190408094640.46030-6-bruce.richardson@intel.com", "date": "2019-04-08T09:46:40", "name": "[v3,5/5] net/i40e: fix dereference before check when getting EEPROM", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "bbb8dada159c4b1f2227b95fc0b0d7ebe74e685a", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190408094640.46030-6-bruce.richardson@intel.com/mbox/", "series": [ { "id": 4162, "url": "http://patches.dpdk.org/api/series/4162/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4162", "date": "2019-04-08T09:46:35", "name": "some small fixes", "version": 3, "mbox": "http://patches.dpdk.org/series/4162/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/52392/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/52392/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id C94EB5689;\n\tMon, 8 Apr 2019 11:47:13 +0200 (CEST)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n\tby dpdk.org (Postfix) with ESMTP id EE706559A;\n\tMon, 8 Apr 2019 11:47:10 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t08 Apr 2019 02:47:10 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.222.236])\n\tby orsmga001.jf.intel.com with ESMTP; 08 Apr 2019 02:47:08 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,324,1549958400\"; d=\"scan'208\";a=\"221512891\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>, stable@dpdk.org,\n\tzijie.pan@6wind.com, Beilei Xing <beilei.xing@intel.com>,\n\tQi Zhang <qi.z.zhang@intel.com>, Rami Rosen <ramirose@gmail.com>", "Date": "Mon, 8 Apr 2019 10:46:40 +0100", "Message-Id": "<20190408094640.46030-6-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190408094640.46030-1-bruce.richardson@intel.com>", "References": "<20190405134511.49066-1-bruce.richardson@intel.com>\n\t<20190408094640.46030-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v3 5/5] net/i40e: fix dereference before check\n\twhen getting EEPROM", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "As flagged by coverity, the \"info\" structure is being explicitly\ndereferenced before being checked later for a NULL value.\n\nCoverity issue: 277241\nFixes: 98e60c0d43f1 (\"net/i40e: add module EEPROM callbacks for i40e\")\nCC: stable@dpdk.org\nCc: zijie.pan@6wind.com\nCC: Beilei Xing <beilei.xing@intel.com>\nCC: Qi Zhang <qi.z.zhang@intel.com>\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-by: Rami Rosen <ramirose@gmail.com>\n---\n drivers/net/i40e/i40e_ethdev.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c\nindex 5b01dc1f0..9305b7ac1 100644\n--- a/drivers/net/i40e/i40e_ethdev.c\n+++ b/drivers/net/i40e/i40e_ethdev.c\n@@ -11901,16 +11901,17 @@ static int i40e_get_module_eeprom(struct rte_eth_dev *dev,\n \tstruct i40e_hw *hw = I40E_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n \tbool is_sfp = false;\n \ti40e_status status;\n-\tuint8_t *data = info->data;\n+\tuint8_t *data;\n \tuint32_t value = 0;\n \tuint32_t i;\n \n-\tif (!info || !info->length || !data)\n+\tif (!info || !info->length || !info->data)\n \t\treturn -EINVAL;\n \n \tif (hw->phy.link_info.module_type[0] == I40E_MODULE_TYPE_SFP)\n \t\tis_sfp = true;\n \n+\tdata = info->data;\n \tfor (i = 0; i < info->length; i++) {\n \t\tu32 offset = i + info->offset;\n \t\tu32 addr = is_sfp ? I40E_I2C_EEPROM_DEV_ADDR : 0;\n", "prefixes": [ "v3", "5/5" ] }