Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 52373,
    "url": "http://patches.dpdk.org/api/patches/52373/?format=api",
    "web_url": "http://patches.dpdk.org/project/dpdk/patch/cacf4fc79730e6c2225636214d0d1d8a39b62316.1554613242.git.shahafs@mellanox.com/",
    "project": {
        "id": 1,
        "url": "http://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<cacf4fc79730e6c2225636214d0d1d8a39b62316.1554613242.git.shahafs@mellanox.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/cacf4fc79730e6c2225636214d0d1d8a39b62316.1554613242.git.shahafs@mellanox.com",
    "date": "2019-04-07T05:02:24",
    "name": "[v4,1/3] app/testpmd: fix mempool free on exit",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "004bbe03bb919b2d6bcfb1ac1a8741bc7e0f48db",
    "submitter": {
        "id": 634,
        "url": "http://patches.dpdk.org/api/people/634/?format=api",
        "name": "Shahaf Shuler",
        "email": "shahafs@mellanox.com"
    },
    "delegate": {
        "id": 319,
        "url": "http://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "http://patches.dpdk.org/project/dpdk/patch/cacf4fc79730e6c2225636214d0d1d8a39b62316.1554613242.git.shahafs@mellanox.com/mbox/",
    "series": [
        {
            "id": 4153,
            "url": "http://patches.dpdk.org/api/series/4153/?format=api",
            "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4153",
            "date": "2019-04-07T05:02:23",
            "name": "DMA map anonymous memory to eth devices",
            "version": 4,
            "mbox": "http://patches.dpdk.org/series/4153/mbox/"
        }
    ],
    "comments": "http://patches.dpdk.org/api/patches/52373/comments/",
    "check": "success",
    "checks": "http://patches.dpdk.org/api/patches/52373/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id BB416397D;\n\tSun,  7 Apr 2019 07:02:49 +0200 (CEST)",
            "from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129])\n\tby dpdk.org (Postfix) with ESMTP id 0A0592BD8\n\tfor <dev@dpdk.org>; Sun,  7 Apr 2019 07:02:43 +0200 (CEST)",
            "from Internal Mail-Server by MTLPINE1 (envelope-from\n\tshahafs@mellanox.com)\n\twith ESMTPS (AES256-SHA encrypted); 7 Apr 2019 08:02:36 +0300",
            "from unicorn01.mtl.labs.mlnx. (unicorn01.mtl.labs.mlnx\n\t[10.7.12.62])\n\tby labmailer.mlnx (8.13.8/8.13.8) with ESMTP id x3752Zb1016030;\n\tSun, 7 Apr 2019 08:02:35 +0300"
        ],
        "From": "Shahaf Shuler <shahafs@mellanox.com>",
        "To": "wenzhuo.lu@intel.com, jingjing.wu@intel.com, bernard.iremonger@intel.com",
        "Cc": "dev@dpdk.org, rasland@mellanox.com, thomas@monjalon.net,\n\tferruh.yigit@intel.com, stable@dpdk.org",
        "Date": "Sun,  7 Apr 2019 08:02:24 +0300",
        "Message-Id": "<cacf4fc79730e6c2225636214d0d1d8a39b62316.1554613242.git.shahafs@mellanox.com>",
        "X-Mailer": "git-send-email 2.12.0",
        "In-Reply-To": "<cover.1554613242.git.shahafs@mellanox.com>",
        "References": "<cover.1554406293.git.shahafs@mellanox.com>\n\t<cover.1554613242.git.shahafs@mellanox.com>",
        "Subject": "[dpdk-dev] [PATCH v4 1/3] app/testpmd: fix mempool free on exit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "Allocated mempools were never free. it is bad practice.\n\nFixes: af75078fece3 (\"first public release\")\nCc: stable@dpdk.org\n\nSigned-off-by: Shahaf Shuler <shahafs@mellanox.com>\n---\n app/test-pmd/testpmd.c | 24 ++++++++++++++++++------\n 1 file changed, 18 insertions(+), 6 deletions(-)",
    "diff": "diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c\nindex aeaa74c989..b7f70b0c47 100644\n--- a/app/test-pmd/testpmd.c\n+++ b/app/test-pmd/testpmd.c\n@@ -188,6 +188,8 @@ struct fwd_engine * fwd_engines[] = {\n \tNULL,\n };\n \n+struct rte_mempool *mempools[RTE_MAX_NUMA_NODES];\n+\n struct fwd_config cur_fwd_config;\n struct fwd_engine *cur_fwd_eng = &io_fwd_engine; /**< IO mode by default. */\n uint32_t retry_enabled;\n@@ -835,7 +837,7 @@ setup_extmem(uint32_t nb_mbufs, uint32_t mbuf_sz, bool huge)\n /*\n  * Configuration initialisation done once at init time.\n  */\n-static void\n+static struct rte_mempool *\n mbuf_pool_create(uint16_t mbuf_seg_size, unsigned nb_mbuf,\n \t\t unsigned int socket_id)\n {\n@@ -913,6 +915,7 @@ mbuf_pool_create(uint16_t mbuf_seg_size, unsigned nb_mbuf,\n \t} else if (verbose_level > 0) {\n \t\trte_mempool_dump(stdout, rte_mp);\n \t}\n+\treturn rte_mp;\n }\n \n /*\n@@ -1130,14 +1133,18 @@ init_config(void)\n \t\tuint8_t i;\n \n \t\tfor (i = 0; i < num_sockets; i++)\n-\t\t\tmbuf_pool_create(mbuf_data_size, nb_mbuf_per_pool,\n-\t\t\t\t\t socket_ids[i]);\n+\t\t\tmempools[i] = mbuf_pool_create(mbuf_data_size,\n+\t\t\t\t\t\t       nb_mbuf_per_pool,\n+\t\t\t\t\t\t       socket_ids[i]);\n \t} else {\n \t\tif (socket_num == UMA_NO_CONFIG)\n-\t\t\tmbuf_pool_create(mbuf_data_size, nb_mbuf_per_pool, 0);\n+\t\t\tmempools[0] = mbuf_pool_create(mbuf_data_size,\n+\t\t\t\t\t\t       nb_mbuf_per_pool, 0);\n \t\telse\n-\t\t\tmbuf_pool_create(mbuf_data_size, nb_mbuf_per_pool,\n-\t\t\t\t\t\t socket_num);\n+\t\t\tmempools[socket_num] = mbuf_pool_create\n+\t\t\t\t\t\t\t(mbuf_data_size,\n+\t\t\t\t\t\t\t nb_mbuf_per_pool,\n+\t\t\t\t\t\t\t socket_num);\n \t}\n \n \tinit_port_config();\n@@ -2394,6 +2401,7 @@ pmd_test_exit(void)\n \tstruct rte_device *device;\n \tportid_t pt_id;\n \tint ret;\n+\tint i;\n \n \tif (test_done == 0)\n \t\tstop_packet_forwarding();\n@@ -2447,6 +2455,10 @@ pmd_test_exit(void)\n \t\t\treturn;\n \t\t}\n \t}\n+\tfor (i = 0 ; i < RTE_MAX_NUMA_NODES ; i++) {\n+\t\tif (mempools[i])\n+\t\t\trte_mempool_free(mempools[i]);\n+\t}\n \n \tprintf(\"\\nBye...\\n\");\n }\n",
    "prefixes": [
        "v4",
        "1/3"
    ]
}