Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52361/?format=api
{ "id": 52361, "url": "http://patches.dpdk.org/api/patches/52361/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190405162205.4824-2-marcinx.hajkowski@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190405162205.4824-2-marcinx.hajkowski@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190405162205.4824-2-marcinx.hajkowski@intel.com", "date": "2019-04-05T16:22:03", "name": "[1/3] power: return error in set env when power env already set", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c2034d17061ce67aea7316cc158f5d8222984546", "submitter": { "id": 1246, "url": "http://patches.dpdk.org/api/people/1246/?format=api", "name": "Marcin Hajkowski", "email": "marcinx.hajkowski@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190405162205.4824-2-marcinx.hajkowski@intel.com/mbox/", "series": [ { "id": 4147, "url": "http://patches.dpdk.org/api/series/4147/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4147", "date": "2019-04-05T16:22:02", "name": "rte_power enhancement", "version": 1, "mbox": "http://patches.dpdk.org/series/4147/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/52361/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/52361/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 266451B56E;\n\tFri, 5 Apr 2019 18:23:41 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id C5C691B55F\n\tfor <dev@dpdk.org>; Fri, 5 Apr 2019 18:23:37 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Apr 2019 09:23:37 -0700", "from mhajkowx-mobl.ger.corp.intel.com ([10.104.116.181])\n\tby fmsmga002.fm.intel.com with ESMTP; 05 Apr 2019 09:23:36 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,313,1549958400\"; d=\"scan'208\";a=\"158588042\"", "From": "Hajkowski <marcinx.hajkowski@intel.com>", "To": "david.hunt@intel.com", "Cc": "dev@dpdk.org, Marcin Hajkowski <marcinx.hajkowski@intel.com>,\n\tAnatoly Burakov <anatoly.burakov@intel.com>", "Date": "Fri, 5 Apr 2019 18:22:03 +0200", "Message-Id": "<20190405162205.4824-2-marcinx.hajkowski@intel.com>", "X-Mailer": "git-send-email 2.20.1.windows.1", "In-Reply-To": "<20190405162205.4824-1-marcinx.hajkowski@intel.com>", "References": "<20190405162205.4824-1-marcinx.hajkowski@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 1/3] power: return error in set env when power\n\tenv already set", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Marcin Hajkowski <marcinx.hajkowski@intel.com>\n\nOn attempt to set_env in already initialized state notify\nuser by returning error that operation cannot be performed.\n\nSigned-off-by: Marcin Hajkowski <marcinx.hajkowski@intel.com>\nAcked-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_power/rte_power.c | 3 ++-\n lib/librte_power/rte_power.h | 3 ++-\n 2 files changed, 4 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/librte_power/rte_power.c b/lib/librte_power/rte_power.c\nindex 540d69be7..ed701087d 100644\n--- a/lib/librte_power/rte_power.c\n+++ b/lib/librte_power/rte_power.c\n@@ -33,8 +33,9 @@ rte_power_set_env(enum power_management_env env)\n \trte_spinlock_lock(&global_env_cfg_lock);\n \n \tif (global_default_env != PM_ENV_NOT_SET) {\n+\t\tRTE_LOG(ERR, POWER, \"Power Management Environment already set.\\n\");\n \t\trte_spinlock_unlock(&global_env_cfg_lock);\n-\t\treturn 0;\n+\t\treturn -1;\n \t}\n \n \tint ret = 0;\ndiff --git a/lib/librte_power/rte_power.h b/lib/librte_power/rte_power.h\nindex 47db69f33..0650112ad 100644\n--- a/lib/librte_power/rte_power.h\n+++ b/lib/librte_power/rte_power.h\n@@ -26,7 +26,8 @@ enum power_management_env {PM_ENV_NOT_SET, PM_ENV_ACPI_CPUFREQ, PM_ENV_KVM_VM,\n /**\n * Set the default power management implementation. If this is not called prior\n * to rte_power_init(), then auto-detect of the environment will take place.\n- * It is thread safe.\n+ * It is thread safe. New env can be set only in unitialized state\n+ * (thus rte_power_unset_env must be called if different env was already set).\n *\n * @param env\n * env. The environment in which to initialise Power Management for.\n", "prefixes": [ "1/3" ] }