Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52357/?format=api
{ "id": 52357, "url": "http://patches.dpdk.org/api/patches/52357/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190405153320.61694-1-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190405153320.61694-1-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190405153320.61694-1-bruce.richardson@intel.com", "date": "2019-04-05T15:33:20", "name": "net/af_xdp: simplify meson build specification", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "96275e3e84d295bc10d89b3073f0fc13292d7181", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 319, "url": "http://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190405153320.61694-1-bruce.richardson@intel.com/mbox/", "series": [ { "id": 4144, "url": "http://patches.dpdk.org/api/series/4144/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4144", "date": "2019-04-05T15:33:20", "name": "net/af_xdp: simplify meson build specification", "version": 1, "mbox": "http://patches.dpdk.org/series/4144/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/52357/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/52357/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 5EBB41B53E;\n\tFri, 5 Apr 2019 17:33:32 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n\tby dpdk.org (Postfix) with ESMTP id 6DF0F1B53A\n\tfor <dev@dpdk.org>; Fri, 5 Apr 2019 17:33:31 +0200 (CEST)", "from orsmga007.jf.intel.com ([10.7.209.58])\n\tby fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Apr 2019 08:33:29 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.222.236])\n\tby orsmga007.jf.intel.com with ESMTP; 05 Apr 2019 08:33:28 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,313,1549958400\"; d=\"scan'208\";a=\"128929051\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org, ferruh.yigit@intel.com, Xiaolong Ye <xiaolong.ye@intel.com>", "Cc": "Bruce Richardson <bruce.richardson@intel.com>", "Date": "Fri, 5 Apr 2019 16:33:20 +0100", "Message-Id": "<20190405153320.61694-1-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190405152041.47092-1-ferruh.yigit@intel.com>", "References": "<20190405152041.47092-1-ferruh.yigit@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH] net/af_xdp: simplify meson build specification", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "The build spec has lots of levels of indentation, which can be reduced by\nnot explicitly checking for linux, but for the needed header and library\nfiles needed for the driver.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/net/af_xdp/meson.build | 25 +++++++++++--------------\n 1 file changed, 11 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/net/af_xdp/meson.build b/drivers/net/af_xdp/meson.build\nindex 840c93728..7904840f0 100644\n--- a/drivers/net/af_xdp/meson.build\n+++ b/drivers/net/af_xdp/meson.build\n@@ -1,19 +1,16 @@\n # SPDX-License-Identifier: BSD-3-Clause\n # Copyright(c) 2019 Intel Corporation\n \n-if host_machine.system() == 'linux'\n-\tbpf_dep = dependency('libbpf', required: false)\n-\tif bpf_dep.found()\n-\t\tbuild = true\n-\telse\n-\t\tbpf_dep = cc.find_library('bpf', required: false)\n-\t\tif bpf_dep.found() and cc.has_header('bpf/xsk.h', dependencies: bpf_dep) and cc.has_header('linux/if_xdp.h')\n-\t\t\tbuild = true\n-\t\t\tpkgconfig_extra_libs += '-lbpf'\n-\t\telse\n-\t\t\tbuild = false\n-\t\tendif\n-\tendif\n+sources = files('rte_eth_af_xdp.c')\n+\n+bpf_dep = dependency('libbpf', required: false)\n+if not bpf_dep.found()\n+\tbpf_dep = cc.find_library('bpf', required: false)\n+endif\n+\n+if bpf_dep.found() and cc.has_header('bpf/xsk.h') and cc.has_header('linux/if_xdp.h')\n \text_deps += bpf_dep\n+\tpkgconfig_extra_libs += '-lbpf'\n+else\n+\tbuild = false\n endif\n-sources = files('rte_eth_af_xdp.c')\n", "prefixes": [] }