Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52353/?format=api
http://patches.dpdk.org/api/patches/52353/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190405143709.50352-4-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190405143709.50352-4-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190405143709.50352-4-bruce.richardson@intel.com", "date": "2019-04-05T14:37:07", "name": "[v2,3/5] net/i40e: fix dereference before NULL check in mbuf release", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c93cbca52d9d935936fc8eba9b3a9d7fceea1076", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190405143709.50352-4-bruce.richardson@intel.com/mbox/", "series": [ { "id": 4142, "url": "http://patches.dpdk.org/api/series/4142/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4142", "date": "2019-04-05T14:37:04", "name": "some small fixes", "version": 2, "mbox": "http://patches.dpdk.org/series/4142/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/52353/comments/", "check": "warning", "checks": "http://patches.dpdk.org/api/patches/52353/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id CE6731B551;\n\tFri, 5 Apr 2019 16:37:32 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id 15F8C1B53F;\n\tFri, 5 Apr 2019 16:37:28 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n\tby orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Apr 2019 07:37:28 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.222.236])\n\tby orsmga003.jf.intel.com with ESMTP; 05 Apr 2019 07:37:26 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,313,1549958400\"; d=\"scan'208\";a=\"140280847\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>, qi.z.zhang@intel.com,\n\tstable@dpdk.org, Rami Rosen <ramirose@gmail.com>", "Date": "Fri, 5 Apr 2019 15:37:07 +0100", "Message-Id": "<20190405143709.50352-4-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190405143709.50352-1-bruce.richardson@intel.com>", "References": "<20190405134511.49066-1-bruce.richardson@intel.com>\n\t<20190405143709.50352-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v2 3/5] net/i40e: fix dereference before NULL\n\tcheck in mbuf release", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Coverity flags that the txq variable is used before it's checked for NULL.\nAlso fix typo in error message.\n\nCoverity issue: 195023\nFixes: 24853544c84c (\"net/i40e: fix mbuf free in vector Tx\")\nCc: qi.z.zhang@intel.com\nCC: stable@dpdk.org\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nAcked-By: Rami Rosen <ramirose@gmail.com>\n\n---\nV2: Fix typo or copy/paste error while fixing main issue\n---\n drivers/net/i40e/i40e_rxtx.c | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c\nindex 8f727fae6..282e18bc1 100644\n--- a/drivers/net/i40e/i40e_rxtx.c\n+++ b/drivers/net/i40e/i40e_rxtx.c\n@@ -2423,13 +2423,13 @@ i40e_tx_queue_release_mbufs(struct i40e_tx_queue *txq)\n \tstruct rte_eth_dev *dev;\n \tuint16_t i;\n \n-\tdev = &rte_eth_devices[txq->port_id];\n-\n \tif (!txq || !txq->sw_ring) {\n-\t\tPMD_DRV_LOG(DEBUG, \"Pointer to rxq or sw_ring is NULL\");\n+\t\tPMD_DRV_LOG(DEBUG, \"Pointer to txq or sw_ring is NULL\");\n \t\treturn;\n \t}\n \n+\tdev = &rte_eth_devices[txq->port_id];\n+\n \t/**\n \t * vPMD tx will not set sw_ring's mbuf to NULL after free,\n \t * so need to free remains more carefully.\n", "prefixes": [ "v2", "3/5" ] }{ "id": 52353, "url": "