Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52343/?format=api
{ "id": 52343, "url": "http://patches.dpdk.org/api/patches/52343/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190405134511.49066-3-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190405134511.49066-3-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190405134511.49066-3-bruce.richardson@intel.com", "date": "2019-04-05T13:45:08", "name": "[2/5] examples/vhost_scsi: fix missing NULL-check for parameter", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c2cdd6517e123a9a2b51a4b086fa8ac4ce9ecab4", "submitter": { "id": 20, "url": "http://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190405134511.49066-3-bruce.richardson@intel.com/mbox/", "series": [ { "id": 4138, "url": "http://patches.dpdk.org/api/series/4138/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4138", "date": "2019-04-05T13:45:06", "name": "some small fixes", "version": 1, "mbox": "http://patches.dpdk.org/series/4138/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/52343/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/52343/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id E46771B51A;\n\tFri, 5 Apr 2019 15:45:29 +0200 (CEST)", "from mga12.intel.com (mga12.intel.com [192.55.52.136])\n\tby dpdk.org (Postfix) with ESMTP id A469A1B512;\n\tFri, 5 Apr 2019 15:45:27 +0200 (CEST)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n\tby fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Apr 2019 06:45:26 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.222.236])\n\tby fmsmga007.fm.intel.com with ESMTP; 05 Apr 2019 06:45:25 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,312,1549958400\"; d=\"scan'208\";a=\"140383679\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>, stable@dpdk.org,\n\tMaxime Coquelin <maxime.coquelin@redhat.com>,\n\tTiwei Bie <tiwei.bie@intel.com>, Zhihong Wang <zhihong.wang@intel.com>", "Date": "Fri, 5 Apr 2019 14:45:08 +0100", "Message-Id": "<20190405134511.49066-3-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.20.1", "In-Reply-To": "<20190405134511.49066-1-bruce.richardson@intel.com>", "References": "<20190405134511.49066-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 2/5] examples/vhost_scsi: fix missing NULL-check\n\tfor parameter", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Coverity points out that there is a check in the main thread loop for the\nctrlr->bdev being NULL, but by that stage the pointer has already been\ndereferenced. Therefore, for safety, before we enter the loop do an\ninitial check on the parameter structure.\n\nCoverity issue: 158657\nFixes: db75c7af19bb (\"examples/vhost_scsi: introduce a new sample app\")\nCC: stable@dpdk.org\nCC: Maxime Coquelin <maxime.coquelin@redhat.com>\nCC: Tiwei Bie <tiwei.bie@intel.com>\nCC: Zhihong Wang <zhihong.wang@intel.com>\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n examples/vhost_scsi/vhost_scsi.c | 6 ++++++\n 1 file changed, 6 insertions(+)", "diff": "diff --git a/examples/vhost_scsi/vhost_scsi.c b/examples/vhost_scsi/vhost_scsi.c\nindex 2908ff68b..a6465d089 100644\n--- a/examples/vhost_scsi/vhost_scsi.c\n+++ b/examples/vhost_scsi/vhost_scsi.c\n@@ -285,6 +285,12 @@ ctrlr_worker(void *arg)\n \tcpu_set_t cpuset;\n \tpthread_t thread;\n \n+\tif (ctrlr == NULL || ctrlr->bdev == NULL) {\n+\t\tfprintf(stdout, \"%s: Error, invalid argument passed to worker thread\\n\",\n+\t\t\t\t__func__);\n+\t\treturn NULL;\n+\t}\n+\n \tthread = pthread_self();\n \tCPU_ZERO(&cpuset);\n \tCPU_SET(0, &cpuset);\n", "prefixes": [ "2/5" ] }