Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/52336/?format=api
{ "id": 52336, "url": "http://patches.dpdk.org/api/patches/52336/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/patch/20190405132455.15468-2-marcinx.hajkowski@intel.com/", "project": { "id": 1, "url": "http://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20190405132455.15468-2-marcinx.hajkowski@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20190405132455.15468-2-marcinx.hajkowski@intel.com", "date": "2019-04-05T13:24:52", "name": "[v5,1/4] power: fix invalid socket indicator value", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e1a68c6d5a78e7ae735a1c60d9fa5276c4abc301", "submitter": { "id": 1246, "url": "http://patches.dpdk.org/api/people/1246/?format=api", "name": "Marcin Hajkowski", "email": "marcinx.hajkowski@intel.com" }, "delegate": { "id": 1, "url": "http://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patches.dpdk.org/project/dpdk/patch/20190405132455.15468-2-marcinx.hajkowski@intel.com/mbox/", "series": [ { "id": 4136, "url": "http://patches.dpdk.org/api/series/4136/?format=api", "web_url": "http://patches.dpdk.org/project/dpdk/list/?series=4136", "date": "2019-04-05T13:24:51", "name": "bidirect guest channel", "version": 5, "mbox": "http://patches.dpdk.org/series/4136/mbox/" } ], "comments": "http://patches.dpdk.org/api/patches/52336/comments/", "check": "success", "checks": "http://patches.dpdk.org/api/patches/52336/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 10C641B4F4;\n\tFri, 5 Apr 2019 15:28:21 +0200 (CEST)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n\tby dpdk.org (Postfix) with ESMTP id 30B891B4C8;\n\tFri, 5 Apr 2019 15:28:15 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t05 Apr 2019 06:28:14 -0700", "from mhajkowx-mobl.ger.corp.intel.com ([10.104.116.181])\n\tby fmsmga002.fm.intel.com with ESMTP; 05 Apr 2019 06:28:13 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.60,312,1549958400\"; d=\"scan'208\";a=\"158546456\"", "From": "Hajkowski <marcinx.hajkowski@intel.com>", "To": "david.hunt@intel.com", "Cc": "dev@dpdk.org, Marcin Hajkowski <marcinx.hajkowski@intel.com>,\n\tstable@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>,\n\tAnatoly Burakov <anatoly.burakov@intel.com>", "Date": "Fri, 5 Apr 2019 15:24:52 +0200", "Message-Id": "<20190405132455.15468-2-marcinx.hajkowski@intel.com>", "X-Mailer": "git-send-email 2.20.1.windows.1", "In-Reply-To": "<20190405132455.15468-1-marcinx.hajkowski@intel.com>", "References": "<20190405132455.15468-1-marcinx.hajkowski@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v5 1/4] power: fix invalid socket indicator value", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "Reply-To": "20190402082121.5472-1-marcinx.hajkowski@intel.com", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Marcin Hajkowski <marcinx.hajkowski@intel.com>\n\nCurrently 0 is being used for not connected slot indication.\nThis is not consistent with linux doc which identifies 0 as valid\n(connected) slot, thus modification was done to change it.\n\nFixes: cd0d5547 (\"power: vm communication channels in guest\")\nCc: stable@dpdk.org\n\nSigned-off-by: Marcin Hajkowski <marcinx.hajkowski@intel.com>\nReviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>\nAcked-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/librte_power/guest_channel.c | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/lib/librte_power/guest_channel.c b/lib/librte_power/guest_channel.c\nindex c17ea46b4..9cf7d2cb2 100644\n--- a/lib/librte_power/guest_channel.c\n+++ b/lib/librte_power/guest_channel.c\n@@ -19,7 +19,7 @@\n \n #define RTE_LOGTYPE_GUEST_CHANNEL RTE_LOGTYPE_USER1\n \n-static int global_fds[RTE_MAX_LCORE];\n+static int global_fds[RTE_MAX_LCORE] = { [0 ... RTE_MAX_LCORE-1] = -1 };\n \n int\n guest_channel_host_connect(const char *path, unsigned int lcore_id)\n@@ -35,7 +35,7 @@ guest_channel_host_connect(const char *path, unsigned int lcore_id)\n \t\treturn -1;\n \t}\n \t/* check if path is already open */\n-\tif (global_fds[lcore_id] != 0) {\n+\tif (global_fds[lcore_id] != -1) {\n \t\tRTE_LOG(ERR, GUEST_CHANNEL, \"Channel(%u) is already open with fd %d\\n\",\n \t\t\t\tlcore_id, global_fds[lcore_id]);\n \t\treturn -1;\n@@ -84,7 +84,7 @@ guest_channel_host_connect(const char *path, unsigned int lcore_id)\n \treturn 0;\n error:\n \tclose(fd);\n-\tglobal_fds[lcore_id] = 0;\n+\tglobal_fds[lcore_id] = -1;\n \treturn -1;\n }\n \n@@ -100,7 +100,7 @@ guest_channel_send_msg(struct channel_packet *pkt, unsigned int lcore_id)\n \t\treturn -1;\n \t}\n \n-\tif (global_fds[lcore_id] == 0) {\n+\tif (global_fds[lcore_id] < 0) {\n \t\tRTE_LOG(ERR, GUEST_CHANNEL, \"Channel is not connected\\n\");\n \t\treturn -1;\n \t}\n@@ -134,8 +134,8 @@ guest_channel_host_disconnect(unsigned int lcore_id)\n \t\t\t\tlcore_id, RTE_MAX_LCORE-1);\n \t\treturn;\n \t}\n-\tif (global_fds[lcore_id] == 0)\n+\tif (global_fds[lcore_id] < 0)\n \t\treturn;\n \tclose(global_fds[lcore_id]);\n-\tglobal_fds[lcore_id] = 0;\n+\tglobal_fds[lcore_id] = -1;\n }\n", "prefixes": [ "v5", "1/4" ] }